Re: [Fuego] [PATCH 04/16] parser: remove error message when no matches

["Bird, Timothy" <Tim.Bird@sony.com>]

> -----Original Message-----
> From Daniel Sangorrin on Wednesday, March 29, 2017 6:05 PM
>
> This is not supposed to be a parser error, it's rather
> an error in the test which is already managed later

I don't see anywhere else in the parser where failure to find the
benchmark metrics is reported to the user.  This test is a bit crude.
A better one would be to check for all metrics that are supposed
to be there.  (That test would have to be test-specific, and the
way some parsers work is they don't even have the strings for
the metrics themselves - it comes from the regex applied to the
test log.  So maybe this idea is not feasible.)

Is there somewhere else in the system (besides the parser) that catches
this type of error and reports it to the user?  (I guess missing benchmark
data might do it.)
 -- Tim

 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
>  engine/scripts/parser/common.py | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/engine/scripts/parser/common.py
> b/engine/scripts/parser/common.py
> index d0bdde5..fd74827 100644
> --- a/engine/scripts/parser/common.py
> +++ b/engine/scripts/parser/common.py
> @@ -98,9 +98,8 @@ def write_report_results(rep_data):
> 
> 
>  def process_data(ref_section_pat, cur_dict, m, label):
> -	if not cur_dict:
> -		print "\nFuego error reason: could not parse test results in
> %s\n" % CUR_LOG
> -		sys.exit(1)
> +        if not cur_dict:
> +                sys.exit(1)
> 
>          if custom_write_report == False:
>                  write_report_results(cur_dict)
> --
> 2.7.4
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego