From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Sony.onmicrosoft.com; s=selector1-Sony-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yGCZGqUyso4HMcOQiQuvhCtNCqjMtja/ZjkM5RKhsKo=; b=NTgXTA2rn7swwgGmMBFVf1VCilNlcShGLP54pCdW+QtmQ4RkePGaMpzF4UYHLpu1U4PBF8ggXq+QwSTwz7aTGRJ2nkTnQtz6EYICuSAe5m9kYZvSVCfXW02Z5s43ec4kfwgoY6rle7jo9u0pXMo7ehKLujbYGGZUQkPVHoB2qLc= From: "Bird, Timothy" Date: Thu, 13 Apr 2017 01:15:14 +0000 Message-ID: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Fuego] Fuego URL/port configuration issues List-Id: Mailing list for the Fuego test framework List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "fuego@lists.linuxfoundation.org" Cc: dhinakar k > From: Bird, Timothy on Wednesday, April 12, 2017 3:50 PM>=20 > I was poking around Fuego today and stumbled upon a problem related to > the Jenkins URL configuration, including the port number. >=20 > Basically, JENKINS_URL (which includes the current port number for Jenkin= s) > does not show > up in a job environment until after a user has been to the Jenkins > configuration page and > saved it (at least one time). >=20 > Because of this behavior, abort_job in common.sh has a hardcoded URL for > accessing Jenkins. > (It should rely on BUILD_URL, but this also is missing sometimes). >=20 > If we want to fully support allowing users to change the port number for > Jenkins, we will have > to come up with a solution for the abort_job() function. My guess is tha= t > we'll want to > actually configure the jenkins URL at docker image creation time, or on f= irst > run of Jenkins > inside the container. Apparently if the file > /var/lib/jenkins/jenkins.model/JenkinsLocationConfiguration.xml > exists, then Jenkins uses that to define the JENKINS_URL (and other _URL) > environment variable. > So maybe we just need to create one at provision time. I haven't tested = this > yet. >=20 > Anyway I thought I should report this issue. I've made a Fuego issue for= it at: > http://bird.org/fuego/Issue_0039 >=20 > Dhinakar - in the short term you can, of course, edit fuego- > core/engine/scripts/common.sh, function abort_job, > and put the correct port in the URL used there. But we need to figure ou= t a > better long-term solution for this. >=20 OK - I've fixed this item for Fuego 1.1 - a fix is now at the top of the '= master' branch for this. It turns out that if you add a jenkins.model.JenkinsLocationConfiguration.x= ml file, Jenkins will detect it and hand out correct URLs, without requiring special user ac= tion. I've modified abort_job accordingly. Now, if someone wants to change the port they need to change = it in the Jenkins configuration, and in this file, which starts in fuego/frontend-ins= tall, and ends up in the container in /var/lib/jenkins. Enjoy! -- Tim