All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bird, Timothy" <Tim.Bird@sony.com>
To: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>,
	"'Liu, Wenlong'" <liuwl.fnst@cn.fujitsu.com>,
	"fuego@lists.linuxfoundation.org"
	<fuego@lists.linuxfoundation.org>
Subject: Re: [Fuego] How to return test_processing result if	multiple	"log_compare" exist
Date: Mon, 4 Dec 2017 09:08:57 +0000	[thread overview]
Message-ID: <ECADFF3FD767C149AD96A924E7EA6EAF40ADB00A@USCULXMSG01.am.sony.com> (raw)
In-Reply-To: <001801d36cc8$83da30d0$8b8e9270$@toshiba.co.jp>



> -----Original Message-----
> From: Daniel Sangorrin on Monday, December 04, 2017 3:24 PM
> In Functional.bzip2 I used to log_copares. Please check commit 01808b7

Hmmm.  This type of handling didn't used to be needed, because we
are running with set -e in the shell, so the first error (non-zero return)
would terminate test_processing, and the program would exit
at that point.

This changed with the refactoring we did for post-processing.

In git commit 309afa2f we modified the code so that test_processing
returning non-zero does NOT terminate the program.  This is the
correct behavior, given that we have additional work to do after this.
(We used to do additional post-processing in a separate Jenkins
action.)

In general I think that doing multiple log_compares is not the normal
case, or the preferred solution.
Using only counts of success and failure for evaluating the result
is pretty brittle, and is subject to missing an important transition
(e.g. a trivial failure starts succeeding at the same time a critical
test, that was passing previously, starts failing.)

I need to review this more, but I suspect it would be better to switch
the Functional.OpenSSL test case to using a parser.py and a criteria.json file.

But at least handling the multiple log_compares properly is an improvement.
 -- Tim


      parent reply	other threads:[~2017-12-04  9:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04  6:17 [Fuego] How to return test_processing result if multiple "log_compare" exist Liu, Wenlong
2017-12-04  6:24 ` Daniel Sangorrin
2017-12-04  6:31   ` Liu, Wenlong
2017-12-04  9:08   ` Bird, Timothy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ECADFF3FD767C149AD96A924E7EA6EAF40ADB00A@USCULXMSG01.am.sony.com \
    --to=tim.bird@sony.com \
    --cc=daniel.sangorrin@toshiba.co.jp \
    --cc=fuego@lists.linuxfoundation.org \
    --cc=liuwl.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.