From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Sony.onmicrosoft.com; s=selector1-Sony-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Er8E4y2eygQvG67ghdCJkW1BnZuVKJgTV+W+ZuXh6MM=; b=KzIL9OPerKsIeqJ9iyRvUrO/BJynICTbq67yjiNUvrQArI2LPMTVHezj5ge6rhcmtXX1jJRCyGUgdFHr8xP+qRGGr1Z8fUdHfaUbvVtsM7ajI72CEWhtuTiUMdRRA96VkWYgJdhHgIFK8t07tUVeeTCNXZeIupv8OVcdaRJ/OdA= From: Date: Thu, 27 Sep 2018 20:16:08 +0000 Message-ID: References: <1537858732-32952-1-git-send-email-daniel.sangorrin@toshiba.co.jp> <1537858732-32952-12-git-send-email-daniel.sangorrin@toshiba.co.jp> In-Reply-To: <1537858732-32952-12-git-send-email-daniel.sangorrin@toshiba.co.jp> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Fuego] [PATCH 11/11] LTP: use git instead of tarball by default List-Id: Mailing list for the Fuego test framework List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: daniel.sangorrin@toshiba.co.jp, fuego@lists.linuxfoundation.org > -----Original Message----- > From: Daniel Sangorrin >=20 > This change can be discussed, but personally I always > use the git version. Now that if_source_changed is supported > it is even more useful. I'm still uncomfortable with the source for a test changing automatically, = and possibly without the tester's knowledge. I'm worried that different versions of LTP will produce different results, and = that will cause confusion trying to compare results between sites. (Note: We don't currently allow people to compare results between sites, but that's an envisioned feature for the future. Adding the testsuite_ver= sion to the LTP file helps a lot in this regard.) Let's discuss this one more, as there may be another mechanism that would work for both of us (maybe a board variable or a site configuration variabl= e). This was not applied. -- Tim >=20 > Signed-off-by: Daniel Sangorrin > --- > engine/tests/Functional.LTP/fuego_test.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/engine/tests/Functional.LTP/fuego_test.sh > b/engine/tests/Functional.LTP/fuego_test.sh > index a378573..6c5871e 100755 > --- a/engine/tests/Functional.LTP/fuego_test.sh > +++ b/engine/tests/Functional.LTP/fuego_test.sh > @@ -1,5 +1,5 @@ > -# gitrepo=3D"https://github.com/linux-test-project/ltp.git" > -tarball=3Dltp-full-20180118.tar.bz2 > +gitrepo=3D" https://github.com/linux-test-project/ltp.git" > +#tarball=3Dltp-full-20180118.tar.bz2 >=20 > NEED_ROOT=3D1 >=20 > -- > 2.7.4 >=20 > _______________________________________________ > Fuego mailing list > Fuego@lists.linuxfoundation.org > https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__lists.linuxfoundation.org_mailman_listinfo_fuego&d=3DDwICAg&c=3DfP4tf= - > -1dS0biCFlB0saz0I0kjO5v7- > GLPtvShAo4cc&r=3DjjTc71ylyJg68rRxrFQuDFMMybIqPCnrHF85A- > GzCRg&m=3DqvMHzm_M5MVRsAkMXJIw2hsZsQuFX2jDsnFZkB3zwlY&s=3DQKaH > Q42v7ummrqryEOApGCZcfCUZ84SB_GBhGZAFvZA&e=3D