All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: "Atharva Raykar" <raykar.ath@gmail.com>,
	"Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: Git List <git@vger.kernel.org>,
	Emily Shaffer <emilyshaffer@google.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Christian Couder <christian.couder@gmail.com>,
	Shourya Shukla <periperidip@gmail.com>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Prathamesh Chavan <pc44800@gmail.com>,
	Rafael Silva <rafaeloliveira.cs@gmail.com>
Subject: Re: [GSoC] [PATCH v2 2/4] submodule: prefix die messages with 'fatal'
Date: Sat, 10 Jul 2021 17:34:30 +0530	[thread overview]
Message-ID: <ED07F10B-BE44-4BCC-873A-73688683CCF4@gmail.com> (raw)
In-Reply-To: <598E78EB-48B1-4C2E-BD89-90EF003A15F6@gmail.com>

Hi Atharva,


On 10 ஜூலை, 2021 பிற்பகல் 1:22:16 IST, Atharva Raykar <raykar.ath@gmail.com> wrote:
>
>
>> On 09-Jul-2021, at 20:22, Đoàn Trần Công Danh <congdanhqx@gmail.com>
>wrote:
>> 
>> On 2021-07-08 15:25:31+0530, Atharva Raykar <raykar.ath@gmail.com>
>wrote:
>>> The standard `die()` function that is used in C code prefixes all
>the
>>> messages passed to it with 'fatal: '. This does not happen with the
>>> `die` used in 'git-submodule.sh'.
>>> 
>>> Let's prefix each of the shell die messages with 'fatal: ' so that
>when
>>> they are converted to C code, the error messages stay the same as
>before
>>> the conversion.
>> 
>> That sounds good.
>> 
>>> --- a/git-submodule.sh
>>> +++ b/git-submodule.sh
>>> @@ -147,7 +147,7 @@ cmd_add()
>>> 
>>> 	if ! git submodule--helper config --check-writeable >/dev/null 2>&1
>>> 	then
>>> -		 die "$(eval_gettext "please make sure that the .gitmodules file
>is in the working tree")"
>>> +		 die "$(eval_gettext "fatal: please make sure that the
>.gitmodules file is in the working tree")"
>> 
>> Except that, "fatal: " isn't subjected to translation. And this will
>> create new translatable item for translator. Perhaps:
>> 
>> -		 die "$(eval_gettext "please make sure that the .gitmodules file
>is in the working tree")"
>> +		 die "fatal: $(eval_gettext "please make sure that the .gitmodules
>file is in the working tree")"
>
>Okay, I have made the change. I was wondering if there any specific
>reason as to why 'fatal' should not be translated? Is it because
>an intermediate change like this should not create more work for
>translators? 

Yes. That's likely the intention.

-- 
Sivaraam

Sent from my Android device with K-9 Mail. Please excuse my brevity.

  reply	other threads:[~2021-07-10 12:04 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 18:19 [GSoC] [PATCH 0/3] submodule add: partial conversion to C Atharva Raykar
2021-07-06 18:19 ` [GSoC] [PATCH 1/3] t7400: test failure to add submodule in tracked path Atharva Raykar
2021-07-06 18:19 ` [GSoC] [PATCH 2/3] submodule--helper: refactor module_clone() Atharva Raykar
2021-07-06 18:19 ` [GSoC] [PATCH 3/3] submodule--helper: introduce add-clone subcommand Atharva Raykar
2021-07-07 19:57   ` Junio C Hamano
2021-07-08  6:45     ` Atharva Raykar
2021-07-08  9:55 ` [GSoC] [PATCH v2 0/4] submodule add: partial conversion to C Atharva Raykar
2021-07-08  9:55   ` [GSoC] [PATCH v2 1/4] t7400: test failure to add submodule in tracked path Atharva Raykar
2021-07-08  9:55   ` [GSoC] [PATCH v2 2/4] submodule: prefix die messages with 'fatal' Atharva Raykar
2021-07-08 15:17     ` Junio C Hamano
2021-07-09 14:52     ` Đoàn Trần Công Danh
2021-07-10  7:52       ` Atharva Raykar
2021-07-10 12:04         ` Kaartic Sivaraam [this message]
2021-07-08  9:55   ` [GSoC] [PATCH v2 3/4] submodule--helper: refactor module_clone() Atharva Raykar
2021-07-08  9:55   ` [GSoC] [PATCH v2 4/4] submodule--helper: introduce add-clone subcommand Atharva Raykar
2021-07-10  7:47   ` [GSoC] [PATCH v3 0/4] submodule add: partial conversion to C Atharva Raykar
2021-07-10  7:47     ` [GSoC] [PATCH v3 1/4] t7400: test failure to add submodule in tracked path Atharva Raykar
2021-07-10  7:47     ` [GSoC] [PATCH v3 2/4] submodule: prefix die messages with 'fatal' Atharva Raykar
2021-07-10  7:48     ` [GSoC] [PATCH v3 3/4] submodule--helper: refactor module_clone() Atharva Raykar
2021-07-10  7:48     ` [GSoC] [PATCH v3 4/4] submodule--helper: introduce add-clone subcommand Atharva Raykar
2021-07-23 11:12       ` [PATCH] submodule: drop unused sm_name parameter from show_fetch_remotes() Jeff King
2021-07-23 17:12         ` Atharva Raykar
2021-07-26 19:03           ` Junio C Hamano
2021-08-05 19:28       ` [PATCH] submodule--helper: fix incorrect newlines in an error message Kaartic Sivaraam
2021-08-06  6:29         ` Atharva Raykar
2021-08-06 19:07           ` Kaartic Sivaraam
2021-09-18 19:31         ` [PATCH v2 0/1] submodule: corret an incorrectly formatted " Kaartic Sivaraam
2021-09-18 19:31           ` [PATCH v2 1/1] submodule--helper: fix incorrect newlines in an " Kaartic Sivaraam
2021-09-20 18:09             ` Junio C Hamano
2021-09-21 16:52               ` Atharva Raykar
2021-09-21 16:47             ` Atharva Raykar
2021-10-23 12:57               ` [PATCH v3 0/1] submodule: correct an incorrectly formatted " Kaartic Sivaraam
2021-10-23 12:57                 ` [PATCH v3 1/1] submodule--helper: fix incorrect newlines in an " Kaartic Sivaraam
2021-10-24  6:05                 ` [PATCH v3 0/1] submodule: correct an incorrectly formatted " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ED07F10B-BE44-4BCC-873A-73688683CCF4@gmail.com \
    --to=kaartic.sivaraam@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=congdanhqx@gmail.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=pc44800@gmail.com \
    --cc=periperidip@gmail.com \
    --cc=rafaeloliveira.cs@gmail.com \
    --cc=raykar.ath@gmail.com \
    --cc=sunshine@sunshineco.com \
    --subject='Re: [GSoC] [PATCH v2 2/4] submodule: prefix die messages with '\''fatal'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.