From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tan, Jianfeng" Subject: Re: [PATCH v2 3/7] net/virtio_user: move vhost user specific code Date: Mon, 26 Dec 2016 06:58:58 +0000 Message-ID: References: <1480689075-66977-1-git-send-email-jianfeng.tan@intel.com> <1482477266-39199-1-git-send-email-jianfeng.tan@intel.com> <1482477266-39199-4-git-send-email-jianfeng.tan@intel.com> <20161226062821.GB19288@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Yigit, Ferruh" , "Liang, Cunming" To: Yuanhan Liu Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6261D2B86 for ; Mon, 26 Dec 2016 07:59:02 +0100 (CET) In-Reply-To: <20161226062821.GB19288@yliu-dev.sh.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Monday, December 26, 2016 2:28 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Yigit, Ferruh; Liang, Cunming > Subject: Re: [PATCH v2 3/7] net/virtio_user: move vhost user specific cod= e >=20 > On Fri, Dec 23, 2016 at 07:14:22AM +0000, Jianfeng Tan wrote: > > To support vhost kernel as the backend of net_virtio_user in coming > > patches, we move vhost_user specific structs and macros into > > vhost_user.c, and only keep common definitions in vhost.h. >=20 > Good. >=20 > > Besides, remove VHOST_USER_MQ feature check, it will be added back > > in following multiqueue patch. >=20 > Why then? Only vhost user recognizes this feature bit, and vhost kernel does not. My = intension is to put those vhost user specific code inside vhost user. And i= n fact, I forget to add it back. I should add it back in this patch. Thanks, Jianfeng >=20 > --yliu