All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v2] net/virtio-user: fix cannot get initialized
Date: Fri, 14 Apr 2017 04:35:57 +0000	[thread overview]
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E365119F47A@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170414042423.GI7333@yliu-dev.sh.intel.com>



> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Friday, April 14, 2017 12:24 PM
> To: Tan, Jianfeng
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com
> Subject: Re: [PATCH v2] net/virtio-user: fix cannot get initialized
> 
> On Thu, Apr 13, 2017 at 10:11:27AM +0000, Jianfeng Tan wrote:
> > The feature negotiation in virtio-user is proven to be broken,
> > which results in device initialization failure.
> >
> > Originally, we get features from vhost backend, and remove those
> > that are not supported. But when new feature is added, for example,
> > VIRTIO_NET_F_MTU, we fail to remove this new feature. Then, this
> > new feature will be negotiated, as both frontend and backend claim
> > to support this feature.
> >
> > To fix it, we add a macro to record supported featues, as a filter
> > to remove newly added features.
> 
> Yes, this is much better! You now don't have to worry that virtio-user
> will be broken every time we add a new feature.
> 
> Applied to dpdk-next-virtio, with the title changed to "fix feature
> negotitation".
> 

Thanks. By the way, it's better backporting it to stable branches, however, I forget to CC stable@dpdk.org.

  reply	other threads:[~2017-04-14  4:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07  7:57 [PATCH] net/virtio-user: fix cannot get initialized Jianfeng Tan
2017-04-13  1:58 ` Yuanhan Liu
2017-04-13  2:18   ` Tan, Jianfeng
2017-04-13  2:21     ` Yuanhan Liu
2017-04-13  7:37       ` Tan, Jianfeng
2017-04-13  2:36     ` Yuanhan Liu
2017-04-13  7:39       ` Tan, Jianfeng
2017-04-13 10:11 ` [PATCH v2] " Jianfeng Tan
2017-04-14  4:24   ` Yuanhan Liu
2017-04-14  4:35     ` Tan, Jianfeng [this message]
2017-04-14  5:37       ` Yuanhan Liu
2017-04-14  5:55         ` Tan, Jianfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ED26CBA2FAD1BF48A8719AEF02201E365119F47A@SHSMSX103.ccr.corp.intel.com \
    --to=jianfeng.tan@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.