From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH v3 1/2] gro: code cleanup
Date: Wed, 3 Jan 2018 01:07:37 +0000
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E36513A40A0@SHSMSX103.ccr.corp.intel.com>
References: <1513219779-100115-1-git-send-email-jiayu.hu@intel.com>
 <1513927544-97241-1-git-send-email-jiayu.hu@intel.com>
 <1513927544-97241-2-git-send-email-jiayu.hu@intel.com>
 <20180102112600.GA10276@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Chen, Junjie J" <junjie.j.chen@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, "Yao, Lei A" <lei.a.yao@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>, "Hu, Jiayu"
 <jiayu.hu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 1AB111B012
 for <dev@dpdk.org>; Wed,  3 Jan 2018 02:07:41 +0100 (CET)
In-Reply-To: <20180102112600.GA10276@bricha3-MOBL3.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, January 2, 2018 7:26 PM
> To: Hu, Jiayu
> Cc: dev@dpdk.org; Tan, Jianfeng; Chen, Junjie J; Ananyev, Konstantin;
> stephen@networkplumber.org; Yigit, Ferruh; Yao, Lei A
> Subject: Re: [dpdk-dev] [PATCH v3 1/2] gro: code cleanup
>=20
> On Fri, Dec 22, 2017 at 03:25:43PM +0800, Jiayu Hu wrote:
> > - Remove needless check and variants
> > - For better understanding, update the programmer guide and rename
> >   internal functions and variants
> > - For supporting tunneled gro, move common internal functions from
> >   gro_tcp4.c to gro_tcp4.h
> > - Comply RFC 6864 to process the IPv4 ID field
> >
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> > ---
> >  .../prog_guide/generic_receive_offload_lib.rst     | 246 ++++++++-----=
--
> >  doc/guides/prog_guide/img/gro-key-algorithm.png    | Bin 0 -> 28231
> bytes
>=20
> Rather than binary PNG images, please use SVG files (note, real SVG, not
> an SVG file with a binary blob pasted into it).

Based on my limited experience, there is no shortcut for this, but re-draw =
the picture with tools like visio.

Thanks,
Jianfeng

>=20
> Thanks,
> /Bruce