From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tan, Jianfeng" Subject: Re: [PATCH v7 2/3] eal: rename mp_request to mp_request_sync Date: Mon, 2 Apr 2018 05:09:03 +0000 Message-ID: References: <4c704d02202e42be6b1d5a016a3cc35a5dcd11c4.1522502560.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Ananyev, Konstantin" , "thomas@monjalon.net" To: "Burakov, Anatoly" , "dev@dpdk.org" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5068B5F25 for ; Mon, 2 Apr 2018 07:09:07 +0200 (CEST) In-Reply-To: <4c704d02202e42be6b1d5a016a3cc35a5dcd11c4.1522502560.git.anatoly.burakov@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Burakov, Anatoly > Sent: Sunday, April 1, 2018 1:06 AM > To: dev@dpdk.org > Cc: Tan, Jianfeng; Ananyev, Konstantin; thomas@monjalon.net > Subject: [PATCH v7 2/3] eal: rename mp_request to mp_request_sync >=20 > Rename rte_mp_request to rte_mp_request_sync to indicate > that this request will be done synchronously (as opposed to > asynchronous request, which comes in next patch). >=20 > Also, fix alphabetical ordering for .map file. >=20 > Signed-off-by: Anatoly Burakov > Suggested-by: Thomas Monjalon Acked-by: Jianfeng Tan Thanks! > --- >=20 > Notes: > v7: > - Added this patch >=20 > lib/librte_eal/common/eal_common_proc.c | 2 +- > lib/librte_eal/common/include/rte_eal.h | 2 +- > lib/librte_eal/rte_eal_version.map | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/librte_eal/common/eal_common_proc.c > b/lib/librte_eal/common/eal_common_proc.c > index 52b6ab2..b704f5a 100644 > --- a/lib/librte_eal/common/eal_common_proc.c > +++ b/lib/librte_eal/common/eal_common_proc.c > @@ -674,7 +674,7 @@ mp_request_one(const char *dst, struct rte_mp_msg > *req, > } >=20 > int __rte_experimental > -rte_mp_request(struct rte_mp_msg *req, struct rte_mp_reply *reply, > +rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply > *reply, > const struct timespec *ts) > { > int dir_fd, ret =3D 0; > diff --git a/lib/librte_eal/common/include/rte_eal.h > b/lib/librte_eal/common/include/rte_eal.h > index 044474e..d1cc89e 100644 > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -314,7 +314,7 @@ rte_mp_sendmsg(struct rte_mp_msg *msg); > * - On failure, return -1, and the reason will be stored in rte_errno. > */ > int __rte_experimental > -rte_mp_request(struct rte_mp_msg *req, struct rte_mp_reply *reply, > +rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply > *reply, > const struct timespec *ts); >=20 > /** > diff --git a/lib/librte_eal/rte_eal_version.map > b/lib/librte_eal/rte_eal_version.map > index d123602..7b66c73 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -223,9 +223,9 @@ EXPERIMENTAL { > rte_eal_mbuf_user_pool_ops; > rte_mp_action_register; > rte_mp_action_unregister; > - rte_mp_sendmsg; > - rte_mp_request; > rte_mp_reply; > + rte_mp_request_sync; > + rte_mp_sendmsg; > rte_service_attr_get; > rte_service_attr_reset_all; > rte_service_component_register; > -- > 2.7.4