* [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC
@ 2017-04-30 20:00 Frank Rowand
2017-05-01 20:13 ` Rob Herring
0 siblings, 1 reply; 9+ messages in thread
From: Frank Rowand @ 2017-04-30 20:00 UTC (permalink / raw)
To: Rob Herring, stephen.boyd; +Cc: Frank Rowand, devicetree, linux-kernel
An undeclared variable was used in a macro that evaluates to nothing
when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct
variable that does exist.
---
reported by kbuild test robot on on robh/for-next
https://lkml.org/lkml/2017/4/29/134
drivers/of/base.c: In function '__of_add_phandle_sysfs':
>> drivers/of/base.c:198:23: error: 'pp' undeclared (first use in this function)
sysfs_bin_attr_init(&pp->attr);
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
drivers/of/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 9fe42346925b..8a7ca2a49ba8 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -195,7 +195,7 @@ int __of_add_phandle_sysfs(struct device_node *np)
if (!np->phandle || np->phandle == 0xffffffff)
return 0;
- sysfs_bin_attr_init(&pp->attr);
+ sysfs_bin_attr_init(&np->attr_phandle);
np->attr_phandle.attr.name = "phandle";
np->attr_phandle.attr.mode = 0444;
np->attr_phandle.size = sizeof(np->phandle);
--
Frank Rowand <frank.rowand@sony.com>
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC
@ 2017-05-01 20:13 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2017-05-01 20:13 UTC (permalink / raw)
To: Frank Rowand; +Cc: Stephen Boyd, devicetree, linux-kernel
On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand <frank.rowand@sony.com> wrote:
> An undeclared variable was used in a macro that evaluates to nothing
> when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct
> variable that does exist.
>
> ---
>
> reported by kbuild test robot on on robh/for-next
> https://lkml.org/lkml/2017/4/29/134
That's a bit misleading because I've not applied the offending patch.
Please squash this.
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC
@ 2017-05-01 20:13 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2017-05-01 20:13 UTC (permalink / raw)
To: Frank Rowand
Cc: Stephen Boyd, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org> wrote:
> An undeclared variable was used in a macro that evaluates to nothing
> when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct
> variable that does exist.
>
> ---
>
> reported by kbuild test robot on on robh/for-next
> https://lkml.org/lkml/2017/4/29/134
That's a bit misleading because I've not applied the offending patch.
Please squash this.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC
@ 2017-05-01 21:20 ` Rowand, Frank
0 siblings, 0 replies; 9+ messages in thread
From: Rowand, Frank @ 2017-05-01 21:20 UTC (permalink / raw)
To: Rob Herring; +Cc: Stephen Boyd, devicetree, linux-kernel, Frank Rowand
On Monday, May 01, 2017 1:13 PM, Rob Herring [mailto:robh+dt@kernel.org] wrote:
>
> On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand <frank.rowand@sony.com>
> wrote:
>> An undeclared variable was used in a macro that evaluates to nothing
>> when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct
>> variable that does exist.
>>
>> ---
>>
>> reported by kbuild test robot on on robh/for-next
>> https://lkml.org/lkml/2017/4/29/134
>
> That's a bit misleading because I've not applied the offending patch.
> Please squash this.
>
> Rob
Does "squash this" mean to redo the original path to include this fix?
Thanks,
Frank
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC
@ 2017-05-01 21:20 ` Rowand, Frank
0 siblings, 0 replies; 9+ messages in thread
From: Rowand, Frank @ 2017-05-01 21:20 UTC (permalink / raw)
To: Rob Herring
Cc: Stephen Boyd, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Frank Rowand
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 797 bytes --]
On Monday, May 01, 2017 1:13 PM, Rob Herring [mailto:robh+dt@kernel.org] wrote:
>
> On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand <frank.rowand@sony.com>
> wrote:
>> An undeclared variable was used in a macro that evaluates to nothing
>> when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct
>> variable that does exist.
>>
>> ---
>>
>> reported by kbuild test robot on on robh/for-next
>> https://lkml.org/lkml/2017/4/29/134
>
> That's a bit misleading because I've not applied the offending patch.
> Please squash this.
>
> Rob
Does "squash this" mean to redo the original path to include this fix?
Thanks,
Frank
N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·zøœzÚÞz)í…æèw*\x1fjg¬±¨\x1e¶‰šŽŠÝ¢j.ïÛ°\½½MŽúgjÌæa×\x02››–' ™©Þ¢¸\f¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾\a«‘êçzZ+ƒùšŽŠÝ¢j"ú!¶i
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC
@ 2017-05-01 22:23 ` Frank Rowand
0 siblings, 0 replies; 9+ messages in thread
From: Frank Rowand @ 2017-05-01 22:23 UTC (permalink / raw)
To: Rowand, Frank, Rob Herring; +Cc: Stephen Boyd, devicetree, linux-kernel
On 05/01/17 14:20, Rowand, Frank wrote:
> On Monday, May 01, 2017 1:13 PM, Rob Herring [mailto:robh+dt@kernel.org] wrote:
>>
>> On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand <frank.rowand@sony.com>
>> wrote:
>>> An undeclared variable was used in a macro that evaluates to nothing
>>> when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct
>>> variable that does exist.
>>>
>>> ---
>>>
>>> reported by kbuild test robot on on robh/for-next
>>> https://lkml.org/lkml/2017/4/29/134
>>
>> That's a bit misleading because I've not applied the offending patch.
>> Please squash this.
>>
>> Rob
>
> Does "squash this" mean to redo the original path to include this fix?
^^^^ patch
>
> Thanks,
>
> Frank
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC
@ 2017-05-01 22:23 ` Frank Rowand
0 siblings, 0 replies; 9+ messages in thread
From: Frank Rowand @ 2017-05-01 22:23 UTC (permalink / raw)
To: Rowand, Frank, Rob Herring
Cc: Stephen Boyd, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 05/01/17 14:20, Rowand, Frank wrote:
> On Monday, May 01, 2017 1:13 PM, Rob Herring [mailto:robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org] wrote:
>>
>> On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>
>> wrote:
>>> An undeclared variable was used in a macro that evaluates to nothing
>>> when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct
>>> variable that does exist.
>>>
>>> ---
>>>
>>> reported by kbuild test robot on on robh/for-next
>>> https://lkml.org/lkml/2017/4/29/134
>>
>> That's a bit misleading because I've not applied the offending patch.
>> Please squash this.
>>
>> Rob
>
> Does "squash this" mean to redo the original path to include this fix?
^^^^ patch
>
> Thanks,
>
> Frank
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC
@ 2017-04-30 20:45 ` frowand.list-Re5JQEeQqe8AvxtiuMwx3w
0 siblings, 0 replies; 9+ messages in thread
From: frowand.list @ 2017-04-30 20:45 UTC (permalink / raw)
To: Rob Herring, stephen.boyd; +Cc: devicetree, linux-kernel
From: Frank Rowand <frank.rowand@sony.com>
An undeclared variable was used in a macro that evaluates to nothing
when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct
variable that does exist.
---
reported by kbuild test robot on on robh/for-next
https://lkml.org/lkml/2017/4/29/134
drivers/of/base.c: In function '__of_add_phandle_sysfs':
>> drivers/of/base.c:198:23: error: 'pp' undeclared (first use in this function)
sysfs_bin_attr_init(&pp->attr);
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
drivers/of/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 9fe42346925b..8a7ca2a49ba8 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -195,7 +195,7 @@ int __of_add_phandle_sysfs(struct device_node *np)
if (!np->phandle || np->phandle == 0xffffffff)
return 0;
- sysfs_bin_attr_init(&pp->attr);
+ sysfs_bin_attr_init(&np->attr_phandle);
np->attr_phandle.attr.name = "phandle";
np->attr_phandle.attr.mode = 0444;
np->attr_phandle.size = sizeof(np->phandle);
--
Frank Rowand <frank.rowand@sony.com>
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC
@ 2017-04-30 20:45 ` frowand.list-Re5JQEeQqe8AvxtiuMwx3w
0 siblings, 0 replies; 9+ messages in thread
From: frowand.list-Re5JQEeQqe8AvxtiuMwx3w @ 2017-04-30 20:45 UTC (permalink / raw)
To: Rob Herring, stephen.boyd-QSEj5FYQhm4dnm+yROfE0A
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA
From: Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>
An undeclared variable was used in a macro that evaluates to nothing
when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct
variable that does exist.
---
reported by kbuild test robot on on robh/for-next
https://lkml.org/lkml/2017/4/29/134
drivers/of/base.c: In function '__of_add_phandle_sysfs':
>> drivers/of/base.c:198:23: error: 'pp' undeclared (first use in this function)
sysfs_bin_attr_init(&pp->attr);
Signed-off-by: Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>
---
drivers/of/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 9fe42346925b..8a7ca2a49ba8 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -195,7 +195,7 @@ int __of_add_phandle_sysfs(struct device_node *np)
if (!np->phandle || np->phandle == 0xffffffff)
return 0;
- sysfs_bin_attr_init(&pp->attr);
+ sysfs_bin_attr_init(&np->attr_phandle);
np->attr_phandle.attr.name = "phandle";
np->attr_phandle.attr.mode = 0444;
np->attr_phandle.size = sizeof(np->phandle);
--
Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-05-01 22:23 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-30 20:00 [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC Frank Rowand
2017-05-01 20:13 ` Rob Herring
2017-05-01 20:13 ` Rob Herring
2017-05-01 21:20 ` Rowand, Frank
2017-05-01 21:20 ` Rowand, Frank
2017-05-01 22:23 ` Frank Rowand
2017-05-01 22:23 ` Frank Rowand
2017-04-30 20:45 frowand.list
2017-04-30 20:45 ` frowand.list-Re5JQEeQqe8AvxtiuMwx3w
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.