Re: [PATCH v4 1/2] gro: code cleanup

From: "Hu, Jiayu" <jiayu.hu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Chen, Junjie J" <junjie.j.chen@intel.com>,
	"Tan, Jianfeng" <jianfeng.tan@intel.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"Yao, Lei A" <lei.a.yao@intel.com>
Subject: Re: [PATCH v4 1/2] gro: code cleanup
Date: Wed, 10 Jan 2018 01:55:16 +0000	[thread overview]
Message-ID: <ED946F0BEFE0A141B63BABBD629A2A9B3883DBFA@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <4091994.Mte9QLjkTW@xps>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, January 10, 2018 8:09 AM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Chen,
> Junjie J <junjie.j.chen@intel.com>; Tan, Jianfeng <jianfeng.tan@intel.com>;
> stephen@networkplumber.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Yao, Lei A
> <lei.a.yao@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 1/2] gro: code cleanup
> 
> Hi,
> 
> 05/01/2018 07:12, Jiayu Hu:
> > - Remove needless check and variants
> > - For better understanding, update the programmer guide and rename
> >   internal functions and variants
> > - For supporting tunneled gro, move common internal functions from
> >   gro_tcp4.c to gro_tcp4.h
> > - Comply RFC 6864 to process the IPv4 ID field
> 
> I think you could split this patch in several ones.
> Please remind that the git history can be used later to understand
> why the changes were done.

Thanks for your suggestion. I will split this patch into three patches: code cleanup,
comply RFC 6864 to process IPv4 ID field and extract common functions for supporting
tunneled GRO.

Regards,
Jiayu
> 
> Thanks