From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hu, Jiayu" Subject: Re: [PATCH] net/virtio-user: fix feature setting with vhost-net backend Date: Thu, 10 May 2018 08:33:33 +0000 Message-ID: References: <1525675806-22387-1-git-send-email-jiayu.hu@intel.com> <20180508024950.7rqyxjihdfilvovf@debian> <20180508074421.GA57422@dpdk15.sh.intel.com> <20180510050443.mzibwgqnp7ixwa3m@debian> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "dev@dpdk.org" , "Yang, Zhiyong" , "maxime.coquelin@redhat.com" To: "Bie, Tiwei" Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 8549B1B971 for ; Thu, 10 May 2018 10:34:08 +0200 (CEST) In-Reply-To: <20180510050443.mzibwgqnp7ixwa3m@debian> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" SGkgVGl3ZWksDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQmllLCBU aXdlaQ0KPiBTZW50OiBUaHVyc2RheSwgTWF5IDEwLCAyMDE4IDE6MDUgUE0NCj4gVG86IEh1LCBK aWF5dSA8amlheXUuaHVAaW50ZWwuY29tPg0KPiBDYzogZGV2QGRwZGsub3JnOyBZYW5nLCBaaGl5 b25nIDx6aGl5b25nLnlhbmdAaW50ZWwuY29tPjsNCj4gbWF4aW1lLmNvcXVlbGluQHJlZGhhdC5j b20NCj4gU3ViamVjdDogUmU6IFtkcGRrLWRldl0gW1BBVENIXSBuZXQvdmlydGlvLXVzZXI6IGZp eCBmZWF0dXJlIHNldHRpbmcgd2l0aA0KPiB2aG9zdC1uZXQgYmFja2VuZA0KPiANCj4gT24gVHVl LCBNYXkgMDgsIDIwMTggYXQgMDM6NDQ6MjJQTSArMDgwMCwgSmlheXUgSHUgd3JvdGU6DQo+ID4g SGkgVGl3ZWksDQo+ID4NCj4gPiBPbiBUdWUsIE1heSAwOCwgMjAxOCBhdCAxMDo0OTo1MEFNICsw ODAwLCBUaXdlaSBCaWUgd3JvdGU6DQo+ID4gPiBPbiBNb24sIE1heSAwNywgMjAxOCBhdCAwMjo1 MDowNlBNICswODAwLCBKaWF5dSBIdSB3cm90ZToNCj4gPiA+ID4gQ3VycmVudGx5LCB3aGVuIHRo ZSBiYWNrZW5kIGlzIHZob3N0LW5ldCwgd2hpY2ggaW1wbGllcw0KPiA+ID4gPiB2aXJ0aW8tdXNl ciB3b3JrcyBpbiBjbGllbnQgbW9kZSwgdmlydGlvLXVzZXIgaXMgYXNzaWduZWQNCj4gPiA+ID4g dG8gdGhlIGRlZmF1bHQgZmVhdHVyZSBWSVJUSU9fVVNFUl9TVVBQT1JURURfRkVBVFVSRVMuDQo+ ID4gPiA+IEhvd2V2ZXIsIHZpcnRpby11c2VyIHNob3VsZCByZXF1ZXN0IGZlYXR1cmVzIGZyb20g dGhlDQo+ID4gPiA+IGJhY2tlbmQgaW4gdGhpcyBjYXNlLg0KPiA+ID4gPg0KPiA+ID4gPiBGaXhl czogYmQ4ZjUwYTQ1ZDBmICgibmV0L3ZpcnRpby11c2VyOiBzdXBwb3J0IHNlcnZlciBtb2RlIikN Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogSmlheXUgSHUgPGppYXl1Lmh1QGludGVsLmNvbT4NCj4g PiA+ID4gLS0tDQo+ID4gPiA+ICBkcml2ZXJzL25ldC92aXJ0aW8vdmlydGlvX3VzZXIvdmlydGlv X3VzZXJfZGV2LmMgfCAxNSArKysrKysrLS0tLS0tLS0NCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2Vk LCA3IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pDQo+ID4gPiA+DQo+ID4gPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL25ldC92aXJ0aW8vdmlydGlvX3VzZXIvdmlydGlvX3VzZXJfZGV2LmMN Cj4gYi9kcml2ZXJzL25ldC92aXJ0aW8vdmlydGlvX3VzZXIvdmlydGlvX3VzZXJfZGV2LmMNCj4g PiA+ID4gaW5kZXggMzhiOGJjOS4uZjc0NTE2MyAxMDA2NDQNCj4gPiA+ID4gLS0tIGEvZHJpdmVy cy9uZXQvdmlydGlvL3ZpcnRpb191c2VyL3ZpcnRpb191c2VyX2Rldi5jDQo+ID4gPiA+ICsrKyBi L2RyaXZlcnMvbmV0L3ZpcnRpby92aXJ0aW9fdXNlci92aXJ0aW9fdXNlcl9kZXYuYw0KPiA+ID4g PiBAQCAtMzUzLDIwICszNTMsMjIgQEAgdmlydGlvX3VzZXJfZGV2X2luaXQoc3RydWN0IHZpcnRp b191c2VyX2Rldg0KPiAqZGV2LCBjaGFyICpwYXRoLCBpbnQgcXVldWVzLA0KPiA+ID4gPiAgCQly ZXR1cm4gLTE7DQo+ID4gPiA+ICAJfQ0KPiA+ID4gPg0KPiA+ID4gPiAtCWlmIChkZXYtPnZob3N0 ZmQgPj0gMCkgew0KPiA+ID4gPiArCWlmICghZGV2LT5pc19zZXJ2ZXIpIHsNCj4gPiA+DQo+ID4g PiBTZXJ2ZXIgbW9kZSBhbHNvIG5lZWRzIHRvIHJ1biBiZWxvdyBjb2RlIHdoZW4gdGhlDQo+ID4g PiBjb25uZWN0aW9uIHRvIHRoZSBiYWNrZW5kIGlzIGVzdGFibGlzaGVkLg0KPiA+DQo+ID4gRm9y IHNlcnZlciBtb2RlLCB0aGUgYmVsb3cgY29kZSBpcyBjYWxsZWQgYnkgdmlydGlvX3VzZXJfc3Rh cnRfZGV2aWNlKCksDQo+ID4gaW5zdGVhZCBvZiB2aXJ0aW9fdXNlcl9kZXZfaW5pdCgpLiBPbmx5 IGNsaWVudCBtb2RlIHZpcnRpby11c2VyDQo+ID4gbmVlZHMgdG8gY2FsbCBpdCB3aGVuIGluaXQu DQo+IA0KPiBPa2F5LiBTbyBpbiBzZXJ2ZXIgbW9kZSwgdmlydGlvLXVzZXIgbmV2ZXIgZ2V0IGEg Y2hhbmNlDQo+IHRvIGRvIEdFVF9GRUFUVVJFUy4NCg0KSW4gY3VycmVudCBkZXNpZ24sIHZpcnRp by11c2VyIHNlcnZlciBtb2RlIGFsd2F5cyBoYXMgbm8gd2F5IHRvIGRvIEdFVF9GRUFUVVJFUy4N CkkgdGhpbmsgaXQncyB0aGUgZGVzaWduIHByb2JsZW0gb2YgdmlydGlvLXVzZXIgc2VydmVyIG1v ZGUuIFRoaXMgcGF0Y2ggaXMganVzdCBmb3Igc29sdmluZw0KY2xpZW50IG1vZGUgdmlydGlvLXVz ZXIgZmVhdHVyZSBzZXR0aW5nLg0KDQo+IA0KPiA+DQo+ID4gPg0KPiA+ID4gPiAgCQlpZiAoZGV2 LT5vcHMtPnNlbmRfcmVxdWVzdChkZXYsDQo+IFZIT1NUX1VTRVJfU0VUX09XTkVSLA0KPiA+ID4g PiAtCQkJCQkgICBOVUxMKSA8IDApIHsNCj4gPiA+ID4gKwkJCQkJTlVMTCkgPCAwKSB7DQo+ID4g Pg0KPiA+ID4gVGhlcmUgaXMgbm8gbmVlZCB0byBjaGFuZ2UgdGhlIGluZGVudC4NCj4gPg0KPiA+ IFRoYW5rcywgY2hhbmdlIGluIHRoZSBuZXh0IHBhdGNoLg0KPiA+DQo+ID4gPg0KPiA+ID4gPiAg CQkJUE1EX0lOSVRfTE9HKEVSUiwgInNldF9vd25lciBmYWlsczogJXMiLA0KPiA+ID4gPiAtCQkJ CSAgICAgc3RyZXJyb3IoZXJybm8pKTsNCj4gPiA+ID4gKwkJCQkJc3RyZXJyb3IoZXJybm8pKTsN Cj4gPiA+DQo+ID4gPiBUaGVyZSBpcyBubyBuZWVkIHRvIGNoYW5nZSB0aGUgaW5kZW50Lg0KPiA+ DQo+ID4gZGl0dG8uDQo+ID4NCj4gPiA+DQo+ID4gPiA+ICAJCQlyZXR1cm4gLTE7DQo+ID4gPiA+ ICAJCX0NCj4gPiA+ID4NCj4gPiA+ID4gIAkJaWYgKGRldi0+b3BzLT5zZW5kX3JlcXVlc3QoZGV2 LA0KPiBWSE9TVF9VU0VSX0dFVF9GRUFUVVJFUywNCj4gPiA+ID4gLQkJCQkJICAgJmRldi0+ZGV2 aWNlX2ZlYXR1cmVzKSA8IDApIHsNCj4gPiA+ID4gKwkJCQkJJmRldi0+ZGV2aWNlX2ZlYXR1cmVz KSA8IDApIHsNCj4gPiA+DQo+ID4gPiBUaGVyZSBpcyBubyBuZWVkIHRvIGNoYW5nZSB0aGUgaW5k ZW50Lg0KPiA+DQo+ID4gZGl0dG8uDQo+ID4NCj4gPiA+DQo+ID4gPiA+ICAJCQlQTURfSU5JVF9M T0coRVJSLCAiZ2V0X2ZlYXR1cmVzIGZhaWxlZDogJXMiLA0KPiA+ID4gPiAtCQkJCSAgICAgc3Ry ZXJyb3IoZXJybm8pKTsNCj4gPiA+ID4gKwkJCQkJc3RyZXJyb3IoZXJybm8pKTsNCj4gPiA+DQo+ ID4gPiBUaGVyZSBpcyBubyBuZWVkIHRvIGNoYW5nZSB0aGUgaW5kZW50Lg0KPiA+DQo+ID4gZGl0 dG8uDQo+ID4NCj4gPiA+DQo+ID4gPiA+ICAJCQlyZXR1cm4gLTE7DQo+ID4gPiA+ICAJCX0NCj4g PiA+ID4gKwkJaWYgKGRldi0+bWFjX3NwZWNpZmllZCkNCj4gPiA+ID4gKwkJCWRldi0+ZGV2aWNl X2ZlYXR1cmVzIHw9ICgxdWxsIDw8DQo+IFZJUlRJT19ORVRfRl9NQUMpOw0KPiA+ID4NCj4gPiA+ IFdoeSBtb3ZlIGFib3ZlIGNvZGU/DQo+ID4NCj4gPiBUaGUgc2VydmVyIG1vZGUgdmlydGlvLXVz ZXIgaXMgYXNzaWduZWQgdGhlIGRlZmF1bHQgZmVhdHVyZXMsIHdoaWNoIGluY2x1ZGUNCj4gPiBW SVJUSU9fTkVUX0ZfTUFDLiBTbyBjaGVja2luZyBpZiBzdXBwb3J0IFZJUlRJT19ORVRfRl9NQUMg aXMgb25seQ0KPiBuZWNlc3NhcnkNCj4gPiBmb3IgY2xpZW50IG1vZGUuDQo+IA0KPiBJIHRoaW5r IHdlIHNob3VsZCBzZXQgdGhpcyBiaXQgb25seSB3aGVuIG1hYyBpcw0KPiBzcGVjaWZpZWQuIEFu ZCBpbiBzZXJ2ZXIgbW9kZSwgd2UgbmVlZCB0byBjbGVhcg0KPiB0aGlzIGJpdCB3aGVuIG1hYyBp c24ndCBzcGVjaWZpZWQuIFNvIGluc3RlYWQNCj4gb2YgbW92aW5nIGl0LCBpdCBzaG91bGQgYmUg Y2hhbmdlZCB0byBzb21ldGhpbmcNCj4gbGlrZSB0aGlzOg0KPiANCj4gCWlmIChkZXYtPm1hY19z cGVjaWZpZWQpDQo+IAkJZGV2LT5kZXZpY2VfZmVhdHVyZXMgfD0gKDF1bGwgPDwgVklSVElPX05F VF9GX01BQyk7DQo+IAllbHNlDQo+IAkJZGV2LT5kZXZpY2VfZmVhdHVyZXMgJj0gfigxdWxsIDw8 IFZJUlRJT19ORVRfRl9NQUMpOw0KPiANCg0KTWFrZSBzZW5zZS4gSXQgc2hvdWxkbid0IGNoYW5n ZSBpbiB0aGlzIHBhdGNoLiBJIHdpbGwgY2hhbmdlIGl0LiBUaGFua3MuDQoNCkppYXl1DQo+IFRo YW5rcw0KPiANCj4gPg0KPiA+IFRoYW5rcywNCj4gPiBKaWF5dQ0KPiA+DQo+ID4gPg0KPiA+ID4g PiAgCX0gZWxzZSB7DQo+ID4gPiA+ICAJCS8qIFdlIGp1c3QgcHJldGVuZCB2aG9zdC11c2VyIGNh biBzdXBwb3J0IGFsbCB0aGVzZQ0KPiBmZWF0dXJlcy4NCj4gPiA+ID4gIAkJICogTm90ZSB0aGF0 IHRoaXMgY291bGQgYmUgcHJvYmxlbWF0aWMgdGhhdCBpZiBzb21lIGZlYXR1cmUNCj4gaXMNCj4g PiA+ID4gQEAgLTM3Niw5ICszNzgsNiBAQCB2aXJ0aW9fdXNlcl9kZXZfaW5pdChzdHJ1Y3Qgdmly dGlvX3VzZXJfZGV2DQo+ICpkZXYsIGNoYXIgKnBhdGgsIGludCBxdWV1ZXMsDQo+ID4gPiA+ICAJ CWRldi0+ZGV2aWNlX2ZlYXR1cmVzID0NCj4gVklSVElPX1VTRVJfU1VQUE9SVEVEX0ZFQVRVUkVT Ow0KPiA+ID4gPiAgCX0NCj4gPiA+ID4NCj4gPiA+ID4gLQlpZiAoZGV2LT5tYWNfc3BlY2lmaWVk KQ0KPiA+ID4gPiAtCQlkZXYtPmRldmljZV9mZWF0dXJlcyB8PSAoMXVsbCA8PCBWSVJUSU9fTkVU X0ZfTUFDKTsNCj4gPiA+ID4gLQ0KPiA+ID4gPiAgCWlmIChjcSkgew0KPiA+ID4gPiAgCQkvKiBk ZXZpY2UgZG9lcyBub3QgcmVhbGx5IG5lZWQgdG8ga25vdyBhbnl0aGluZyBhYm91dCBDUSwNCj4g PiA+ID4gIAkJICogc28gaWYgbmVjZXNzYXJ5LCB3ZSBqdXN0IGNsYWltIHRvIHN1cHBvcnQgQ1EN Cj4gPiA+ID4gLS0NCj4gPiA+ID4gMi43LjQNCj4gPiA+ID4NCg==