From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hu, Jiayu" Subject: Re: [PATCH 2/3] app/testpmd: enable UDP GSO in the checksum forwarding engine Date: Sat, 16 Jun 2018 09:14:54 +0000 Message-ID: References: <1527579670-91026-1-git-send-email-jiayu.hu@intel.com> <1527579670-91026-3-git-send-email-jiayu.hu@intel.com> <8CEF83825BEC744B83065625E567D7C260CB37DB@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Ananyev, Konstantin" To: "Iremonger, Bernard" , "dev@dpdk.org" Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 08C5C1B8C3 for ; Sat, 16 Jun 2018 11:14:59 +0200 (CEST) In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB37DB@IRSMSX108.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bernard, > -----Original Message----- > From: Iremonger, Bernard > Sent: Thursday, June 14, 2018 10:44 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Hu, Jiayu > > Subject: RE: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the > checksum forwarding engine >=20 > Hi Jiayu, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiayu Hu > > Sent: Tuesday, May 29, 2018 8:41 AM > > To: dev@dpdk.org > > Cc: Ananyev, Konstantin ; Hu, Jiayu > > > > Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the > > checksum forwarding engine > > > > This patch enables GSO for UDP/IPv4 packets. Oversized UDP/IPv4 > packets > > transmitted over a GSO-enabled port will undergo segmentation. > > > > Signed-off-by: Jiayu Hu > > --- > > app/test-pmd/cmdline.c | 5 +++-- > > app/test-pmd/csumonly.c | 2 ++ > > app/test-pmd/testpmd.c | 2 +- > > 3 files changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 27e2aa8..4239e91 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -4792,8 +4792,9 @@ cmd_gso_show_parsed(void *parsed_result, > > if (gso_ports[res->cmd_pid].enable) { > > printf("Max GSO'd packet size: %uB\n" > > "Supported GSO types: TCP/IPv4, " > > - "VxLAN with inner TCP/IPv4 packet, > " > > - "GRE with inner TCP/IPv4 > packet\n", > > + "UDP/IPv4, VxLAN with inner " > > + "TCP/IPv4 packet, GRE with inner " > > + "TCP/IPv4 packet\n", >=20 > This change is giving 3 checkpatch.pl warnings and should be refactored The file test-pmd/cmdline.c uses the above coding style to split long strin= gs, so I think I need to keep this style. But when I use it, there are always s= ome warnings. >=20 >=20 > > gso_max_segment_size); > > } else > > printf("GSO is not enabled on Port %u\n", res- > > >cmd_pid); diff --git a/app/test-pmd/csumonly.c b/app/test- > > pmd/csumonly.c index 0bb88cf..4948292 100644 > > --- a/app/test-pmd/csumonly.c > > +++ b/app/test-pmd/csumonly.c > > @@ -411,6 +411,8 @@ process_inner_cksums(void *l3_hdr, const struct > > testpmd_offload_info *info, > > info->ethertype); > > } > > } > > + if (info->gso_enable) > > + ol_flags |=3D PKT_TX_UDP_SEG; > > } else if (info->l4_proto =3D=3D IPPROTO_TCP) { > > tcp_hdr =3D (struct tcp_hdr *)((char *)l3_hdr + info->l3_len); > > tcp_hdr->cksum =3D 0; > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > 35cf266..b5766ff 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -777,7 +777,7 @@ init_config(void) > > init_port_config(); > > > > gso_types =3D DEV_TX_OFFLOAD_TCP_TSO | > > DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > > - DEV_TX_OFFLOAD_GRE_TNL_TSO; > > + DEV_TX_OFFLOAD_GRE_TNL_TSO | > > DEV_TX_OFFLOAD_UDP_TSO; > > /* > > * Records which Mbuf pool to use by each logical core, if needed. > > */ > > -- > > 2.7.4 >=20 > ./devtools/check-git-log.sh -1 > Headline too long: > app/testpmd: enable UDP GSO in the checksum forwarding engine Will change it in the next version. >=20 > Should the dpdk/doc/guides/testpmd_ap_ug/testpmd_funcs.rst file be > updated? I will add some descriptions about UDP/IPv4 GSO usage guide in it. Thanks, Jiayu >=20 > Regards, >=20 > Bernard >=20