From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hu, Jiayu" Subject: Re: [PATCH v2 2/2] mbuf: fix Tx offload mask Date: Thu, 4 Oct 2018 02:31:11 +0000 Message-ID: References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002105142.24333-1-jerin.jacob@caviumnetworks.com> <20181002105142.24333-2-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stable@dpdk.org" To: Jerin Jacob , Olivier Matz Return-path: In-Reply-To: <20181002105142.24333-2-jerin.jacob@caviumnetworks.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, October 2, 2018 6:52 PM > To: Olivier Matz > Cc: dev@dpdk.org; Jerin Jacob ; > stable@dpdk.org; Hu, Jiayu > Subject: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask >=20 > Fixes missing PKT_TX_UDP_SEG, > PKT_TX_OUTER_IPV6,PKT_TX_OUTER_IPV4, > PKT_TX_IPV6 and PKT_TX_IPV4 values in PKT_TX_OFFLOAD_MASK. >=20 > Also sort them in bit wise order to recognize missing items later. >=20 > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels") > Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with R= x > ones") > Cc: stable@dpdk.org > Cc: jiayu.hu@intel.com >=20 > Signed-off-by: Jerin Jacob Acked-by: Jiayu Hu Thanks, Jiayu > --- > v2: > - Add all missing PKT_TX_ types > - Sort them in bit mask order(Ferruh Yigit) > --- > lib/librte_mbuf/rte_mbuf.h | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index a50b05c64..c8ebc3230 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -334,16 +334,21 @@ extern "C" { > * which can be set for packet. > */ > #define PKT_TX_OFFLOAD_MASK ( \ > + PKT_TX_OUTER_IPV6 | \ > + PKT_TX_OUTER_IPV4 | \ > + PKT_TX_OUTER_IP_CKSUM | \ > + PKT_TX_VLAN_PKT | \ > + PKT_TX_IPV6 | \ > + PKT_TX_IPV4 | \ > PKT_TX_IP_CKSUM | \ > PKT_TX_L4_MASK | \ > - PKT_TX_OUTER_IP_CKSUM | \ > - PKT_TX_TCP_SEG | \ > PKT_TX_IEEE1588_TMST | \ > + PKT_TX_TCP_SEG | \ > PKT_TX_QINQ_PKT | \ > - PKT_TX_VLAN_PKT | \ > PKT_TX_TUNNEL_MASK | \ > PKT_TX_MACSEC | \ > - PKT_TX_SEC_OFFLOAD) > + PKT_TX_SEC_OFFLOAD | \ > + PKT_TX_UDP_SEG) >=20 > /** > * Mbuf having an external buffer attached. shinfo in mbuf must be fille= d. > -- > 2.19.0