From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hu, Jiayu" <jiayu.hu@intel.com>
Subject: Re: [PATCH] gso: fix VxLAN/GRE tunnel checks
Date: Sat, 19 Jan 2019 13:31:12 +0000
Message-ID: <ED946F0BEFE0A141B63BABBD629A2A9B3CF47556@shsmsx102.ccr.corp.intel.com>
References: <1547818111-21817-1-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1547818111-21817-1-git-send-email-arybchenko@solarflare.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Andrew,

Would you please give more explanation about the problem that
the patch wants to fix?

Thanks,
Jiayu
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Friday, January 18, 2019 9:29 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] gso: fix VxLAN/GRE tunnel checks
>=20
> Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
>=20
> Fixes: b058d92ea95d ("gso: support VxLAN GSO")
> Fixes: 70e737e448c7 ("gso: support GRE GSO")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  lib/librte_gso/gso_common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
> index 6cd764ff5..b6ff1b886 100644
> --- a/lib/librte_gso/gso_common.h
> +++ b/lib/librte_gso/gso_common.h
> @@ -22,12 +22,12 @@
>  		(PKT_TX_TCP_SEG | PKT_TX_IPV4))
>=20
>  #define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> -				PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_VXLAN)) =3D=3D \
> +				PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) =3D=3D \
>  		(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
>  		 PKT_TX_TUNNEL_VXLAN))
>=20
>  #define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> -				PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_GRE)) =3D=3D \
> +				PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) =3D=3D \
>  		(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
>  		 PKT_TX_TUNNEL_GRE))
>=20
> --
> 2.17.1