From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Huddleston Subject: Re: [PATCH] Don't build Intel DRM if $CHOST is not i?86-* or x86_64-* Date: Tue, 31 Jan 2012 10:34:38 -0800 Message-ID: References: <87boqgu5zf.fsf@eliezer.anholt.net> <87ehuj5l2n.fsf@eliezer.anholt.net> <5A68BEB0-7C83-4215-8A10-B5014060C764@freedesktop.org> <87fwex9mwp.fsf@eliezer.anholt.net> <8739avu7tz.fsf@eliezer.anholt.net> Mime-Version: 1.0 (Apple Message framework v1256.1) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cid.outersquare.org (cid.outersquare.org [75.144.255.89]) by gabe.freedesktop.org (Postfix) with ESMTP id 62D949EB1F for ; Tue, 31 Jan 2012 10:34:41 -0800 (PST) In-Reply-To: <8739avu7tz.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Jan 31, 2012, at 8:59 AM, Eric Anholt wrote: > On Mon, 30 Jan 2012 15:25:20 -0800, Jeremy Huddleston wrote: >> This fixes a failure in 'make check' found by the tinderbox when trying to >> build this code on Linux/ppc. This code is only designed to run on >> Intel platforms, so don't even bother building it if we're not in that set. > > Looks reasonable to me, except it should probably be checking $target_os > (cross-compile target) rather than $host_os (cross compile build host). I think you are misunderstanding the variables (or perhaps you are following Mozilla's usage of the variables, which is wrong but internally consistent). CBUILD - The platform of the machine being built on. CHOST - The platform that the delivered product will run on. CTARGET- The platform that the delivered product will generate code for. CTARGET is only really relevant for toolchain packages. eg. I want to build a gcc that builds mips code and runs on my intel box: CTARGET=mips-* CHOST=i686-* If I want to do the building of that compiler on my ppc box: CBUILD=powerpc-* CTARGET=mips-* CHOST=i686-* --Jeremy