From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriele Paoloni Subject: RE: [PATCH V2 22/23] pci, acpi: Match PCI config space accessors against platfrom specific quirks. Date: Tue, 22 Dec 2015 09:29:02 +0000 Message-ID: References: <1450278993-12664-1-git-send-email-tn@semihalf.com> <1450278993-12664-23-git-send-email-tn@semihalf.com> <201512211510.32029.arnd@arndb.de> <335CDE2E-B588-43A8-8665-6023AFD0EA04@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <335CDE2E-B588-43A8-8665-6023AFD0EA04@redhat.com> Content-Language: en-US Sender: linux-pci-owner@vger.kernel.org To: Jon Masters , Arnd Bergmann Cc: Tomasz Nowicki , "bhelgaas@google.com" , "will.deacon@arm.com" , "catalin.marinas@arm.com" , "rjw@rjwysocki.net" , "hanjun.guo@linaro.org" , "Lorenzo.Pieralisi@arm.com" , "okaya@codeaurora.org" , "jiang.liu@linux.intel.com" , "Stefano.Stabellini@eu.citrix.com" , "robert.richter@caviumnetworks.com" , "mw@semihalf.com" , "Liviu.Dudau@arm.com" , "ddaney@caviumnetworks.com" , "tglx@linutronix.de" , Wangyijing , "Suravee.Suthikulpanit@amd.com" List-Id: linux-acpi@vger.kernel.org Hi Jon, thanks for replying > -----Original Message----- > From: Jon Masters [mailto:jcm@redhat.com] > Sent: 21 December 2015 23:11 > To: Arnd Bergmann > Cc: Gabriele Paoloni; Tomasz Nowicki; bhelgaas@google.com; > will.deacon@arm.com; catalin.marinas@arm.com; rjw@rjwysocki.net; > hanjun.guo@linaro.org; Lorenzo.Pieralisi@arm.com; okaya@codeaurora.org; > jiang.liu@linux.intel.com; Stefano.Stabellini@eu.citrix.com; > robert.richter@caviumnetworks.com; mw@semihalf.com; Liviu.Dudau@arm.com; > ddaney@caviumnetworks.com; tglx@linutronix.de; Wangyijing; > Suravee.Suthikulpanit@amd.com; msalter@redhat.com; linux- > pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linaro- > acpi@lists.linaro.org; jchandra@broadcom.com > Subject: Re: [PATCH V2 22/23] pci, acpi: Match PCI config space > accessors against platfrom specific quirks. > > Sorry for top-posting. A quick note that SMBIOS3 is required by SBBR so > it can be presumed that compliant platforms will provide quirks via DMI. Ok so you completely clarified my question 1). Many Thanks for this Gab > > -- > Computer Architect | Sent from my 64-bit #ARM Powered phone > > > On Dec 21, 2015, at 09:11, Arnd Bergmann wrote: > > > > On Monday 21 December 2015, Gabriele Paoloni wrote: > >>> -----Original Message----- > >>> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > >>> owner@vger.kernel.org] On Behalf Of Tomasz Nowicki > > > >>> Some platforms may not be fully compliant with generic set of PCI > >>> config accessors. For these cases we implement the way to overwrite > >>> accessors set before PCI buses enumeration. Algorithm that > overwrite > >>> accessors matches against platform ID (DMI), domain and bus number, > >>> hopefully enough for all cases. All quirks can be defined using: > >>> DECLARE_ACPI_MCFG_FIXUP() and keep self contained. > >> > >> I've got a couple of comments/questions about this patch.. > >> > >> 1) So according to this mechanism quirks would be supported only by > >> vendors whose BIOS are SMBIOS compliant. Now personally I am ok > >> with this but I don't know if this is OK in general as it would > >> narrow down the number of platforms that would be able to define > >> the quirks... > >> Lorenzo, Arnd what is your opinion here? > > > > I'd rather not see the quirks in mainline at all, and only support > > SBSA compliant machines, or require the BIOS to work around the > > hardware quirks differently (e.g. by trapping config space access > > through secure firmware, or going through an AML method to be > > defined). I'm certainly ok with making it depend on SMBIOS if we are > going to use something like this. > > > > Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754384AbbLVJ36 (ORCPT ); Tue, 22 Dec 2015 04:29:58 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:4339 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754362AbbLVJ3y convert rfc822-to-8bit (ORCPT ); Tue, 22 Dec 2015 04:29:54 -0500 From: Gabriele Paoloni To: Jon Masters , Arnd Bergmann CC: Tomasz Nowicki , "bhelgaas@google.com" , "will.deacon@arm.com" , "catalin.marinas@arm.com" , "rjw@rjwysocki.net" , "hanjun.guo@linaro.org" , "Lorenzo.Pieralisi@arm.com" , "okaya@codeaurora.org" , "jiang.liu@linux.intel.com" , "Stefano.Stabellini@eu.citrix.com" , "robert.richter@caviumnetworks.com" , "mw@semihalf.com" , "Liviu.Dudau@arm.com" , "ddaney@caviumnetworks.com" , "tglx@linutronix.de" , Wangyijing , "Suravee.Suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , "jchandra@broadcom.com" Subject: RE: [PATCH V2 22/23] pci, acpi: Match PCI config space accessors against platfrom specific quirks. Thread-Topic: [PATCH V2 22/23] pci, acpi: Match PCI config space accessors against platfrom specific quirks. Thread-Index: AQHROBUgIukhjYkQJEW918qA+7ssUp7VRxqQgAA7b4CAAJcAAIAAqv+Q Date: Tue, 22 Dec 2015 09:29:02 +0000 Message-ID: References: <1450278993-12664-1-git-send-email-tn@semihalf.com> <1450278993-12664-23-git-send-email-tn@semihalf.com> <201512211510.32029.arnd@arndb.de> <335CDE2E-B588-43A8-8665-6023AFD0EA04@redhat.com> In-Reply-To: <335CDE2E-B588-43A8-8665-6023AFD0EA04@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.210.142.221] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.567917ED.00B8,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 5e4f2426466c2a86740e8e0aae610cfa Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jon, thanks for replying > -----Original Message----- > From: Jon Masters [mailto:jcm@redhat.com] > Sent: 21 December 2015 23:11 > To: Arnd Bergmann > Cc: Gabriele Paoloni; Tomasz Nowicki; bhelgaas@google.com; > will.deacon@arm.com; catalin.marinas@arm.com; rjw@rjwysocki.net; > hanjun.guo@linaro.org; Lorenzo.Pieralisi@arm.com; okaya@codeaurora.org; > jiang.liu@linux.intel.com; Stefano.Stabellini@eu.citrix.com; > robert.richter@caviumnetworks.com; mw@semihalf.com; Liviu.Dudau@arm.com; > ddaney@caviumnetworks.com; tglx@linutronix.de; Wangyijing; > Suravee.Suthikulpanit@amd.com; msalter@redhat.com; linux- > pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linaro- > acpi@lists.linaro.org; jchandra@broadcom.com > Subject: Re: [PATCH V2 22/23] pci, acpi: Match PCI config space > accessors against platfrom specific quirks. > > Sorry for top-posting. A quick note that SMBIOS3 is required by SBBR so > it can be presumed that compliant platforms will provide quirks via DMI. Ok so you completely clarified my question 1). Many Thanks for this Gab > > -- > Computer Architect | Sent from my 64-bit #ARM Powered phone > > > On Dec 21, 2015, at 09:11, Arnd Bergmann wrote: > > > > On Monday 21 December 2015, Gabriele Paoloni wrote: > >>> -----Original Message----- > >>> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > >>> owner@vger.kernel.org] On Behalf Of Tomasz Nowicki > > > >>> Some platforms may not be fully compliant with generic set of PCI > >>> config accessors. For these cases we implement the way to overwrite > >>> accessors set before PCI buses enumeration. Algorithm that > overwrite > >>> accessors matches against platform ID (DMI), domain and bus number, > >>> hopefully enough for all cases. All quirks can be defined using: > >>> DECLARE_ACPI_MCFG_FIXUP() and keep self contained. > >> > >> I've got a couple of comments/questions about this patch.. > >> > >> 1) So according to this mechanism quirks would be supported only by > >> vendors whose BIOS are SMBIOS compliant. Now personally I am ok > >> with this but I don't know if this is OK in general as it would > >> narrow down the number of platforms that would be able to define > >> the quirks... > >> Lorenzo, Arnd what is your opinion here? > > > > I'd rather not see the quirks in mainline at all, and only support > > SBSA compliant machines, or require the BIOS to work around the > > hardware quirks differently (e.g. by trapping config space access > > through secure firmware, or going through an AML method to be > > defined). I'm certainly ok with making it depend on SMBIOS if we are > going to use something like this. > > > > Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Gabriele Paoloni To: Jon Masters , Arnd Bergmann CC: Tomasz Nowicki , "bhelgaas@google.com" , "will.deacon@arm.com" , "catalin.marinas@arm.com" , "rjw@rjwysocki.net" , "hanjun.guo@linaro.org" , "Lorenzo.Pieralisi@arm.com" , "okaya@codeaurora.org" , "jiang.liu@linux.intel.com" , "Stefano.Stabellini@eu.citrix.com" , "robert.richter@caviumnetworks.com" , "mw@semihalf.com" , "Liviu.Dudau@arm.com" , "ddaney@caviumnetworks.com" , "tglx@linutronix.de" , Wangyijing , "Suravee.Suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , "jchandra@broadcom.com" Subject: RE: [PATCH V2 22/23] pci, acpi: Match PCI config space accessors against platfrom specific quirks. Date: Tue, 22 Dec 2015 09:29:02 +0000 Message-ID: References: <1450278993-12664-1-git-send-email-tn@semihalf.com> <1450278993-12664-23-git-send-email-tn@semihalf.com> <201512211510.32029.arnd@arndb.de> <335CDE2E-B588-43A8-8665-6023AFD0EA04@redhat.com> In-Reply-To: <335CDE2E-B588-43A8-8665-6023AFD0EA04@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org List-ID: Hi Jon, thanks for replying > -----Original Message----- > From: Jon Masters [mailto:jcm@redhat.com] > Sent: 21 December 2015 23:11 > To: Arnd Bergmann > Cc: Gabriele Paoloni; Tomasz Nowicki; bhelgaas@google.com; > will.deacon@arm.com; catalin.marinas@arm.com; rjw@rjwysocki.net; > hanjun.guo@linaro.org; Lorenzo.Pieralisi@arm.com; okaya@codeaurora.org; > jiang.liu@linux.intel.com; Stefano.Stabellini@eu.citrix.com; > robert.richter@caviumnetworks.com; mw@semihalf.com; Liviu.Dudau@arm.com; > ddaney@caviumnetworks.com; tglx@linutronix.de; Wangyijing; > Suravee.Suthikulpanit@amd.com; msalter@redhat.com; linux- > pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linaro- > acpi@lists.linaro.org; jchandra@broadcom.com > Subject: Re: [PATCH V2 22/23] pci, acpi: Match PCI config space > accessors against platfrom specific quirks. > > Sorry for top-posting. A quick note that SMBIOS3 is required by SBBR so > it can be presumed that compliant platforms will provide quirks via DMI. Ok so you completely clarified my question 1). Many Thanks for this Gab > > -- > Computer Architect | Sent from my 64-bit #ARM Powered phone > > > On Dec 21, 2015, at 09:11, Arnd Bergmann wrote: > > > > On Monday 21 December 2015, Gabriele Paoloni wrote: > >>> -----Original Message----- > >>> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > >>> owner@vger.kernel.org] On Behalf Of Tomasz Nowicki > > > >>> Some platforms may not be fully compliant with generic set of PCI > >>> config accessors. For these cases we implement the way to overwrite > >>> accessors set before PCI buses enumeration. Algorithm that > overwrite > >>> accessors matches against platform ID (DMI), domain and bus number, > >>> hopefully enough for all cases. All quirks can be defined using: > >>> DECLARE_ACPI_MCFG_FIXUP() and keep self contained. > >> > >> I've got a couple of comments/questions about this patch.. > >> > >> 1) So according to this mechanism quirks would be supported only by > >> vendors whose BIOS are SMBIOS compliant. Now personally I am ok > >> with this but I don't know if this is OK in general as it would > >> narrow down the number of platforms that would be able to define > >> the quirks... > >> Lorenzo, Arnd what is your opinion here? > > > > I'd rather not see the quirks in mainline at all, and only support > > SBSA compliant machines, or require the BIOS to work around the > > hardware quirks differently (e.g. by trapping config space access > > through secure firmware, or going through an AML method to be > > defined). I'm certainly ok with making it depend on SMBIOS if we are > going to use something like this. > > > > Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: gabriele.paoloni@huawei.com (Gabriele Paoloni) Date: Tue, 22 Dec 2015 09:29:02 +0000 Subject: [PATCH V2 22/23] pci, acpi: Match PCI config space accessors against platfrom specific quirks. In-Reply-To: <335CDE2E-B588-43A8-8665-6023AFD0EA04@redhat.com> References: <1450278993-12664-1-git-send-email-tn@semihalf.com> <1450278993-12664-23-git-send-email-tn@semihalf.com> <201512211510.32029.arnd@arndb.de> <335CDE2E-B588-43A8-8665-6023AFD0EA04@redhat.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jon, thanks for replying > -----Original Message----- > From: Jon Masters [mailto:jcm at redhat.com] > Sent: 21 December 2015 23:11 > To: Arnd Bergmann > Cc: Gabriele Paoloni; Tomasz Nowicki; bhelgaas at google.com; > will.deacon at arm.com; catalin.marinas at arm.com; rjw at rjwysocki.net; > hanjun.guo at linaro.org; Lorenzo.Pieralisi at arm.com; okaya at codeaurora.org; > jiang.liu at linux.intel.com; Stefano.Stabellini at eu.citrix.com; > robert.richter at caviumnetworks.com; mw at semihalf.com; Liviu.Dudau at arm.com; > ddaney at caviumnetworks.com; tglx at linutronix.de; Wangyijing; > Suravee.Suthikulpanit at amd.com; msalter at redhat.com; linux- > pci at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- > acpi at vger.kernel.org; linux-kernel at vger.kernel.org; linaro- > acpi at lists.linaro.org; jchandra at broadcom.com > Subject: Re: [PATCH V2 22/23] pci, acpi: Match PCI config space > accessors against platfrom specific quirks. > > Sorry for top-posting. A quick note that SMBIOS3 is required by SBBR so > it can be presumed that compliant platforms will provide quirks via DMI. Ok so you completely clarified my question 1). Many Thanks for this Gab > > -- > Computer Architect | Sent from my 64-bit #ARM Powered phone > > > On Dec 21, 2015, at 09:11, Arnd Bergmann wrote: > > > > On Monday 21 December 2015, Gabriele Paoloni wrote: > >>> -----Original Message----- > >>> From: linux-kernel-owner at vger.kernel.org [mailto:linux-kernel- > >>> owner at vger.kernel.org] On Behalf Of Tomasz Nowicki > > > >>> Some platforms may not be fully compliant with generic set of PCI > >>> config accessors. For these cases we implement the way to overwrite > >>> accessors set before PCI buses enumeration. Algorithm that > overwrite > >>> accessors matches against platform ID (DMI), domain and bus number, > >>> hopefully enough for all cases. All quirks can be defined using: > >>> DECLARE_ACPI_MCFG_FIXUP() and keep self contained. > >> > >> I've got a couple of comments/questions about this patch.. > >> > >> 1) So according to this mechanism quirks would be supported only by > >> vendors whose BIOS are SMBIOS compliant. Now personally I am ok > >> with this but I don't know if this is OK in general as it would > >> narrow down the number of platforms that would be able to define > >> the quirks... > >> Lorenzo, Arnd what is your opinion here? > > > > I'd rather not see the quirks in mainline at all, and only support > > SBSA compliant machines, or require the BIOS to work around the > > hardware quirks differently (e.g. by trapping config space access > > through secure firmware, or going through an AML method to be > > defined). I'm certainly ok with making it depend on SMBIOS if we are > going to use something like this. > > > > Arnd