From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriele Paoloni Subject: RE: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks Date: Mon, 13 Jun 2016 14:29:01 +0000 Message-ID: References: <1465822923-33599-1-git-send-email-liudongdong3@huawei.com> <1465822923-33599-2-git-send-email-liudongdong3@huawei.com> <575EBD13.8080808@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <575EBD13.8080808@codeaurora.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Sinan Kaya , "liudongdong (C)" , "helgaas@kernel.org" , "arnd@arndb.de" , "will.deacon@arm.com" , "catalin.marinas@arm.com" , "rafael@kernel.org" , "hanjun.guo@linaro.org" , "Lorenzo.Pieralisi@arm.com" , "jchandra@broadcom.com" , "tn@semihalf.com" Cc: "robert.richter@caviumnetworks.com" , "mw@semihalf.com" , "Liviu.Dudau@arm.com" , "ddaney@caviumnetworks.com" , Wangyijing , "Suravee.Suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , "jcm@redhat.com" , "andrea.gallo@linaro.org" , "dhdang@apm.com" , "jeremy.linton@arm.com" , "cov@codeaurora.org" List-Id: linux-acpi@vger.kernel.org SGkgU2luYW4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTaW5hbiBL YXlhIFttYWlsdG86b2theWFAY29kZWF1cm9yYS5vcmddDQo+IFNlbnQ6IDEzIEp1bmUgMjAxNiAx NTowMw0KPiBUbzogR2FicmllbGUgUGFvbG9uaTsgbGl1ZG9uZ2RvbmcgKEMpOyBoZWxnYWFzQGtl cm5lbC5vcmc7DQo+IGFybmRAYXJuZGIuZGU7IHdpbGwuZGVhY29uQGFybS5jb207IGNhdGFsaW4u bWFyaW5hc0Bhcm0uY29tOw0KPiByYWZhZWxAa2VybmVsLm9yZzsgaGFuanVuLmd1b0BsaW5hcm8u b3JnOyBMb3JlbnpvLlBpZXJhbGlzaUBhcm0uY29tOw0KPiBqY2hhbmRyYUBicm9hZGNvbS5jb207 IHRuQHNlbWloYWxmLmNvbQ0KPiBDYzogcm9iZXJ0LnJpY2h0ZXJAY2F2aXVtbmV0d29ya3MuY29t OyBtd0BzZW1paGFsZi5jb207DQo+IExpdml1LkR1ZGF1QGFybS5jb207IGRkYW5leUBjYXZpdW1u ZXR3b3Jrcy5jb207IFdhbmd5aWppbmc7DQo+IFN1cmF2ZWUuU3V0aGlrdWxwYW5pdEBhbWQuY29t OyBtc2FsdGVyQHJlZGhhdC5jb207IGxpbnV4LQ0KPiBwY2lAdmdlci5rZXJuZWwub3JnOyBsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LQ0KPiBhY3BpQHZnZXIua2Vy bmVsLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgbGluYXJvLQ0KPiBhY3BpQGxp c3RzLmxpbmFyby5vcmc7IGpjbUByZWRoYXQuY29tOyBhbmRyZWEuZ2FsbG9AbGluYXJvLm9yZzsN Cj4gZGhkYW5nQGFwbS5jb207IGplcmVteS5saW50b25AYXJtLmNvbTsgY292QGNvZGVhdXJvcmEu b3JnOyBDaGVueGluDQo+IChDaGFybGVzKTsgTGludXhhcm0NCj4gU3ViamVjdDogUmU6IFtSRkMg UEFUQ0ggVjIgMS8yXSBBQ1BJL1BDSTogTWF0Y2ggUENJIGNvbmZpZyBzcGFjZQ0KPiBhY2Nlc3Nv cnMgYWdhaW5zdCBwbGF0ZnJvbSBzcGVjaWZpYyBFQ0FNIHF1aXJrcw0KPiANCj4gT24gNi8xMy8y MDE2IDk6NTQgQU0sIEdhYnJpZWxlIFBhb2xvbmkgd3JvdGU6DQo+ID4gQXMgeW91IGNhbiBzZWUg aGVyZSBMaXVkb25nZG9uZyBoYXMgcmVwbGFjZWQgb2VtX3JldmlzaW9uIHdpdGgNCj4gPiBvZW1f dGFibGVfaWQuDQo+ID4NCj4gPiBOb3cgaXQgc2VlbXMgdGhhdCB0aGVyZSBhcmUgc29tZSBwbGF0 Zm9ybXMgdGhhdCBoYXZlIGFscmVhZHkgc2hpcHBlZA0KPiA+IHVzaW5nIGEgbWF0Y2hpbmcgYmFz ZWQgb24gdGhlIG9lbV9yZXZpc2lvbiAocmlnaHQgSm9uPykNCj4gPg0KPiA+IEhvd2V2ZXIgSSBn dWVzcyB0aGF0IGlmIGluIEZXIHRoZXkgaGF2ZSBkZWZpbmVkIG9lbV90YWJsZV9pZCBwcm9wZXJs eQ0KPiA+IHRoZXkgc2hvdWxkIGJlIGFibGUgdG8gdXNlIHRoaXMgbWVjaGFuaXNtIHdpdGhvdXQg bmVlZGluZyB0byBhIEZXDQo+IHVwZGF0ZS4NCj4gPg0KPiA+IENhbiB0aGVzZSB2ZW5kb3JzIGNv bmZpcm0gdGhpcz8NCj4gPg0KPiA+IFRvbWFzeiBkbyB5b3UgdGhpbmsgdGhpcyBjYW4gd29yayBm b3IgQ2F2aXVtIFRodW5kZXI/DQo+ID4NCj4gPiBUaGFua3MNCj4gPg0KPiA+IEdhYg0KPiANCj4g V2h5IG5vdCBoYXZlIGFsbCB0aHJlZSBvZiB0aGVtPw0KPiANCj4gVGhlIGluaXRpYWwgYXBwcm9h Y2ggd2FzIE9FTSBpZCBhbmQgcmV2aXNpb24gaWQuDQo+IA0KPiBKZWZmIEh1Z28gaW5kaWNhdGVk IHRoYXQgYWRkaXRpb24gKG5vdCByZW1vdmluZyBhbnkgb3RoZXIgZmllbGRzKSBvZg0KPiB0YWJs ZSBpZA0KPiB3b3VsZCBtYWtlIG1vcmUgc2Vuc2UuDQoNCk1tbSBmcm9tIGxhc3QgZW1haWwgb2Yg SmVmZiBIdWdvIG9uICJbUkZDIFBBVENIIDEvM10gcGNpLCBhY3BpOiBNYXRjaA0KUENJIGNvbmZp ZyBzcGFjZSBhY2Nlc3NvcnMgYWdhaW5zdCBwbGF0ZnJvbSBzcGVjaWZpYyBFQ0FNIHF1aXJrcy4i DQoNCkkgcXVvdGU6DQoNCiAiVXNpbmcgdGhlIE9FTSByZXZpc2lvbiANCiBmaWVsZCBkb2VzIG5v dCBzZWVtIHRvIGJlIGFwcHJvcHJpYXRlIHNpbmNlIHRoZXNlIGFyZSBkaWZmZXJlbnQgDQogcGxh dGZvcm1zIGFuZCB0aGUgcmV2aXNpb24gZmllbGQgYXBwZWFycyB0byBiZSBmb3IgdGhlIHB1cnBv c2Ugb2YgDQogdHJhY2tpbmcgZGlmZmVyZW5jZXMgd2l0aGluIGEgc2luZ2xlIHBsYXRmb3JtLiAg VGhlcmVmb3JlLCBDb3YgaXMgDQogcHJvcG9zaW5nIHVzaW5nIHRoZSBPRU0gdGFibGUgaWQgYXMg YSBtZWNoYW5pc20gdG8gZGlzdGluZ3Vpc2gNCiBwbGF0Zm9ybSBBIChuZWVkcyBxdWlyayBhcHBs aWVkKSB2cyBwbGF0Zm9ybSBCIChubyBxdWlya3MpIGZyb20gdGhlDQogc2FtZSBPRU0uIg0KDQpT byBpdCBsb29rcyB0byBtZSB0aGF0IGhlIHBvaW50ZWQgb3V0IHRoYXQgdXNpbmcgdGhlIE9FTSBy ZXZpc2lvbiBmaWVsZA0KaXMgd3JvbmcuLi5hbmQgdGhpcyBpcyB3aHkgSSBoYXZlIGFza2VkIGlm IHJlcGxhY2luZyBpdCB3aXRoIHRoZSB0YWJsZQ0KaWQgY2FuIHdvcmsgZm9yIG90aGVyIHZlbmRv cnMuLi4uDQoNClRoYW5rcw0KDQpHYWINCg0KDQo+IA0KPiAtLQ0KPiBTaW5hbiBLYXlhDQo+IFF1 YWxjb21tIFRlY2hub2xvZ2llcywgSW5jLiBvbiBiZWhhbGYgb2YgUXVhbGNvbW0gSW5ub3ZhdGlv biBDZW50ZXIsDQo+IEluYy4NCj4gUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMg YSBtZW1iZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sIGENCj4gTGludXggRm91bmRhdGlvbiBDb2xs YWJvcmF0aXZlIFByb2plY3QNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424266AbcFMOaN (ORCPT ); Mon, 13 Jun 2016 10:30:13 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:2415 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422860AbcFMOaI (ORCPT ); Mon, 13 Jun 2016 10:30:08 -0400 From: Gabriele Paoloni To: Sinan Kaya , "liudongdong (C)" , "helgaas@kernel.org" , "arnd@arndb.de" , "will.deacon@arm.com" , "catalin.marinas@arm.com" , "rafael@kernel.org" , "hanjun.guo@linaro.org" , "Lorenzo.Pieralisi@arm.com" , "jchandra@broadcom.com" , "tn@semihalf.com" CC: "robert.richter@caviumnetworks.com" , "mw@semihalf.com" , "Liviu.Dudau@arm.com" , "ddaney@caviumnetworks.com" , Wangyijing , "Suravee.Suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , "jcm@redhat.com" , "andrea.gallo@linaro.org" , "dhdang@apm.com" , "jeremy.linton@arm.com" , "cov@codeaurora.org" , "Chenxin (Charles)" , Linuxarm Subject: RE: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks Thread-Topic: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks Thread-Index: AQHRxXIkbhAnIs/vBUuIDrYXXwhW9p/naITg///0aYCAABazAA== Date: Mon, 13 Jun 2016 14:29:01 +0000 Message-ID: References: <1465822923-33599-1-git-send-email-liudongdong3@huawei.com> <1465822923-33599-2-git-send-email-liudongdong3@huawei.com> <575EBD13.8080808@codeaurora.org> In-Reply-To: <575EBD13.8080808@codeaurora.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.210.142.221] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.575EC33B.0242,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: bb0af71c6e23a3edab589804df4cfb29 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5DEUIok008512 Hi Sinan > -----Original Message----- > From: Sinan Kaya [mailto:okaya@codeaurora.org] > Sent: 13 June 2016 15:03 > To: Gabriele Paoloni; liudongdong (C); helgaas@kernel.org; > arnd@arndb.de; will.deacon@arm.com; catalin.marinas@arm.com; > rafael@kernel.org; hanjun.guo@linaro.org; Lorenzo.Pieralisi@arm.com; > jchandra@broadcom.com; tn@semihalf.com > Cc: robert.richter@caviumnetworks.com; mw@semihalf.com; > Liviu.Dudau@arm.com; ddaney@caviumnetworks.com; Wangyijing; > Suravee.Suthikulpanit@amd.com; msalter@redhat.com; linux- > pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linaro- > acpi@lists.linaro.org; jcm@redhat.com; andrea.gallo@linaro.org; > dhdang@apm.com; jeremy.linton@arm.com; cov@codeaurora.org; Chenxin > (Charles); Linuxarm > Subject: Re: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space > accessors against platfrom specific ECAM quirks > > On 6/13/2016 9:54 AM, Gabriele Paoloni wrote: > > As you can see here Liudongdong has replaced oem_revision with > > oem_table_id. > > > > Now it seems that there are some platforms that have already shipped > > using a matching based on the oem_revision (right Jon?) > > > > However I guess that if in FW they have defined oem_table_id properly > > they should be able to use this mechanism without needing to a FW > update. > > > > Can these vendors confirm this? > > > > Tomasz do you think this can work for Cavium Thunder? > > > > Thanks > > > > Gab > > Why not have all three of them? > > The initial approach was OEM id and revision id. > > Jeff Hugo indicated that addition (not removing any other fields) of > table id > would make more sense. Mmm from last email of Jeff Hugo on "[RFC PATCH 1/3] pci, acpi: Match PCI config space accessors against platfrom specific ECAM quirks." I quote: "Using the OEM revision field does not seem to be appropriate since these are different platforms and the revision field appears to be for the purpose of tracking differences within a single platform. Therefore, Cov is proposing using the OEM table id as a mechanism to distinguish platform A (needs quirk applied) vs platform B (no quirks) from the same OEM." So it looks to me that he pointed out that using the OEM revision field is wrong...and this is why I have asked if replacing it with the table id can work for other vendors.... Thanks Gab > > -- > Sinan Kaya > Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, > Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a > Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Gabriele Paoloni To: Sinan Kaya , "liudongdong (C)" , "helgaas@kernel.org" , "arnd@arndb.de" , "will.deacon@arm.com" , "catalin.marinas@arm.com" , "rafael@kernel.org" , "hanjun.guo@linaro.org" , "Lorenzo.Pieralisi@arm.com" , "jchandra@broadcom.com" , "tn@semihalf.com" CC: "robert.richter@caviumnetworks.com" , "mw@semihalf.com" , "Liviu.Dudau@arm.com" , "ddaney@caviumnetworks.com" , Wangyijing , "Suravee.Suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , "jcm@redhat.com" , "andrea.gallo@linaro.org" , "dhdang@apm.com" , "jeremy.linton@arm.com" , "cov@codeaurora.org" , "Chenxin (Charles)" , Linuxarm Subject: RE: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks Date: Mon, 13 Jun 2016 14:29:01 +0000 Message-ID: References: <1465822923-33599-1-git-send-email-liudongdong3@huawei.com> <1465822923-33599-2-git-send-email-liudongdong3@huawei.com> <575EBD13.8080808@codeaurora.org> In-Reply-To: <575EBD13.8080808@codeaurora.org> Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 List-ID: SGkgU2luYW4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTaW5hbiBL YXlhIFttYWlsdG86b2theWFAY29kZWF1cm9yYS5vcmddDQo+IFNlbnQ6IDEzIEp1bmUgMjAxNiAx NTowMw0KPiBUbzogR2FicmllbGUgUGFvbG9uaTsgbGl1ZG9uZ2RvbmcgKEMpOyBoZWxnYWFzQGtl cm5lbC5vcmc7DQo+IGFybmRAYXJuZGIuZGU7IHdpbGwuZGVhY29uQGFybS5jb207IGNhdGFsaW4u bWFyaW5hc0Bhcm0uY29tOw0KPiByYWZhZWxAa2VybmVsLm9yZzsgaGFuanVuLmd1b0BsaW5hcm8u b3JnOyBMb3JlbnpvLlBpZXJhbGlzaUBhcm0uY29tOw0KPiBqY2hhbmRyYUBicm9hZGNvbS5jb207 IHRuQHNlbWloYWxmLmNvbQ0KPiBDYzogcm9iZXJ0LnJpY2h0ZXJAY2F2aXVtbmV0d29ya3MuY29t OyBtd0BzZW1paGFsZi5jb207DQo+IExpdml1LkR1ZGF1QGFybS5jb207IGRkYW5leUBjYXZpdW1u ZXR3b3Jrcy5jb207IFdhbmd5aWppbmc7DQo+IFN1cmF2ZWUuU3V0aGlrdWxwYW5pdEBhbWQuY29t OyBtc2FsdGVyQHJlZGhhdC5jb207IGxpbnV4LQ0KPiBwY2lAdmdlci5rZXJuZWwub3JnOyBsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LQ0KPiBhY3BpQHZnZXIua2Vy bmVsLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgbGluYXJvLQ0KPiBhY3BpQGxp c3RzLmxpbmFyby5vcmc7IGpjbUByZWRoYXQuY29tOyBhbmRyZWEuZ2FsbG9AbGluYXJvLm9yZzsN Cj4gZGhkYW5nQGFwbS5jb207IGplcmVteS5saW50b25AYXJtLmNvbTsgY292QGNvZGVhdXJvcmEu b3JnOyBDaGVueGluDQo+IChDaGFybGVzKTsgTGludXhhcm0NCj4gU3ViamVjdDogUmU6IFtSRkMg UEFUQ0ggVjIgMS8yXSBBQ1BJL1BDSTogTWF0Y2ggUENJIGNvbmZpZyBzcGFjZQ0KPiBhY2Nlc3Nv cnMgYWdhaW5zdCBwbGF0ZnJvbSBzcGVjaWZpYyBFQ0FNIHF1aXJrcw0KPiANCj4gT24gNi8xMy8y MDE2IDk6NTQgQU0sIEdhYnJpZWxlIFBhb2xvbmkgd3JvdGU6DQo+ID4gQXMgeW91IGNhbiBzZWUg aGVyZSBMaXVkb25nZG9uZyBoYXMgcmVwbGFjZWQgb2VtX3JldmlzaW9uIHdpdGgNCj4gPiBvZW1f dGFibGVfaWQuDQo+ID4NCj4gPiBOb3cgaXQgc2VlbXMgdGhhdCB0aGVyZSBhcmUgc29tZSBwbGF0 Zm9ybXMgdGhhdCBoYXZlIGFscmVhZHkgc2hpcHBlZA0KPiA+IHVzaW5nIGEgbWF0Y2hpbmcgYmFz ZWQgb24gdGhlIG9lbV9yZXZpc2lvbiAocmlnaHQgSm9uPykNCj4gPg0KPiA+IEhvd2V2ZXIgSSBn dWVzcyB0aGF0IGlmIGluIEZXIHRoZXkgaGF2ZSBkZWZpbmVkIG9lbV90YWJsZV9pZCBwcm9wZXJs eQ0KPiA+IHRoZXkgc2hvdWxkIGJlIGFibGUgdG8gdXNlIHRoaXMgbWVjaGFuaXNtIHdpdGhvdXQg bmVlZGluZyB0byBhIEZXDQo+IHVwZGF0ZS4NCj4gPg0KPiA+IENhbiB0aGVzZSB2ZW5kb3JzIGNv bmZpcm0gdGhpcz8NCj4gPg0KPiA+IFRvbWFzeiBkbyB5b3UgdGhpbmsgdGhpcyBjYW4gd29yayBm b3IgQ2F2aXVtIFRodW5kZXI/DQo+ID4NCj4gPiBUaGFua3MNCj4gPg0KPiA+IEdhYg0KPiANCj4g V2h5IG5vdCBoYXZlIGFsbCB0aHJlZSBvZiB0aGVtPw0KPiANCj4gVGhlIGluaXRpYWwgYXBwcm9h Y2ggd2FzIE9FTSBpZCBhbmQgcmV2aXNpb24gaWQuDQo+IA0KPiBKZWZmIEh1Z28gaW5kaWNhdGVk IHRoYXQgYWRkaXRpb24gKG5vdCByZW1vdmluZyBhbnkgb3RoZXIgZmllbGRzKSBvZg0KPiB0YWJs ZSBpZA0KPiB3b3VsZCBtYWtlIG1vcmUgc2Vuc2UuDQoNCk1tbSBmcm9tIGxhc3QgZW1haWwgb2Yg SmVmZiBIdWdvIG9uICJbUkZDIFBBVENIIDEvM10gcGNpLCBhY3BpOiBNYXRjaA0KUENJIGNvbmZp ZyBzcGFjZSBhY2Nlc3NvcnMgYWdhaW5zdCBwbGF0ZnJvbSBzcGVjaWZpYyBFQ0FNIHF1aXJrcy4i DQoNCkkgcXVvdGU6DQoNCiAiVXNpbmcgdGhlIE9FTSByZXZpc2lvbiANCiBmaWVsZCBkb2VzIG5v dCBzZWVtIHRvIGJlIGFwcHJvcHJpYXRlIHNpbmNlIHRoZXNlIGFyZSBkaWZmZXJlbnQgDQogcGxh dGZvcm1zIGFuZCB0aGUgcmV2aXNpb24gZmllbGQgYXBwZWFycyB0byBiZSBmb3IgdGhlIHB1cnBv c2Ugb2YgDQogdHJhY2tpbmcgZGlmZmVyZW5jZXMgd2l0aGluIGEgc2luZ2xlIHBsYXRmb3JtLiAg VGhlcmVmb3JlLCBDb3YgaXMgDQogcHJvcG9zaW5nIHVzaW5nIHRoZSBPRU0gdGFibGUgaWQgYXMg YSBtZWNoYW5pc20gdG8gZGlzdGluZ3Vpc2gNCiBwbGF0Zm9ybSBBIChuZWVkcyBxdWlyayBhcHBs aWVkKSB2cyBwbGF0Zm9ybSBCIChubyBxdWlya3MpIGZyb20gdGhlDQogc2FtZSBPRU0uIg0KDQpT byBpdCBsb29rcyB0byBtZSB0aGF0IGhlIHBvaW50ZWQgb3V0IHRoYXQgdXNpbmcgdGhlIE9FTSBy ZXZpc2lvbiBmaWVsZA0KaXMgd3JvbmcuLi5hbmQgdGhpcyBpcyB3aHkgSSBoYXZlIGFza2VkIGlm IHJlcGxhY2luZyBpdCB3aXRoIHRoZSB0YWJsZQ0KaWQgY2FuIHdvcmsgZm9yIG90aGVyIHZlbmRv cnMuLi4uDQoNClRoYW5rcw0KDQpHYWINCg0KDQo+IA0KPiAtLQ0KPiBTaW5hbiBLYXlhDQo+IFF1 YWxjb21tIFRlY2hub2xvZ2llcywgSW5jLiBvbiBiZWhhbGYgb2YgUXVhbGNvbW0gSW5ub3ZhdGlv biBDZW50ZXIsDQo+IEluYy4NCj4gUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMg YSBtZW1iZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sIGENCj4gTGludXggRm91bmRhdGlvbiBDb2xs YWJvcmF0aXZlIFByb2plY3QNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: gabriele.paoloni@huawei.com (Gabriele Paoloni) Date: Mon, 13 Jun 2016 14:29:01 +0000 Subject: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks In-Reply-To: <575EBD13.8080808@codeaurora.org> References: <1465822923-33599-1-git-send-email-liudongdong3@huawei.com> <1465822923-33599-2-git-send-email-liudongdong3@huawei.com> <575EBD13.8080808@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sinan > -----Original Message----- > From: Sinan Kaya [mailto:okaya at codeaurora.org] > Sent: 13 June 2016 15:03 > To: Gabriele Paoloni; liudongdong (C); helgaas at kernel.org; > arnd at arndb.de; will.deacon at arm.com; catalin.marinas at arm.com; > rafael at kernel.org; hanjun.guo at linaro.org; Lorenzo.Pieralisi at arm.com; > jchandra at broadcom.com; tn at semihalf.com > Cc: robert.richter at caviumnetworks.com; mw at semihalf.com; > Liviu.Dudau at arm.com; ddaney at caviumnetworks.com; Wangyijing; > Suravee.Suthikulpanit at amd.com; msalter at redhat.com; linux- > pci at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- > acpi at vger.kernel.org; linux-kernel at vger.kernel.org; linaro- > acpi at lists.linaro.org; jcm at redhat.com; andrea.gallo at linaro.org; > dhdang at apm.com; jeremy.linton at arm.com; cov at codeaurora.org; Chenxin > (Charles); Linuxarm > Subject: Re: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space > accessors against platfrom specific ECAM quirks > > On 6/13/2016 9:54 AM, Gabriele Paoloni wrote: > > As you can see here Liudongdong has replaced oem_revision with > > oem_table_id. > > > > Now it seems that there are some platforms that have already shipped > > using a matching based on the oem_revision (right Jon?) > > > > However I guess that if in FW they have defined oem_table_id properly > > they should be able to use this mechanism without needing to a FW > update. > > > > Can these vendors confirm this? > > > > Tomasz do you think this can work for Cavium Thunder? > > > > Thanks > > > > Gab > > Why not have all three of them? > > The initial approach was OEM id and revision id. > > Jeff Hugo indicated that addition (not removing any other fields) of > table id > would make more sense. Mmm from last email of Jeff Hugo on "[RFC PATCH 1/3] pci, acpi: Match PCI config space accessors against platfrom specific ECAM quirks." I quote: "Using the OEM revision field does not seem to be appropriate since these are different platforms and the revision field appears to be for the purpose of tracking differences within a single platform. Therefore, Cov is proposing using the OEM table id as a mechanism to distinguish platform A (needs quirk applied) vs platform B (no quirks) from the same OEM." So it looks to me that he pointed out that using the OEM revision field is wrong...and this is why I have asked if replacing it with the table id can work for other vendors.... Thanks Gab > > -- > Sinan Kaya > Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, > Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a > Linux Foundation Collaborative Project