From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753459AbdEPP2H convert rfc822-to-8bit (ORCPT ); Tue, 16 May 2017 11:28:07 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:5890 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753329AbdEPP2A (ORCPT ); Tue, 16 May 2017 11:28:00 -0400 From: Gabriele Paoloni To: Christoph Hellwig CC: "bhelgaas@google.com" , "helgaas@kernel.org" , Linuxarm , "linux-pci@vger.kernel.org" , "lukas@wunner.de" , "linux-kernel@vger.kernel.org" , "mika.westerberg@linux.intel.com" Subject: RE: [PATCH 2/2] PCI/portdrv: allocate MSI/MSIx vector for DPC RP service Thread-Topic: [PATCH 2/2] PCI/portdrv: allocate MSI/MSIx vector for DPC RP service Thread-Index: AQHSzi7WdLduO82zZE6UNW7BqcrQlaH2vR8AgABYQ/A= Date: Tue, 16 May 2017 15:27:40 +0000 Message-ID: References: <1494930342-7132-1-git-send-email-gabriele.paoloni@huawei.com> <1494930342-7132-3-git-send-email-gabriele.paoloni@huawei.com> <20170516121112.GA16209@infradead.org> In-Reply-To: <20170516121112.GA16209@infradead.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.162] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.591B1A7C.007D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.104, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 66f4891f986a26b970ccc482462e2a38 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph > -----Original Message----- > From: Christoph Hellwig [mailto:hch@infradead.org] > Sent: 16 May 2017 13:11 > To: Gabriele Paoloni > Cc: bhelgaas@google.com; helgaas@kernel.org; Linuxarm; linux- > pci@vger.kernel.org; lukas@wunner.de; linux-kernel@vger.kernel.org; > mika.westerberg@linux.intel.com > Subject: Re: [PATCH 2/2] PCI/portdrv: allocate MSI/MSIx vector for DPC > RP service > > > + * pci_irq_vector() below is able to handle entry > differently > > + * depending on MSI vs MSI-x case > > + * Ok I'll remove this in V2 > > No need to mention that for every users. > > Except for that this looks fine: > > Reviewed-by: Christoph Hellwig Many thanks Gab From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Gabriele Paoloni To: Christoph Hellwig CC: "bhelgaas@google.com" , "helgaas@kernel.org" , Linuxarm , "linux-pci@vger.kernel.org" , "lukas@wunner.de" , "linux-kernel@vger.kernel.org" , "mika.westerberg@linux.intel.com" Subject: RE: [PATCH 2/2] PCI/portdrv: allocate MSI/MSIx vector for DPC RP service Date: Tue, 16 May 2017 15:27:40 +0000 Message-ID: References: <1494930342-7132-1-git-send-email-gabriele.paoloni@huawei.com> <1494930342-7132-3-git-send-email-gabriele.paoloni@huawei.com> <20170516121112.GA16209@infradead.org> In-Reply-To: <20170516121112.GA16209@infradead.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-ID: Hi Christoph > -----Original Message----- > From: Christoph Hellwig [mailto:hch@infradead.org] > Sent: 16 May 2017 13:11 > To: Gabriele Paoloni > Cc: bhelgaas@google.com; helgaas@kernel.org; Linuxarm; linux- > pci@vger.kernel.org; lukas@wunner.de; linux-kernel@vger.kernel.org; > mika.westerberg@linux.intel.com > Subject: Re: [PATCH 2/2] PCI/portdrv: allocate MSI/MSIx vector for DPC > RP service >=20 > > + * pci_irq_vector() below is able to handle entry > differently > > + * depending on MSI vs MSI-x case > > + * Ok I'll remove this in V2 >=20 > No need to mention that for every users. >=20 > Except for that this looks fine: >=20 > Reviewed-by: Christoph Hellwig Many thanks Gab