From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Gabriele Paoloni To: Benjamin Herrenschmidt , Alex Williamson , Bjorn Helgaas Subject: RE: [PATCH v4] PCI: Support hibmc VGA cards behind a misbehaving HiSilicon bridge Date: Fri, 14 Jul 2017 12:26:05 +0000 Message-ID: References: <20170712050811.3620-1-dja@axtens.net> <20170712200430.GI14614@bhelgaas-glaptop.roam.corp.google.com> <20170713112938.GI4486@bhelgaas-glaptop.roam.corp.google.com> <20170713151146.53e9644c@w520.home> <1499980882.2865.65.camel@kernel.crashing.org> In-Reply-To: <1499980882.2865.65.camel@kernel.crashing.org> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "linux-pci@vger.kernel.org" , Will Deacon , "Liuxinliang \(Matthew Liu\)" , Catalin Marinas , Rongrong Zou , Daniel Vetter , "linux-arm-kernel@lists.infradead.org" , Daniel Axtens Content-Type: text/plain; charset="utf-8" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: SGkgQmVuLCBBbGV4DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQmVu amFtaW4gSGVycmVuc2NobWlkdCBbbWFpbHRvOmJlbmhAa2VybmVsLmNyYXNoaW5nLm9yZ10NCj4g U2VudDogMTMgSnVseSAyMDE3IDIyOjIxDQo+IFRvOiBBbGV4IFdpbGxpYW1zb247IEJqb3JuIEhl bGdhYXMNCj4gQ2M6IEdhYnJpZWxlIFBhb2xvbmk7IERhbmllbCBBeHRlbnM7IGxpbnV4LXBjaUB2 Z2VyLmtlcm5lbC5vcmc7DQo+IExpdXhpbmxpYW5nIChNYXR0aGV3IExpdSk7IFJvbmdyb25nIFpv dTsgQ2F0YWxpbiBNYXJpbmFzOyBXaWxsIERlYWNvbjsNCj4gbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnOyBEYXZpZCBBaXJsaWU7IERhbmllbCBWZXR0ZXINCj4gU3ViamVjdDog UmU6IFtQQVRDSCB2NF0gUENJOiBTdXBwb3J0IGhpYm1jIFZHQSBjYXJkcyBiZWhpbmQgYQ0KPiBt aXNiZWhhdmluZyBIaVNpbGljb24gYnJpZGdlDQo+IA0KPiBPbiBUaHUsIDIwMTctMDctMTMgYXQg MTU6MTEgLTA2MDAsIEFsZXggV2lsbGlhbXNvbiB3cm90ZToNCj4gPiA+ID4gwqDCoMKgwqDCoCAq Lw0KPiA+ID4gPiAtwqDCoMKgaWYgKHZnYV9kZWZhdWx0ID09IE5VTEwgJiYNCj4gPiA+ID4gLcKg wqDCoMKgwqDCoCAoKHZnYWRldi0+b3ducyAmIFZHQV9SU1JDX0xFR0FDWV9NQVNLKSA9PQ0KPiBW R0FfUlNSQ19MRUdBQ1lfTUFTSykpIHsNCj4gPiA+ID4gK8KgwqDCoGlmICh2Z2FfZGVmYXVsdCA9 PSBOVUxMKSB7DQo+ID4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgdmdhYXJiX2luZm8o JnBkZXYtPmRldiwgInNldHRpbmcgYXMgYm9vdCBWR0ENCj4gZGV2aWNlXG4iKTsNCj4gPiA+ID4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB2Z2Ffc2V0X2RlZmF1bHRfZGV2aWNlKHBkZXYpOw0K PiA+ID4gPiDCoMKgwqDCoMKgfQ0KPiA+DQo+ID4NCj4gPiAiTGVnYWN5IiBpcyB0aGUgYnJlYWRj cnVtYiB3ZSB1c2UgdG8gdHJ5IHRvIHBpY2sgdGhlIHNhbWUgZGV2aWNlIGZvcg0KPiA+IGRlZmF1 bHQgVkdBIGFzIHRoZSBzeXN0ZW0gZmlybXdhcmUgdXNlZCBhcyB0aGUgYm9vdCBWR0EuwqAgVGhl cmUgY2FuDQo+IGJlDQo+ID4gbXVsdGlwbGUgVkdBIGRldmljZXMgaW4gdGhlIHN5c3RlbSwgdGhl IGNoYW5nZSBhYm92ZSB3b3VsZCBzaW1wbHkNCj4gbWFrZQ0KPiA+IHRoZSBmaXJzdCBkaXNjb3Zl cmVkIGRldmljZSBiZSB0aGUgZGVmYXVsdCBWR0EuwqAgVGhhdCB3b3VsZCBicmVhaw0KPiBtYW55 LA0KPiA+IG1hbnkgc3lzdGVtcy7CoCBJZiBsZWdhY3kgVkdBIHJhbmdlcyBtZWFuIG5vdGhpbmcg b24gQVJNNjQsIHRoZW4NCj4gZm9sbG93DQo+ID4gdGhlIHBvd2VycGMgbGVhZCBhbmQgbWFrZSBh biBhcmNoIHF1aXJrIHRoYXQgc2ltcGx5IHNlbGVjdHMgdGhlIGZpcnN0DQo+ID4gZW5hYmxlZCBW R0EgZGV2aWNlIGFzIHRoZSBkZWZhdWx0LsKgIFZHQSByb3V0aW5nIGlzIHBhcnQgb2YgdGhlIFBD SQ0KPiBzcGVjDQo+ID4gdGhvdWdoLCBzbyB0aGUgZGVmYXVsdCBvZiBzZWxlY3RpbmcgdGhlIGRl dmljZSB3aXRoIHJvdXRpbmcgZW5hYmxlZA0KPiA+IG1ha2VzIHNlbnNlLsKgIFRoYW5rcywNCj4g DQo+ICJMZWdhY3kiIHRoZXJlIGlpcmMgYWxzbyBtZWFucyB0aGF0IGl0IGhhcyBkZWNvZGluZyBl bmFibGVkIGF0IGJvb3QuIElmDQo+IHlvdSBwaWNrIHRoZSBmaXJzdCBvbmUgeW91IG1heSBwaWNr IGEgZGV2aWNlIHRoYXQgZG9lc24ndCBhbmQgaGFzbid0DQo+IGJlZW4gaW5pdGlhbGl6ZWQgYnkg YW55IGRyaXZlciAoZ29vZCBvbGQgQklPUy1pbml0aWFsaXplZCB0ZXh0IG1vZGUpLg0KDQpSaWdo dCBzbyBlZmZlY3RpdmVseSBpZiB0aGVyZSBpcyBhIGxlZ2FjeSBkZXYgd2Ugc2hvdWxkIHBpY2sg dGhhdCB1cDsNCmhvd2V2ZXIgd2hhdCBhYm91dCB0aGUgZm9sbG93aW5nIGNvZGU6DQoNCmRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS92Z2EvdmdhYXJiLmMgYi9kcml2ZXJzL2dwdS92Z2EvdmdhYXJi LmMNCmluZGV4IDkyZjE0NTIuLmFiM2FkOWEgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2dwdS92Z2Ev dmdhYXJiLmMNCisrKyBiL2RyaXZlcnMvZ3B1L3ZnYS92Z2FhcmIuYw0KQEAgLTE0MjQsNiArMTQy NCwxNCBAQCBzdGF0aWMgaW50IF9faW5pdCB2Z2FfYXJiX2RldmljZV9pbml0KHZvaWQpDQogDQog CWxpc3RfZm9yX2VhY2hfZW50cnkodmdhZGV2LCAmdmdhX2xpc3QsIGxpc3QpIHsNCiAJCXN0cnVj dCBkZXZpY2UgKmRldiA9ICZ2Z2FkZXYtPnBkZXYtPmRldjsNCisNCisJCS8qIGlmIG5vIGxlZ2Fj eSBkZXZpY2UgaGFzIGJlZW4gc2V0IGFzIGRlZmF1bHQgVkdBDQorCQkgKiBkZXZpY2UsIGp1c3Qg cGljayB1cCB0aGUgZmlyc3Qgb25lIGluIHRoZSBsaXN0ICovDQorCQlpZiAodmdhX2RlZmF1bHQg PT0gTlVMTCkgew0KKwkJCXZnYWFyYl9pbmZvKGRldiwgInNldHRpbmcgYXMgYm9vdCBWR0EgZGV2 aWNlXG4iKTsNCisJCQl2Z2Ffc2V0X2RlZmF1bHRfZGV2aWNlKHZnYWRldi0+cGRldik7DQorCQl9 DQorDQogI2lmIGRlZmluZWQoQ09ORklHX1g4NikgfHwgZGVmaW5lZChDT05GSUdfSUE2NCkNCiAJ CS8qDQogCQkgKiBPdmVycmlkZSB2Z2FfYXJiaXRlcl9hZGRfcGNpX2RldmljZSgpJ3MgSS9PIGJh c2VkIGRldGVjdGlvbiANCg0KQWJvdmUgYWZ0ZXIgd2UgaGF2ZSBmaWxsZWQgdGhlIGxpc3Qgb2Yg VkdBIGRldmljZXMgYnkgaXRlcmF0aW5nIG92ZXIgYWxsDQpQQ0kgZGV2aWNlcyB3ZSBjaGVjayBp ZiBubyBsZWdhY3kgb25lIGhhcyBiZWVuIHNldCBhcyBkZWZhdWx0IFZHQSBkZXZpY2UNCnlldDog dGhlcmVmb3JlIHdlIHNldCB0aGUgZmlyc3QgVkdBIGRldmljZSBpbiB0aGUgbGlzdCBhcyBkZWZh dWx0IG9uZS4uLg0KDQpEbyB5b3UgdGhpbmsgaXQgd291bGQgd29yaz8NCg0KVGhhbmtzDQpHYWIN Cg0KPiANCj4gQ2hlZXJzLA0KPiBCZW4uDQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: gabriele.paoloni@huawei.com (Gabriele Paoloni) Date: Fri, 14 Jul 2017 12:26:05 +0000 Subject: [PATCH v4] PCI: Support hibmc VGA cards behind a misbehaving HiSilicon bridge In-Reply-To: <1499980882.2865.65.camel@kernel.crashing.org> References: <20170712050811.3620-1-dja@axtens.net> <20170712200430.GI14614@bhelgaas-glaptop.roam.corp.google.com> <20170713112938.GI4486@bhelgaas-glaptop.roam.corp.google.com> <20170713151146.53e9644c@w520.home> <1499980882.2865.65.camel@kernel.crashing.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Ben, Alex > -----Original Message----- > From: Benjamin Herrenschmidt [mailto:benh at kernel.crashing.org] > Sent: 13 July 2017 22:21 > To: Alex Williamson; Bjorn Helgaas > Cc: Gabriele Paoloni; Daniel Axtens; linux-pci at vger.kernel.org; > Liuxinliang (Matthew Liu); Rongrong Zou; Catalin Marinas; Will Deacon; > linux-arm-kernel at lists.infradead.org; David Airlie; Daniel Vetter > Subject: Re: [PATCH v4] PCI: Support hibmc VGA cards behind a > misbehaving HiSilicon bridge > > On Thu, 2017-07-13 at 15:11 -0600, Alex Williamson wrote: > > > > ????? */ > > > > -???if (vga_default == NULL && > > > > -?????? ((vgadev->owns & VGA_RSRC_LEGACY_MASK) == > VGA_RSRC_LEGACY_MASK)) { > > > > +???if (vga_default == NULL) { > > > > ?????????????vgaarb_info(&pdev->dev, "setting as boot VGA > device\n"); > > > > ?????????????vga_set_default_device(pdev); > > > > ?????} > > > > > > "Legacy" is the breadcrumb we use to try to pick the same device for > > default VGA as the system firmware used as the boot VGA.? There can > be > > multiple VGA devices in the system, the change above would simply > make > > the first discovered device be the default VGA.? That would break > many, > > many systems.? If legacy VGA ranges mean nothing on ARM64, then > follow > > the powerpc lead and make an arch quirk that simply selects the first > > enabled VGA device as the default.? VGA routing is part of the PCI > spec > > though, so the default of selecting the device with routing enabled > > makes sense.? Thanks, > > "Legacy" there iirc also means that it has decoding enabled at boot. If > you pick the first one you may pick a device that doesn't and hasn't > been initialized by any driver (good old BIOS-initialized text mode). Right so effectively if there is a legacy dev we should pick that up; however what about the following code: diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c index 92f1452..ab3ad9a 100644 --- a/drivers/gpu/vga/vgaarb.c +++ b/drivers/gpu/vga/vgaarb.c @@ -1424,6 +1424,14 @@ static int __init vga_arb_device_init(void) list_for_each_entry(vgadev, &vga_list, list) { struct device *dev = &vgadev->pdev->dev; + + /* if no legacy device has been set as default VGA + * device, just pick up the first one in the list */ + if (vga_default == NULL) { + vgaarb_info(dev, "setting as boot VGA device\n"); + vga_set_default_device(vgadev->pdev); + } + #if defined(CONFIG_X86) || defined(CONFIG_IA64) /* * Override vga_arbiter_add_pci_device()'s I/O based detection Above after we have filled the list of VGA devices by iterating over all PCI devices we check if no legacy one has been set as default VGA device yet: therefore we set the first VGA device in the list as default one... Do you think it would work? Thanks Gab > > Cheers, > Ben.