From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriele Paoloni Subject: RE: [PATCH v10 2/9] PCI: remove unused __weak attribute in pci_register_io_range() Date: Tue, 7 Nov 2017 10:50:00 +0000 Message-ID: References: <1509120687-7352-1-git-send-email-gabriele.paoloni@huawei.com> <1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com> <20171107002501.GD9538@bhelgaas-glaptop.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20171107002501.GD9538@bhelgaas-glaptop.roam.corp.google.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Helgaas Cc: "catalin.marinas@arm.com" , "will.deacon@arm.com" , "robh+dt@kernel.org" , "frowand.list@gmail.com" , "bhelgaas@google.com" , "rafael@kernel.org" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "lorenzo.pieralisi@arm.com" , "mark.rutland@arm.com" , "brian.starkey@arm.com" , "olof@lixom.net" , "benh@kernel.crashing.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Linuxarm
  • List-Id: linux-acpi@vger.kernel.org > -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@kernel.org] > Sent: 07 November 2017 00:25 > To: Gabriele Paoloni > Cc: catalin.marinas@arm.com; will.deacon@arm.com; robh+dt@kernel.org; > frowand.list@gmail.com; bhelgaas@google.com; rafael@kernel.org; > arnd@arndb.de; linux-arm-kernel@lists.infradead.org; > lorenzo.pieralisi@arm.com; mark.rutland@arm.com; brian.starkey@arm.com; > olof@lixom.net; benh@kernel.crashing.org; linux-kernel@vger.kernel.org; > linux-acpi@vger.kernel.org; Linuxarm; linux-pci@vger.kernel.org; > minyard@acm.org; John Garry; xuwei (O) > Subject: Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in > pci_register_io_range() > > On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > > From: gabriele paoloni > > > > Currently pci_register_io_range() has only one definition; > > therefore there is no use of the __weak attribute. > > > > Signed-off-by: Gabriele Paoloni > > Acked-by: Bjorn Helgaas > > Also, I normally use this (Google address instead of kernel.org): > > Acked-by: Bjorn Helgaas > > (Also affects your other PCI patches.) Ok no probs, we'll change all the Acked-by in the next patchset Many Thanks Gab > > > --- > > drivers/pci/pci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index af0cc34..eee967c 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > > * Record the PCI IO range (expressed as CPU physical address + > size). > > * Return a negative value if an error has occured, zero otherwise > > */ > > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t > size) > > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > > { > > int err = 0; > > > > -- > > 2.7.4 > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757453AbdKGKu1 convert rfc822-to-8bit (ORCPT ); Tue, 7 Nov 2017 05:50:27 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:39788 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753460AbdKGKuW (ORCPT ); Tue, 7 Nov 2017 05:50:22 -0500 From: Gabriele Paoloni To: Bjorn Helgaas CC: "catalin.marinas@arm.com" , "will.deacon@arm.com" , "robh+dt@kernel.org" , "frowand.list@gmail.com" , "bhelgaas@google.com" , "rafael@kernel.org" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "lorenzo.pieralisi@arm.com" , "mark.rutland@arm.com" , "brian.starkey@arm.com" , "olof@lixom.net" , "benh@kernel.crashing.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Linuxarm , "linux-pci@vger.kernel.org" , "minyard@acm.org" , John Garry , "xuwei (O)" Subject: RE: [PATCH v10 2/9] PCI: remove unused __weak attribute in pci_register_io_range() Thread-Topic: [PATCH v10 2/9] PCI: remove unused __weak attribute in pci_register_io_range() Thread-Index: AQHTTz5rgcnJKfWAgk2VWVFdEupcCaMIDnKAgAC/PJA= Date: Tue, 7 Nov 2017 10:50:00 +0000 Message-ID: References: <1509120687-7352-1-git-send-email-gabriele.paoloni@huawei.com> <1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com> <20171107002501.GD9538@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: <20171107002501.GD9538@bhelgaas-glaptop.roam.corp.google.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.226.120] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.5A018FE4.015C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.209, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: bd6f37a4c86a4ecb06c209624d54e01d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@kernel.org] > Sent: 07 November 2017 00:25 > To: Gabriele Paoloni > Cc: catalin.marinas@arm.com; will.deacon@arm.com; robh+dt@kernel.org; > frowand.list@gmail.com; bhelgaas@google.com; rafael@kernel.org; > arnd@arndb.de; linux-arm-kernel@lists.infradead.org; > lorenzo.pieralisi@arm.com; mark.rutland@arm.com; brian.starkey@arm.com; > olof@lixom.net; benh@kernel.crashing.org; linux-kernel@vger.kernel.org; > linux-acpi@vger.kernel.org; Linuxarm; linux-pci@vger.kernel.org; > minyard@acm.org; John Garry; xuwei (O) > Subject: Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in > pci_register_io_range() > > On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > > From: gabriele paoloni > > > > Currently pci_register_io_range() has only one definition; > > therefore there is no use of the __weak attribute. > > > > Signed-off-by: Gabriele Paoloni > > Acked-by: Bjorn Helgaas > > Also, I normally use this (Google address instead of kernel.org): > > Acked-by: Bjorn Helgaas > > (Also affects your other PCI patches.) Ok no probs, we'll change all the Acked-by in the next patchset Many Thanks Gab > > > --- > > drivers/pci/pci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index af0cc34..eee967c 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > > * Record the PCI IO range (expressed as CPU physical address + > size). > > * Return a negative value if an error has occured, zero otherwise > > */ > > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t > size) > > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > > { > > int err = 0; > > > > -- > > 2.7.4 > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Gabriele Paoloni To: Bjorn Helgaas CC: "catalin.marinas@arm.com" , "will.deacon@arm.com" , "robh+dt@kernel.org" , "frowand.list@gmail.com" , "bhelgaas@google.com" , "rafael@kernel.org" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "lorenzo.pieralisi@arm.com" , "mark.rutland@arm.com" , "brian.starkey@arm.com" , "olof@lixom.net" , "benh@kernel.crashing.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Linuxarm , "linux-pci@vger.kernel.org" , "minyard@acm.org" , John Garry , "xuwei (O)" Subject: RE: [PATCH v10 2/9] PCI: remove unused __weak attribute in pci_register_io_range() Date: Tue, 7 Nov 2017 10:50:00 +0000 Message-ID: References: <1509120687-7352-1-git-send-email-gabriele.paoloni@huawei.com> <1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com> <20171107002501.GD9538@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: <20171107002501.GD9538@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-ID: > -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@kernel.org] > Sent: 07 November 2017 00:25 > To: Gabriele Paoloni > Cc: catalin.marinas@arm.com; will.deacon@arm.com; robh+dt@kernel.org; > frowand.list@gmail.com; bhelgaas@google.com; rafael@kernel.org; > arnd@arndb.de; linux-arm-kernel@lists.infradead.org; > lorenzo.pieralisi@arm.com; mark.rutland@arm.com; brian.starkey@arm.com; > olof@lixom.net; benh@kernel.crashing.org; linux-kernel@vger.kernel.org; > linux-acpi@vger.kernel.org; Linuxarm; linux-pci@vger.kernel.org; > minyard@acm.org; John Garry; xuwei (O) > Subject: Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in > pci_register_io_range() >=20 > On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > > From: gabriele paoloni > > > > Currently pci_register_io_range() has only one definition; > > therefore there is no use of the __weak attribute. > > > > Signed-off-by: Gabriele Paoloni > > Acked-by: Bjorn Helgaas >=20 > Also, I normally use this (Google address instead of kernel.org): >=20 > Acked-by: Bjorn Helgaas >=20 > (Also affects your other PCI patches.) Ok no probs, we'll change all the Acked-by in the next patchset Many Thanks Gab=20 >=20 > > --- > > drivers/pci/pci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index af0cc34..eee967c 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > > * Record the PCI IO range (expressed as CPU physical address + > size). > > * Return a negative value if an error has occured, zero otherwise > > */ > > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t > size) > > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > > { > > int err =3D 0; > > > > -- > > 2.7.4 > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: gabriele.paoloni@huawei.com (Gabriele Paoloni) Date: Tue, 7 Nov 2017 10:50:00 +0000 Subject: [PATCH v10 2/9] PCI: remove unused __weak attribute in pci_register_io_range() In-Reply-To: <20171107002501.GD9538@bhelgaas-glaptop.roam.corp.google.com> References: <1509120687-7352-1-git-send-email-gabriele.paoloni@huawei.com> <1509120687-7352-3-git-send-email-gabriele.paoloni@huawei.com> <20171107002501.GD9538@bhelgaas-glaptop.roam.corp.google.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas at kernel.org] > Sent: 07 November 2017 00:25 > To: Gabriele Paoloni > Cc: catalin.marinas at arm.com; will.deacon at arm.com; robh+dt at kernel.org; > frowand.list at gmail.com; bhelgaas at google.com; rafael at kernel.org; > arnd at arndb.de; linux-arm-kernel at lists.infradead.org; > lorenzo.pieralisi at arm.com; mark.rutland at arm.com; brian.starkey at arm.com; > olof at lixom.net; benh at kernel.crashing.org; linux-kernel at vger.kernel.org; > linux-acpi at vger.kernel.org; Linuxarm; linux-pci at vger.kernel.org; > minyard at acm.org; John Garry; xuwei (O) > Subject: Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in > pci_register_io_range() > > On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > > From: gabriele paoloni > > > > Currently pci_register_io_range() has only one definition; > > therefore there is no use of the __weak attribute. > > > > Signed-off-by: Gabriele Paoloni > > Acked-by: Bjorn Helgaas > > Also, I normally use this (Google address instead of kernel.org): > > Acked-by: Bjorn Helgaas > > (Also affects your other PCI patches.) Ok no probs, we'll change all the Acked-by in the next patchset Many Thanks Gab > > > --- > > drivers/pci/pci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index af0cc34..eee967c 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > > * Record the PCI IO range (expressed as CPU physical address + > size). > > * Return a negative value if an error has occured, zero otherwise > > */ > > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t > size) > > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > > { > > int err = 0; > > > > -- > > 2.7.4 > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > in > > the body of a message to majordomo at vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html