Sensor Whitelist

Sensor Whitelist

[Mike Jones]

Hi,

I’m getting an error from psusensor saying my driver is not found in sensor whitelist.

What defines this whitelist?

Note that the driver name is ltc3888, which is part of hwmon module ltc2978. In case the white listed name must refer to the module name instead of the driver name the module supports.

Also, I have not added this sensor to ipmi, but I am also using adm1278 without ipmi and it works. But in that case, the driver and module names are the same.

I searched for answers and found little. Perhaps there are docs but I am searching for the wrong key words.

Mike

Sent from my iPad

Re: Sensor Whitelist

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

On Wed, Jan 05, 2022 at 10:09:29AM -0700, Mike Jones wrote:
> Hi,
> 
> I’m getting an error from psusensor saying my driver is not found in sensor whitelist.
> 
> What defines this whitelist?

Probably this?

https://github.com/openbmc/dbus-sensors/blob/master/src/PSUSensorMain.cpp#L74

> 
> Note that the driver name is ltc3888, which is part of hwmon module ltc2978. In case the white listed name must refer to the module name instead of the driver name the module supports.

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Sensor Whitelist

[Mike Jones]

Patrick,

Ah ha. Thanks.

Do you know how this works from a policy point of view? Like is there some conventions about how devices are added and merged?

Is it just anyone can send a patch, or are there any gates to get by?

Mike

> On Jan 10, 2022, at 7:33 AM, Patrick Williams <patrick@stwcx.xyz> wrote:
> 
> On Wed, Jan 05, 2022 at 10:09:29AM -0700, Mike Jones wrote:
>> Hi,
>> 
>> I’m getting an error from psusensor saying my driver is not found in sensor whitelist.
>> 
>> What defines this whitelist?
> 
> Probably this?
> 
> https://github.com/openbmc/dbus-sensors/blob/master/src/PSUSensorMain.cpp#L74
> 
>> 
>> Note that the driver name is ltc3888, which is part of hwmon module ltc2978. In case the white listed name must refer to the module name instead of the driver name the module supports.
> 
> -- 
> Patrick Williams

Re: Sensor Whitelist

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

On Mon, Jan 10, 2022 at 08:01:33AM -0700, Mike Jones wrote:
 
> Do you know how this works from a policy point of view? Like is there some conventions about how devices are added and merged?
> 
> Is it just anyone can send a patch, or are there any gates to get by?
 
Generally anyone should be able to make a change to any repository (assuming
you've signed a CLA).  Some maintainers might have specific standards of what
testing they'd like to be done.  Best bet is to look at 'git blame' on these
lines and see what kind of 'Testing:' statements were in the commit messages on
commits that previously touched this list.  If the maintainer wants you to do
more testing than what you've listed in your commit message you two can work
that out in review.

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]