From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C00AFC433E6 for ; Wed, 20 Jan 2021 20:11:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C2C523442 for ; Wed, 20 Jan 2021 20:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388446AbhATOE5 (ORCPT ); Wed, 20 Jan 2021 09:04:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38971 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389725AbhATNVw (ORCPT ); Wed, 20 Jan 2021 08:21:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611148819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o1a7f9C2ycSBG82Y3WUMCoSqPFbmviWpDeWsLT8vtX8=; b=DQYkg3KKm/mFj16OplDlfCJBcjDCm8oTJ5uWMNvrbbs7y+sz1LvaWMGBEMyDfEFzkWCAb4 BSCZZkZEMQgvsGy777fp6H1qrieekOWMuqE4/9C3R3wsRMpgb/LahvrP88UaGqguoRzy8f l2UnP5oAoBcicQsj/wRGvjhMCy3JpwY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-s7LHZgAqOme4oai3IAOV4A-1; Wed, 20 Jan 2021 08:20:12 -0500 X-MC-Unique: s7LHZgAqOme4oai3IAOV4A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B623E87950D; Wed, 20 Jan 2021 13:20:10 +0000 (UTC) Received: from [10.36.114.82] (ovpn-114-82.ams2.redhat.com [10.36.114.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7E445D74B; Wed, 20 Jan 2021 13:20:02 +0000 (UTC) From: "Eelco Chaudron" To: "Maciej Fijalkowski" Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "Lorenzo Bianconi" , bpf@vger.kernel.org, netdev@vger.kernel.org, brouer@redhat.com, bjorn@kernel.org, toke@redhat.com, john.fastabend@gmail.com Subject: Re: [PATCH v5 bpf-next 13/14] bpf: add new frame_length field to the XDP ctx Date: Wed, 20 Jan 2021 14:20:01 +0100 Message-ID: In-Reply-To: <20210118164855.GA12769@ranger.igk.intel.com> References: <0547d6f752e325f56a8e5f6466b50e81ff29d65f.1607349924.git.lorenzo@kernel.org> <20201208221746.GA33399@ranger.igk.intel.com> <96C89134-A747-4E05-AA11-CB6EA1420900@redhat.com> <20201209111047.GB36812@ranger.igk.intel.com> <170BF39B-894D-495F-93E0-820EC7880328@redhat.com> <38C60760-4F8C-43AC-A5DE-7FAECB65C310@redhat.com> <20201215180638.GB23785@ranger.igk.intel.com> <54E66B9D-4677-436F-92A1-E70977E869FA@redhat.com> <5A8FDDE5-3022-4FD7-BA71-9ACB4374BDB9@redhat.com> <20210118164855.GA12769@ranger.igk.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 18 Jan 2021, at 17:48, Maciej Fijalkowski wrote: > On Fri, Jan 15, 2021 at 05:36:23PM +0100, Eelco Chaudron wrote: >> >> >> On 16 Dec 2020, at 15:08, Eelco Chaudron wrote: >> >>> On 15 Dec 2020, at 19:06, Maciej Fijalkowski wrote: >>> >>>> On Tue, Dec 15, 2020 at 02:28:39PM +0100, Eelco Chaudron wrote: >>>>> >>>>> >>>>> On 9 Dec 2020, at 13:07, Eelco Chaudron wrote: >>>>> >>>>>> On 9 Dec 2020, at 12:10, Maciej Fijalkowski wrote: >>>>> >>>>> >>>>> >>>>>>>>>> + >>>>>>>>>> + ctx_reg = (si->src_reg == si->dst_reg) ? scratch_reg - 1 : >>>>>>>>>> si->src_reg; >>>>>>>>>> + while (dst_reg == ctx_reg || scratch_reg == ctx_reg) >>>>>>>>>> + ctx_reg--; >>>>>>>>>> + >>>>>>>>>> + /* Save scratch registers */ >>>>>>>>>> + if (ctx_reg != si->src_reg) { >>>>>>>>>> + *insn++ = BPF_STX_MEM(BPF_DW, si->src_reg, ctx_reg, >>>>>>>>>> + offsetof(struct xdp_buff, >>>>>>>>>> + tmp_reg[1])); >>>>>>>>>> + >>>>>>>>>> + *insn++ = BPF_MOV64_REG(ctx_reg, si->src_reg); >>>>>>>>>> + } >>>>>>>>>> + >>>>>>>>>> + *insn++ = BPF_STX_MEM(BPF_DW, ctx_reg, scratch_reg, >>>>>>>>>> + offsetof(struct xdp_buff, tmp_reg[0])); >>>>>>>>> >>>>>>>>> Why don't you push regs to stack, use it and then pop it >>>>>>>>> back? That way >>>>>>>>> I >>>>>>>>> suppose you could avoid polluting xdp_buff with tmp_reg[2]. >>>>>>>> >>>>>>>> There is no “real” stack in eBPF, only a read-only frame >>>>>>>> pointer, and as we >>>>>>>> are replacing a single instruction, we have no info on what we >>>>>>>> can use as >>>>>>>> scratch space. >>>>>>> >>>>>>> Uhm, what? You use R10 for stack operations. Verifier tracks the >>>>>>> stack >>>>>>> depth used by programs and then it is passed down to JIT so that >>>>>>> native >>>>>>> asm will create a properly sized stack frame. >>>>>>> >>>>>>> From the top of my head I would let know >>>>>>> xdp_convert_ctx_access of a >>>>>>> current stack depth and use it for R10 stores, so your >>>>>>> scratch space >>>>>>> would >>>>>>> be R10 + (stack depth + 8), R10 + (stack_depth + 16). >>>>>> >>>>>> Other instances do exactly the same, i.e. put some scratch >>>>>> registers in >>>>>> the underlying data structure, so I reused this approach. From >>>>>> the >>>>>> current information in the callback, I was not able to >>>>>> determine the >>>>>> current stack_depth. With "real" stack above, I meant having >>>>>> a pop/push >>>>>> like instruction. >>>>>> >>>>>> I do not know the verifier code well enough, but are you >>>>>> suggesting I >>>>>> can get the current stack_depth from the verifier in the >>>>>> xdp_convert_ctx_access() callback? If so any pointers? >>>>> >>>>> Maciej any feedback on the above, i.e. getting the stack_depth in >>>>> xdp_convert_ctx_access()? >>>> >>>> Sorry. I'll try to get my head around it. If i recall correctly >>>> stack >>>> depth is tracked per subprogram whereas convert_ctx_accesses is >>>> iterating >>>> through *all* insns (so a prog that is not chunked onto subprogs), >>>> but >>>> maybe we could dig up the subprog based on insn idx. >>>> >>>> But at first, you mentioned that you took the approach from other >>>> instances, can you point me to them? >>> >>> Quick search found the following two (sure there is one more with >>> two >>> regs): >>> >>> https://elixir.bootlin.com/linux/v5.10.1/source/kernel/bpf/cgroup.c#L1718 >>> https://elixir.bootlin.com/linux/v5.10.1/source/net/core/filter.c#L8977 >>> >>>> I'd also like to hear from Daniel/Alexei/John and others their >>>> thoughts. >>> >>> Please keep me in the loop… >> >> Any thoughts/update on the above so I can move this patchset forward? > > Cc: John, Jesper, Bjorn > > I didn't spend time thinking about it, but I still am against xdp_buff > extension for the purpose that code within this patch has. Yes I agree, if we can not find an easy way to store the scratch registers on the stack, I’ll rework this patch to just store the total frame length in xdp_buff, as it will be less and still fit in one cache line. > Daniel/Alexei/John/Jesper/Bjorn, > > any objections for not having the scratch registers but rather use the > stack and update the stack depth to calculate the frame length? > > This seems not trivial so I really would like to have an input from > better > BPF developers than me :)