From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 440BFC433F5 for ; Fri, 10 Sep 2021 07:39:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 219B961186 for ; Fri, 10 Sep 2021 07:39:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231631AbhIJHka convert rfc822-to-8bit (ORCPT ); Fri, 10 Sep 2021 03:40:30 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:60054 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231587AbhIJHk1 (ORCPT ); Fri, 10 Sep 2021 03:40:27 -0400 Received: from smtpclient.apple (p5b3d2185.dip0.t-ipconnect.de [91.61.33.133]) by mail.holtmann.org (Postfix) with ESMTPSA id 0A876CED3D; Fri, 10 Sep 2021 09:39:15 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: [PATCH] Bluetooth: hci: fix GPF in h5_recv From: Marcel Holtmann In-Reply-To: <20210902202756.25378-1-paskripkin@gmail.com> Date: Fri, 10 Sep 2021 09:39:14 +0200 Cc: Johan Hedberg , Luiz Augusto von Dentz , apusaka@chromium.org, abhishekpandit@chromium.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+7d41312fe3f123a6f605@syzkaller.appspotmail.com Content-Transfer-Encoding: 8BIT Message-Id: References: <20210902202756.25378-1-paskripkin@gmail.com> To: Pavel Skripkin X-Mailer: Apple Mail (2.3654.120.0.1.13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, > Syzbot hit general protection fault in h5_recv(). The problem was in > missing NULL check. > > hu->serdev can be NULL and we cannot blindly pass &serdev->dev > somewhere, since it can cause GPF. > > Fixes: d9dd833cf6d2 ("Bluetooth: hci_h5: Add runtime suspend") > Reported-and-tested-by: syzbot+7d41312fe3f123a6f605@syzkaller.appspotmail.com > Signed-off-by: Pavel Skripkin > --- > drivers/bluetooth/hci_h5.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel