From: hayeswang <hayeswang@realtek.com>
To: "'Francois Romieu'" <romieu@fr.zoreil.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next 2/6] r8169: modify the flow hw reset
Date: Wed, 6 Jul 2011 15:48:51 +0800 [thread overview]
Message-ID: <EF32BED7323642F29CF5AA3EA7048C78@realtek.com.tw> (raw)
In-Reply-To: <20110705185515.GB5105@electric-eye.fr.zoreil.com>
> -----Original Message-----
> From: Francois Romieu [mailto:romieu@fr.zoreil.com]
> Sent: Wednesday, July 06, 2011 2:55 AM
> To: Hayeswang
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 2/6] r8169: modify the flow hw reset
>
> >
> > +static void rtl_rx_close(struct rtl8169_private *tp) {
> > + void __iomem *ioaddr = tp->mmio_addr;
> > + u32 rxcfg = RTL_R32(RxConfig);
> > +
> > + rxcfg &= ~(AcceptBroadcast | AcceptMulticast |
> > + AcceptMyPhys | AcceptAllPhys);
> > + RTL_W32(RxConfig, rxcfg);
> > +}
> > +
>
> Should not error and runt packets be considered too ?
>
> <shot in the dark>
> Is there any relationship with commit
> ca52efd5490f97f396d3c5863ba714624f272033 ?
> </shot in the dark>
>
No, there is no relationship about that.
next prev parent reply other threads:[~2011-07-06 7:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 9:44 [PATCH net-next 1/6] r8169: adjust some registers Hayes Wang
2011-07-05 9:44 ` [PATCH net-next 2/6] r8169: modify the flow hw reset Hayes Wang
2011-07-05 18:55 ` Francois Romieu
2011-07-06 7:48 ` hayeswang [this message]
2011-07-05 9:44 ` [PATCH net-next 3/6] r8169: adjust the settings about RxConfig Hayes Wang
2011-07-05 18:55 ` Francois Romieu
2011-07-05 9:44 ` [PATCH net-next 4/6] r8169: add ERI functions Hayes Wang
2011-07-05 18:55 ` Francois Romieu
2011-07-05 9:44 ` [PATCH net-next 5/6] r8169: fix wake on lan setting for 8111E Hayes Wang
2011-07-05 18:55 ` Francois Romieu
2011-07-05 9:44 ` [PATCH net-next 6/6] r8169: support RTL8111E-VL Hayes Wang
2011-07-05 18:56 ` Francois Romieu
2011-07-05 18:53 ` [PATCH net-next 1/6] r8169: adjust some registers Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EF32BED7323642F29CF5AA3EA7048C78@realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.