From: Singh, Krishneil K <krishneil.k.singh@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/4] fm10k: fix possible null pointer deref after kcalloc
Date: Tue, 31 May 2016 18:11:47 +0000 [thread overview]
Message-ID: <EF50CC0C76A53A44BAD798C58E0A157E2738EBCA@ORSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <1460042483-16169-1-git-send-email-jacob.e.keller@intel.com>
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Jacob Keller
Sent: Thursday, April 7, 2016 8:21 AM
To: Intel Wired LAN <intel-wired-lan@lists.osuosl.org>
Subject: [Intel-wired-lan] [PATCH v1 1/4] fm10k: fix possible null pointer deref after kcalloc
When writing a new default redirection table, we needed to populate a new RSS table using ethtool_rxfh_indir_default. We populated this table into a region of memory allocated using kcalloc, but never checked this for NULL. Fix this by moving the default table generation into fm10k_write_reta. If this function is passed a table, use it. Otherwise, generate the default table using ethtool_rxfh_indir_default, 4 at at time.
Fixes: 0ea7fae44094 ("fm10k: use ethtool_rxfh_indir_default for default redirection table", 2016-02-16)
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
prev parent reply other threads:[~2016-05-31 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 15:21 [Intel-wired-lan] [PATCH v1 1/4] fm10k: fix possible null pointer deref after kcalloc Jacob Keller
2016-04-07 15:21 ` [Intel-wired-lan] [PATCH v1 2/4] fm10k: consistently use Intel(R) for driver names Jacob Keller
2016-04-13 22:41 ` Singh, Krishneil K
2016-04-07 15:21 ` [Intel-wired-lan] [PATCH v1 3/4] fm10k: fix fm10k_add_ethtool_stats to zero memory Jacob Keller
2016-04-13 22:42 ` Singh, Krishneil K
2016-04-07 15:21 ` [Intel-wired-lan] [PATCH v1 4/4] fm10k: fix incorrect IPv6 extended header checksum Jacob Keller
2016-04-15 22:20 ` [Intel-wired-lan] [PATCH v1 1/4] fm10k: fix possible null pointer deref after kcalloc Keller, Jacob E
2016-05-31 18:11 ` Singh, Krishneil K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EF50CC0C76A53A44BAD798C58E0A157E2738EBCA@ORSMSX103.amr.corp.intel.com \
--to=krishneil.k.singh@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.