From: Singh, Krishneil K <krishneil.k.singh@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 4/6] fm10k: use macro to avoid passing the array and size separately
Date: Tue, 1 May 2018 21:24:59 +0000 [thread overview]
Message-ID: <EF50CC0C76A53A44BAD798C58E0A157E8294D503@ORSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20180412181559.4343-4-jacob.e.keller@intel.com>
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of
> Jacob Keller
> Sent: Thursday, April 12, 2018 11:16 AM
> To: Intel Wired LAN <intel-wired-lan@lists.osuosl.org>
> Subject: [Intel-wired-lan] [PATCH 4/6] fm10k: use macro to avoid passing the
> array and size separately
>
> Avoid potential bugs with fm10k_add_stat_strings and
> fm10k_add_ethtool_stats by using a macro to calculate the ARRAY_SIZE
> when passing. This helps ensure that the size is always correct.
>
> Note that it assumes we only pass static const fm10k_stat arrays, and
> that evaluation of the argument won't have side effects.
>
> Change-Id: Id9396eef12cbab51a2559db80782e33fb20df274
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Title: use macro to avoid passing the array and size separately
> Change-type: ImplementationChange
> Reviewed-on: https://git-amr-1.devtools.intel.com/gerrit/198023
> ---
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
next prev parent reply other threads:[~2018-05-01 21:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 18:15 [Intel-wired-lan] [PATCH 1/6] fm10k: setup VLANs for l2 accelerated macvlan interfaces Jacob Keller
2018-04-12 18:15 ` [Intel-wired-lan] [PATCH 2/6] fm10k: reduce duplicate fm10k_stat macro code Jacob Keller
2018-05-01 21:23 ` Singh, Krishneil K
2018-04-12 18:15 ` [Intel-wired-lan] [PATCH 3/6] fm10k: use variadic arguments to fm10k_add_stat_strings Jacob Keller
2018-05-01 21:24 ` Singh, Krishneil K
2018-04-12 18:15 ` [Intel-wired-lan] [PATCH 4/6] fm10k: use macro to avoid passing the array and size separately Jacob Keller
2018-05-01 21:24 ` Singh, Krishneil K [this message]
2018-04-12 18:15 ` [Intel-wired-lan] [PATCH 5/6] fm10k: warn if the stat size is unknown Jacob Keller
2018-05-01 21:25 ` Singh, Krishneil K
2018-04-12 18:15 ` [Intel-wired-lan] [PATCH 6/6] fm10k: don't protect fm10k_queue_mac_request by fm10k_host_mbx_ready Jacob Keller
2018-05-01 21:25 ` Singh, Krishneil K
2018-05-01 21:23 ` [Intel-wired-lan] [PATCH 1/6] fm10k: setup VLANs for l2 accelerated macvlan interfaces Singh, Krishneil K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EF50CC0C76A53A44BAD798C58E0A157E8294D503@ORSMSX103.amr.corp.intel.com \
--to=krishneil.k.singh@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.