From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blu0x-00028x-Oz for qemu-devel@nongnu.org; Mon, 19 Sep 2016 04:33:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blu0s-00072m-Ir for qemu-devel@nongnu.org; Mon, 19 Sep 2016 04:33:22 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:35042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blu0s-00072h-DS for qemu-devel@nongnu.org; Mon, 19 Sep 2016 04:33:18 -0400 From: Aleksandar Markovic Date: Mon, 19 Sep 2016 08:32:53 +0000 Message-ID: References: <20160916111422.109959-1-aleksandar.markovic@rt-rk.com> <20160916111422.109959-5-aleksandar.markovic@rt-rk.com>, <1348276b-5a06-2165-70f8-c390875a70fa@vivier.eu> In-Reply-To: <1348276b-5a06-2165-70f8-c390875a70fa@vivier.eu> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v6 4/7] linux-user: Fix structure target_semid64_ds definition for Mips List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , Aleksandar Markovic , "qemu-devel@nongnu.org" , "riku.voipio@iki.fi" , "peter.maydell@linaro.org" , "aurelien@aurel32.net" , Leon Alrae , Petar Jovanovic , Miodrag Dinic , Aleksandar Rikalo The naming in this patch will be synced with that from the kernel in v7. Th= anks!=0A= =0A= ________________________________________=0A= From: Laurent Vivier [laurent@vivier.eu]=0A= Sent: Friday, September 16, 2016 12:00 PM=0A= To: Aleksandar Markovic; qemu-devel@nongnu.org; riku.voipio@iki.fi; peter.m= aydell@linaro.org; aurelien@aurel32.net; Leon Alrae; Petar Jovanovic; Miodr= ag Dinic; Aleksandar Rikalo; Aleksandar Markovic=0A= Subject: Re: [Qemu-devel] [PATCH v6 4/7] linux-user: Fix structure target_s= emid64_ds definition for Mips=0A= =0A= Le 16/09/2016 =E0 13:14, Aleksandar Markovic a =E9crit :=0A= > From: Aleksandar Markovic =0A= >=0A= > This patch corrects target_semid64_ds structure definition for Mips.=0A= >=0A= > See, for example definition of semid64_ds for Mips in Linux kernel:=0A= > arch/mips/include/uapi/asm/sembuf.h#L13.=0A= >=0A= > This patch will also fix certain semaphore-related LTP tests for Mips,=0A= > if they are executed in Qemu user mode for any Mips platform.=0A= >=0A= > Signed-off-by: Miodrag Dinic =0A= > Signed-off-by: Aleksandar Markovic =0A= > Reviewed-by: Peter Maydell =0A= > ---=0A= > linux-user/mips/target_structs.h | 16 ++++++++++++++++=0A= > 1 file changed, 16 insertions(+)=0A= >=0A= > diff --git a/linux-user/mips/target_structs.h b/linux-user/mips/target_st= ructs.h=0A= > index fbd9955..5ba124d 100644=0A= > --- a/linux-user/mips/target_structs.h=0A= > +++ b/linux-user/mips/target_structs.h=0A= > @@ -45,4 +45,20 @@ struct target_shmid_ds {=0A= > abi_ulong __unused2;=0A= > };=0A= >=0A= > +#define TARGET_SEMID64_DS=0A= > +=0A= > +/*=0A= > + * The semid64_ds structure for the MIPS architecture.=0A= > + * Note extra padding because this structure is passed back and forth=0A= > + * between kernel and user space.=0A= > + */=0A= > +struct target_semid64_ds {=0A= > + struct target_ipc_perm sem_perm;=0A= > + abi_ulong sem_otime;=0A= > + abi_ulong sem_ctime;=0A= > + abi_ulong sem_nsems;=0A= > + abi_ulong __unused3;=0A= > + abi_ulong __unused4;=0A= > +};=0A= =0A= Perhaps you can call them __unused1 and __unused2, like they are in the=0A= kernel?=0A= =0A= Anyway:=0A= =0A= Reviewed-by: Laurent Vivier =0A= =0A= Laurent=0A=