From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liran Alon Subject: Re: [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state Date: Mon, 8 Oct 2018 20:21:40 +0300 Message-ID: References: <20180916124631.39016-1-liran.alon@oracle.com> Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mtosatti@redhat.com, Paolo Bonzini , rth@twiddle.net, jmattson@google.com To: qemu-devel@nongnu.org Return-path: In-Reply-To: <20180916124631.39016-1-liran.alon@oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org Gentle ping on v2 of this series. (I noticed 1st patch of series was already applied) Thanks, -Liran > On 16 Sep 2018, at 15:46, Liran Alon wrote: >=20 > Hi, >=20 > This series aims to add support for QEMU to be able to migrate VMs = that > are running nested hypervisors. In order to do so, it utilizes the new > IOCTLs introduced in KVM commit 8fcc4b5923af ("kvm: nVMX: Introduce > KVM_CAP_NESTED_STATE") which were created for this purpose. >=20 > 1st patch is not really related to the goal of the patch series. It = just > makes CPUX86State->xsave_buf to be compiled only when needed (When > compiling with KVM or HVF CPU accelerator). >=20 > 2nd patch adds the support to migrate VMs that are running nested > hypervisors. >=20 > Regards, > -Liran >=20 > v1->v2 Changes: > * Renamed kvm_nested_state_length() to kvm_max_nested_state_length() > to better indicate it represents the max nested state size that can > be returned from kernel. > * Added error_report() calls to nested_state_post_load() to make > failures in migration easier to diagnose. > * Fixed support of migrating with various nested_state buffer sizes. > The following scenarios were tested: > (a) src and dest have same nested state size. > =3D=3D> Migration succeeds. > (b) src don't have nested state while dest do. > =3D=3D> Migration succeed and src don't send it's nested state. > (c) src have nested state while dest don't. > =3D=3D> Migration fails as it cannot restore nested state. > (d) dest have bigger max nested state size than src > =3D=3D> Migration succeeds. > (e) dest have smaller max nested state size than src but enough to = store it's saved nested state > =3D=3D> Migration succeeds > (f) dest have smaller max nested state size than src but not enough to = store it's saved nested state > =3D=3D> Migration fails >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9ZEH-0003iM-Rc for qemu-devel@nongnu.org; Mon, 08 Oct 2018 13:22:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9ZED-0000ef-V0 for qemu-devel@nongnu.org; Mon, 08 Oct 2018 13:22:01 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:58048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9ZEC-0000d2-0V for qemu-devel@nongnu.org; Mon, 08 Oct 2018 13:21:57 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\)) From: Liran Alon In-Reply-To: <20180916124631.39016-1-liran.alon@oracle.com> Date: Mon, 8 Oct 2018 20:21:40 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20180916124631.39016-1-liran.alon@oracle.com> Subject: Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , mtosatti@redhat.com, rth@twiddle.net, ehabkost@redhat.com, kvm@vger.kernel.org, jmattson@google.com Gentle ping on v2 of this series. (I noticed 1st patch of series was already applied) Thanks, -Liran > On 16 Sep 2018, at 15:46, Liran Alon wrote: >=20 > Hi, >=20 > This series aims to add support for QEMU to be able to migrate VMs = that > are running nested hypervisors. In order to do so, it utilizes the new > IOCTLs introduced in KVM commit 8fcc4b5923af ("kvm: nVMX: Introduce > KVM_CAP_NESTED_STATE") which were created for this purpose. >=20 > 1st patch is not really related to the goal of the patch series. It = just > makes CPUX86State->xsave_buf to be compiled only when needed (When > compiling with KVM or HVF CPU accelerator). >=20 > 2nd patch adds the support to migrate VMs that are running nested > hypervisors. >=20 > Regards, > -Liran >=20 > v1->v2 Changes: > * Renamed kvm_nested_state_length() to kvm_max_nested_state_length() > to better indicate it represents the max nested state size that can > be returned from kernel. > * Added error_report() calls to nested_state_post_load() to make > failures in migration easier to diagnose. > * Fixed support of migrating with various nested_state buffer sizes. > The following scenarios were tested: > (a) src and dest have same nested state size. > =3D=3D> Migration succeeds. > (b) src don't have nested state while dest do. > =3D=3D> Migration succeed and src don't send it's nested state. > (c) src have nested state while dest don't. > =3D=3D> Migration fails as it cannot restore nested state. > (d) dest have bigger max nested state size than src > =3D=3D> Migration succeeds. > (e) dest have smaller max nested state size than src but enough to = store it's saved nested state > =3D=3D> Migration succeeds > (f) dest have smaller max nested state size than src but not enough to = store it's saved nested state > =3D=3D> Migration fails >=20