From: Alex Bligh <alex@alex.org.uk>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Alex Bligh <alex@alex.org.uk>
Subject: Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?
Date: Fri, 1 Apr 2016 10:19:37 +0100 [thread overview]
Message-ID: <F0D84915-76C2-4537-9DF6-17E555849270@alex.org.uk> (raw)
In-Reply-To: <56FE26B2.6090903@redhat.com>
On 1 Apr 2016, at 08:43, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 31/03/2016 22:17, Alex Bligh wrote:
>>>> In qemu, read+FUA just triggers blk_co_flush() prior to reading; but
>>>> that's the same function it calls for write+FUA.
>> That's harmless, but unnecessary in the sense that current documented
>> behaviour doesn't require it. Perhaps it should?
>>
>> I suppose TRIM etc. should support FUA too?
>
> TRIM is an advisory operation, so it doesn't make sense to force access
> to the medium.
Reflecting, that's correct. FUA can't mean anything sensible for
TRIM.
--
Alex Bligh
next prev parent reply other threads:[~2016-04-01 9:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 19:33 [Qemu-devel] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH? Eric Blake
2016-03-31 19:41 ` [Qemu-devel] [Nbd] " Alex Bligh
2016-03-31 19:54 ` Eric Blake
2016-03-31 20:17 ` Alex Bligh
2016-03-31 20:34 ` Eric Blake
2016-04-01 7:49 ` Paolo Bonzini
2016-04-01 9:25 ` Alex Bligh
2016-04-01 8:27 ` Wouter Verhelst
2016-04-01 9:40 ` Alex Bligh
2016-04-01 14:16 ` Eric Blake
2016-04-01 15:00 ` Alex Bligh
2016-04-01 15:08 ` Eric Blake
2016-04-01 15:12 ` Alex Bligh
2016-04-01 15:13 ` Alex Bligh
2016-04-01 15:31 ` Eric Blake
2016-04-01 15:46 ` Alex Bligh
2016-05-02 17:08 ` Eric Blake
2016-04-01 7:43 ` Paolo Bonzini
2016-04-01 9:19 ` Alex Bligh [this message]
2016-04-05 5:09 ` Kevin Wolf
2016-04-05 13:28 ` Paolo Bonzini
2016-04-06 13:14 ` Kevin Wolf
2016-04-06 13:28 ` Paolo Bonzini
2016-04-06 13:50 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F0D84915-76C2-4537-9DF6-17E555849270@alex.org.uk \
--to=alex@alex.org.uk \
--cc=nbd-general@lists.sourceforge.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.