From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Sperl Subject: Re: [PATCH 1/2] SPI: control CS via standard GPIO operations instead of SPI-HW Date: Wed, 4 Mar 2015 18:38:14 +0100 Message-ID: References: <1425487205-5477-1-git-send-email-kernel@martin.sperl.org> <54F73A60.9080403@pengutronix.de> Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54F73A60.9080403-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marc Kleine-Budde Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren List-Id: devicetree@vger.kernel.org > > On 04.03.2015, at 18:01, Marc Kleine-Budde wrote: > > You might want to use gpio_is_valid() instead of open coding it. Under ideal circumstances spi_set_cs() would be GPL exported and then I would not have to duplicate the code. And there it is implemented like this, so my code includes it. I just have kept the patch simple - in the long-run we should move that route I assume and fix the code there to use gpio_is_valid(). Martin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html