From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755060AbdKATSp (ORCPT ); Wed, 1 Nov 2017 15:18:45 -0400 Received: from mail-co1nam03on0087.outbound.protection.outlook.com ([104.47.40.87]:39692 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754992AbdKATSn (ORCPT ); Wed, 1 Nov 2017 15:18:43 -0400 From: "Madhani, Himanshu" To: Kees Cook CC: Bart Van Assche , "Martin K. Petersen" , Dept-Eng QLA2xxx Upstream , Linux SCSI Mailinglist , LKML , Thomas Gleixner Subject: Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Topic: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Index: AQHTUnxphvT5wFV2bEGlxCWwLUqo66L/3oqAgAAI8AA= Date: Wed, 1 Nov 2017 19:18:41 +0000 Message-ID: References: <1509477229-62141-1-git-send-email-keescook@chromium.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Himanshu.Madhani@cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR07MB3453;6:jWK0qyAYQASJ3xZf/ILDDojf3a5MtazkGORfTy5nsqcxdsdb1BmGdQkBsUFpHjdk2mgnHYVQCfHy2LKDLIW7Bt5vlnZgOKvpVtcUT40KSrsCqISrL+eTyKQlXlyWrLqBLp+kdMzaXgKsJe0NoXOtkvWdsG7SIqxTEGhImjk+FWZiNbxlSF5qP1gNQA8G9y4msU5JEUTCkti8M5ZuTttc0BYuneYKW5ezyIFW4HzybHuth3SG3WtegiWpcr7w0ETU/ydbGKU3p671KZRuh25FXqh1SLF2IKBM1kbZKIAFauNXVsUECgQMmPq04F0AEwddBWpOnw6N9WWSYsU/lXPsWoWOvObM2KGOCwGB15IbW1A=;5:vPDO8vuTaNggAolKYQFtS4MfkOYYrh7wd2byfUvvOuNV4CNxO6+v4zpcL3rJq+2qwBbtFYVbXrL8t+AT4mMRVgPqhnHLXWSSWvuWwedqV0WoP8ce3IJDDXffbj9eBqnHKNfjGQt/G/LBx0T1ueUlz5+KNcP/CMvVwcDdWpeglaw=;24:J3GCxPae4jPRMM5PudxZI1XHQlHZrDc2WFQeqIEis1rm1EpBCM3v8G/zqcOn3gV68RH89N431/ROfEzZN0dHYUQwVeQxbjV/uGXy3zAYK+8=;7:g1wxghIVE4RSujY0FflPez2G5hGa6GumKGgOKsxvaDVJ88WPVHKApTUmnsMPW+s8zi0o+TzRwoJclCcS3PLYUgZ5/y620N76ZZPjUwtxNiwBS73pMXDkyeDrOO1uyHuOL0d41soNvlEjFzdtOOD6UZ+aeNSkBxEZYsH3F9b4/leFpXoKZaDa3hRZCrcgax27CwsKVMcDIRjZCpHXPZZbb4dTII51E3RYm28jDsAmDFL30BFUv4j+X3iPrMzCvQ4A x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: e0f5a374-1a88-4f20-2ea4-08d5215d5ca1 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603199);SRVR:MWHPR07MB3453; x-ms-traffictypediagnostic: MWHPR07MB3453: x-exchange-antispam-report-test: UriScan:(192374486261705); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231020)(3002001)(100000703101)(100105400095)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3453;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3453; x-forefront-prvs: 0478C23FE0 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(24454002)(189002)(199003)(478600001)(6116002)(5660300001)(66066001)(6916009)(6246003)(81166006)(8676002)(81156014)(14454004)(2950100002)(106356001)(105586002)(2906002)(305945005)(68736007)(25786009)(99286004)(53546010)(77096006)(6486002)(72206003)(229853002)(8936002)(33656002)(36756003)(3660700001)(189998001)(97736004)(6506006)(2900100001)(6436002)(102836003)(53936002)(4326008)(7736002)(6512007)(3280700002)(83716003)(101416001)(50986999)(86362001)(54356999)(316002)(3846002)(76176999)(82746002)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3453;H:MWHPR07MB3455.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <8593F4F713F2874F852E16144C8E016E@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0f5a374-1a88-4f20-2ea4-08d5215d5ca1 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2017 19:18:41.1129 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3453 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA1JIsfK023773 Hi Kees, > On Nov 1, 2017, at 11:46 AM, Kees Cook wrote: > > On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook wrote: >> This breaks out the logical steps to convert the qla2xxx timers: >> >> 1) init_timer() -> setup_timer() >> 2) refactor qla2x00_start_timer() to not pass callback as argument >> 3) qla2x00_timer() to use timer_setup() >> 4) qla2x00_sp_timeout() to use timer_setup() >> >> The resulting diff is identical to the patch that appears to lock up >> the driver. This should help identify which step causes this behavior. > > Hi, just curious if there's been any progress on debugging the issue > you saw with this series? > Sorry for delay. I will test this series later today and post update. > Thanks! > > -Kees > > -- > Kees Cook > Pixel Security Thanks, - Himanshu