All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ibarra Lopez, Humberto" <humberto.ibarra.lopez@intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	Alexander Kanavin <alexander.kanavin@linux.intel.com>,
	"Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/3] rpm: add support for remote package feeds via PACKAGE_FEED_URIS variable
Date: Wed, 15 Mar 2017 17:10:10 +0000	[thread overview]
Message-ID: <F187383F84EB304A88D055C3049588791BCF0B43@FMSMSX106.amr.corp.intel.com> (raw)
In-Reply-To: <1489594104.13980.67.camel@linuxfoundation.org>

Yeah, it does sound off but we could use it. We could put a mock value in the ip to the PACKAGE_FEED_URIS var to build this image and once it boths update that value with the real one. We would have to check that the mock value was correctly set before updating so we can test the var being correctly set; and then check that the feeds are updated correctly once a valid ip is there. I will look into this.

Humberto

-----Original Message-----
From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org] 
Sent: Wednesday, March 15, 2017 10:08 AM
To: Ibarra Lopez, Humberto <humberto.ibarra.lopez@intel.com>; Alexander Kanavin <alexander.kanavin@linux.intel.com>; Burton, Ross <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/3] rpm: add support for remote package feeds via PACKAGE_FEED_URIS variable

On Wed, 2017-03-15 at 15:38 +0000, Ibarra Lopez, Humberto wrote:
> Sorry, missed the previous mail.
> 
> I am not sure how to improve the hardcoding there, I don't like it 
> either, but couldn't find an alternative. The thing is that we need 
> the ip of the host as seen from the target to run testimage, but we 
> don’t have the exact value for that one until qemu is up. The issue 
> here is that we need to give this ip to the conf in the 
> PACKAGE_FEED_URIS before building so we can get an image with this var 
> to later use in testimage.
> 
> If someone has a better idea to get rid of this hardcoding, it would 
> be great to know.

We could run a sed command inside the image after it boots but before triggering the tests to put the correct IP/port number into the file?

Not a perfect test but simple and probably good enough for this?

Cheers,

Richard

      reply	other threads:[~2017-03-15 17:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14 17:27 [PATCH 1/3] rpm: add support for remote package feeds via PACKAGE_FEED_URIS variable Alexander Kanavin
2017-03-14 17:27 ` [PATCH 2/3] lib/oe/package_manager: import rpm signing key to rpmdb Alexander Kanavin
2017-03-14 17:27 ` [PATCH 3/3] selftest/signing.py: verify that images can be created from signed packages Alexander Kanavin
2017-03-15 11:13 ` [PATCH 1/3] rpm: add support for remote package feeds via PACKAGE_FEED_URIS variable Burton, Ross
2017-03-15 11:19   ` Alexander Kanavin
2017-03-15 12:44     ` Patrick Ohly
2017-03-15 15:38     ` Ibarra Lopez, Humberto
2017-03-15 16:08       ` Richard Purdie
2017-03-15 17:10         ` Ibarra Lopez, Humberto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F187383F84EB304A88D055C3049588791BCF0B43@FMSMSX106.amr.corp.intel.com \
    --to=humberto.ibarra.lopez@intel.com \
    --cc=alexander.kanavin@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.