> Am 09.07.2020 um 07:37 schrieb Jacob Kroon : > > On 7/9/20 7:30 AM, Jens Rehsack wrote: >>> Am 08.07.2020 um 13:09 schrieb Konrad Weihmann : >>> >>> remove the traling blanks before the ;-delimiter, so one could use >> ^ >> here & subject: do you mean "trailing"? >>> "_remove" to avoid running tasks like 'rootfs_update_timestamp', >>> which are currently hardcoded and not bound to any >>> configurable feature flag >>> >>> Signed-off-by: Konrad Weihmann >>> --- >>> meta/classes/rootfs-postcommands.bbclass | 6 +++--- >>> meta/classes/rootfsdebugfiles.bbclass | 2 +- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/meta/classes/rootfs-postcommands.bbclass b/meta/classes/rootfs-postcommands.bbclass >>> index c43b9a9823..984730ebe8 100644 >>> --- a/meta/classes/rootfs-postcommands.bbclass >>> +++ b/meta/classes/rootfs-postcommands.bbclass >>> @@ -1,6 +1,6 @@ >>> >>> # Zap the root password if debug-tweaks feature is not enabled >>> -ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 'empty-root-password' ], "", "zap_empty_root_password ; ",d)}' >>> +ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 'empty-root-password' ], "", "zap_empty_root_password; ",d)}' >>> >>> # Allow dropbear/openssh to accept logins from accounts with an empty password string if debug-tweaks or allow-empty-password is enabled >>> ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 'allow-empty-password' ], "ssh_allow_empty_password; ", "",d)}' >>> @@ -12,7 +12,7 @@ ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'deb >>> ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 'post-install-logging' ], "postinst_enable_logging; ", "",d)}' >>> >>> # Create /etc/timestamp during image construction to give a reasonably sane default time setting >>> -ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; " >>> +ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp; " >> How about >> +ROOTFS_POSTPROCESS_COMMAND += " rootfs_update_timestamp;" >> Reading a list is much easier when words are separated by whitespaces. > > The += and =+ operators already insert a space between the concatenations. > > https://www.yoctoproject.org/docs/latest/bitbake-user-manual/bitbake-user-manual.html#appending-and-prepending > > Jacob I always become confused since often I have to use _append etc. (to avoid hitting ?=) - thanks for pointing that out. Cheers -- Jens Rehsack - rehsack@gmail.com