From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wei, Gang" Subject: RE: [PATCH] x86: suppress HPET broadcast initialization in the presence of ARAT Date: Sat, 12 Feb 2011 16:46:46 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , Jan Beulich , "xen-devel@lists.xensource.com" Cc: "Wei, Gang" List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote on=A02011-02-12: > On 12/02/2011 07:15, "Wei, Gang" wrote: >> Jan Beulich wrote on=A02011-02-10: >>> This follows Linux commit 39fe05e58c5e448601ce46e6b03900d5bf31c4b0, >>> noticing that all this setup is pointless when ARAT support is >>> there, and knowing that on SLED11's native kernel it has actually >>> caused S3 resume issues. >>=20 >> Although this patch was already checked in, I still have to say it >> is not necessary for Xen. Because hpet_broadcast_init() fn is only >> called if (xen_cpuidle && !boot_cpu_has(X86_FEATURE_ARAT)) in >> disable_pit_irq(). Of course I agree to keep it as a never used double c= heck. >=20 > Hmm I didn't spot that. Actually it is part of a more complex series > of checks in the caller, so I wonder whether repeating just that one > check in the function itself really makes much sense. I'm somewhat inclib= ned to revert it. Revert it would be better. Jimmy