From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiInm-0002cW-DD for qemu-devel@nongnu.org; Wed, 15 Apr 2015 04:36:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiInh-0005fv-D9 for qemu-devel@nongnu.org; Wed, 15 Apr 2015 04:36:06 -0400 Received: from mga11.intel.com ([192.55.52.93]:3093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiInh-0005fh-8I for qemu-devel@nongnu.org; Wed, 15 Apr 2015 04:36:01 -0400 From: "Li, Liang Z" Date: Wed, 15 Apr 2015 08:35:54 +0000 Message-ID: References: <1428474011-30797-1-git-send-email-liang.z.li@intel.com> <1428474011-30797-13-git-send-email-liang.z.li@intel.com> <552D0224.7060001@redhat.com> <871tjlhks2.fsf@neno.neno> In-Reply-To: <871tjlhks2.fsf@neno.neno> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "quintela@redhat.com" , Eric Blake Cc: "qemu-devel@nongnu.org" , "armbru@redhat.com" , "lcapitulino@redhat.com" , "amit.shah@redhat.com" , "Zhang, Yang Z" , "dgilbert@redhat.com" > Eric Blake wrote: > > On 04/08/2015 12:20 AM, Liang Li wrote: > >> Put the three parameters related to multiple thread (de)compression > >> into an int array, and use an enum type to index the parameter. > >> > >> Signed-off-by: Liang Li > >> Signed-off-by: Yang Zhang > >> --- > >> include/migration/migration.h | 4 +--- > >> migration/migration.c | 31 +++++++++++++++++++------------ > >> qapi-schema.json | 23 +++++++++++++++++++++++ > >> 3 files changed, 43 insertions(+), 15 deletions(-) > >> > > > >> +++ b/qapi-schema.json > >> @@ -569,6 +569,29 @@ > >> ## > >> { 'command': 'query-migrate-capabilities', 'returns': > ['MigrationCapabilityStatus']} > >> > >> +# @MigrationParameter > >> +# > >> +# Migration parameters enumeration > >> +# > >> +# @compress-level: Set the compression level to be used in live > migration, > >> +# the compression level is an integer between 0 and 9, where= 0 > means > >> +# no compression, 1 means the best compression speed, and 9 > means best > >> +# compression ratio which will consume more CPU. > >> +# > >> +# @compress-threads: Set compression thread count to be used in live > migration, > >> +# the compression thread count is an integer between 1 and 2= 55. > >> +# > >> +# @decompress-threads: Set decompression thread count to be used in > live > >> +# migration, the decompression thread count is an integer be= tween > 1 > >> +# and 255. Usually, decompression is at least 4 times as fas= t as > >> +# compression, so set the decompress-threads to the number > about 1/4 > >> +# of compress-threads is adequate. > > > > s/so set/so setting/ > > > >> +# > >> +# Since: 2.3 > > > > 2.4 > > > > Maintainer can fix if a respin is not needed. >=20 > Liang, I will fix the s/2.3/2.4/ while merging, no need of respin for thi= s. >=20 > Later, Juan. OK, the v8 is very soon. Liang