From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 326F8C433DB for ; Tue, 12 Jan 2021 22:31:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7DEB23122 for ; Tue, 12 Jan 2021 22:31:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732727AbhALWao (ORCPT ); Tue, 12 Jan 2021 17:30:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727908AbhALWaf (ORCPT ); Tue, 12 Jan 2021 17:30:35 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AAF6C061786; Tue, 12 Jan 2021 14:29:55 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id q4so2215333plr.7; Tue, 12 Jan 2021 14:29:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Y/mkD5de8m+mpayBIjRORwwldrvzEhn8Mi4jJftRcDI=; b=oyY3aNW7Pxb69vz+utmtcU2GPYOyJ5SqNAKAGKIP+laTePuc60PlelsK58yw4wUUf0 vWjJOEysHeU7IHh/rBzXBPENyRO9f3bUhDjNmSpAYEVpCygIR53iaVWtBfeZlaPPjvqe X4vYUEQ/fMIUh4e4y6FxOmwJXrmI75HrmpiNK+mlBem0QnasUc2Nt3i2O/vaO5K71Y++ ziIXBzxFcbNLl9OIcmaNhr9zsF3zckpj4QliylL8hPGfzwyXmUcq9jehHNIkoyS2aDGS IqiUWiOhhNveeQCjbYSituV2lfZeFWnnYpFZXZA1Cn1+xlnlImCjEywAw9PGsvLi1/nj Rt7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Y/mkD5de8m+mpayBIjRORwwldrvzEhn8Mi4jJftRcDI=; b=Igvqyio71+VuAUChmHvyX3DIQfNOpUSOp6yRuOn+Unawk07V7ybtEHEDUlRBxkfezn BZCQEW3EDBuH/k1n/7qaYZxGfPZp5dVmArQiGRvjhIpagxQ5j2PtFwf1KB+vOnYXemqH j4QiZHabpLDoHR3gxcvg/GRNKIVysgzVTsNdjZygQs4izM4SGXL9xq4LbKI5umR45MAK 5DdKRNKGtSQESGUG8HDV9NO8oLdNPd13yyInnoxhxjRVUZLcLOde+8WKU4eTphyCo8sT SXCEx6xfHKQRD+2urZBr5JYMEEz6D7tp75pVeK/yS4iV+KLjRnWg6lO6CmsVIL2m9i9+ PNYg== X-Gm-Message-State: AOAM530NG/0VWPDDjWDfVdvY5zaS5nJ3usEGW+BVa/cgcBbtj5eqMZQs 4q2JlGsoHo0QOpLF05siXcM= X-Google-Smtp-Source: ABdhPJwpwMojoG1gozfbdfaGyrRQLqLKWPh3Cerp91arRFH/VdZndTffb9MzyH9D6diub2eZ4EAqBQ== X-Received: by 2002:a17:902:bcc6:b029:dc:44a5:c363 with SMTP id o6-20020a170902bcc6b02900dc44a5c363mr1515847pls.5.1610490594619; Tue, 12 Jan 2021 14:29:54 -0800 (PST) Received: from [192.168.88.245] (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id v10sm32697pjr.47.2021.01.12.14.29.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jan 2021 14:29:53 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect From: Nadav Amit In-Reply-To: <20210112214337.GA10434@willie-the-truck> Date: Tue, 12 Jan 2021 14:29:51 -0800 Cc: Yu Zhao , Laurent Dufour , Peter Zijlstra , Vinayak Menon , Linus Torvalds , Andy Lutomirski , Peter Xu , Andrea Arcangeli , linux-mm , lkml , Pavel Emelyanov , Mike Kravetz , Mike Rapoport , stable , Minchan Kim , surenb@google.com Content-Transfer-Encoding: 7bit Message-Id: References: <20210105153727.GK3040@hirez.programming.kicks-ass.net> <0201238b-e716-2a3c-e9ea-d5294ff77525@linux.vnet.ibm.com> <2C7AE23B-ACA3-4D55-A907-AF781C5608F0@gmail.com> <20210112214337.GA10434@willie-the-truck> To: Will Deacon X-Mailer: Apple Mail (2.3608.120.23.2.4) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jan 12, 2021, at 1:43 PM, Will Deacon wrote: > > On Tue, Jan 12, 2021 at 12:38:34PM -0800, Nadav Amit wrote: >>> On Jan 12, 2021, at 11:56 AM, Yu Zhao wrote: >>> On Tue, Jan 12, 2021 at 11:15:43AM -0800, Nadav Amit wrote: >>>> I will send an RFC soon for per-table deferred TLB flushes tracking. >>>> The basic idea is to save a generation in the page-struct that tracks >>>> when deferred PTE change took place, and track whenever a TLB flush >>>> completed. In addition, other users - such as mprotect - would use >>>> the tlb_gather interface. >>>> >>>> Unfortunately, due to limited space in page-struct this would only >>>> be possible for 64-bit (and my implementation is only for x86-64). >>> >>> I don't want to discourage you but I don't think this would end up >>> well. PPC doesn't necessarily follow one-page-struct-per-table rule, >>> and I've run into problems with this before while trying to do >>> something similar. >> >> Discourage, discourage. Better now than later. >> >> It will be relatively easy to extend the scheme to be per-VMA instead of >> per-table for architectures that prefer it this way. It does require >> TLB-generation tracking though, which Andy only implemented for x86, so I >> will focus on x86-64 right now. > > Can you remind me of what we're missing on arm64 in this area, please? I'm > happy to help get this up and running once you have something I can build > on. Let me first finish making something that we can use as a basis for a discussion. I do not waste your time before I have something ready.