From mboxrd@z Thu Jan 1 00:00:00 1970 From: "S, Deepak" Subject: Re: [PATCH] drm/i915: add cherryview specfic forcewake in execlists_elsp_write Date: Wed, 10 Sep 2014 16:38:54 +0000 Message-ID: References: <1410270256-26413-1-git-send-email-deepak.s@linux.intel.com> <20140908140243.GZ4193@intel.com> <20140908141423.GA4193@intel.com> <20140908144032.GC15520@phenom.ffwll.local> <540F278C.7070407@intel.com> <20140909142550.124035ff@jbarnes-t420> <20140910071645.GP15520@phenom.ffwll.local> <20140910154739.GU15520@phenom.ffwll.local> <20140910155116.GD31074@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 714E46E23D for ; Wed, 10 Sep 2014 09:38:59 -0700 (PDT) In-Reply-To: <20140910155116.GD31074@nuc-i3427.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org Hmm Ok Daniel. Let me try and clean up the forcewake. :) Chris, most of the debugfs is already covered with runtime_get/put. If anything is missed we can add that Thanks Deepak -----Original Message----- From: Chris Wilson [mailto:chris@chris-wilson.co.uk] Sent: Wednesday, September 10, 2014 9:21 PM To: Daniel Vetter Cc: Jesse Barnes; S, Deepak; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: add cherryview specfic forcewake in execlists_elsp_write On Wed, Sep 10, 2014 at 05:47:39PM +0200, Daniel Vetter wrote: > Aside if someone gets bored and wants to apply some polish: And __ > variant of force_wake_get/put which only asserts that the device isn't > runtime suspended instead of doing the runtime_pm_get/put would be > cute - we have one other user in the hsw/bdw rpm code already. > > The current force_wake_get/put functions would then just wrap those > raw versions. I fail to see the reason why they take it at all. Conceptually, gen6_gt_force_wake_get() is just as lowlevel as the register access they wrap. The only one that breaks the rule is i915_debugfs.c and that seems easy enough to wrap with its own intel_runtime_pm_get/_put. And once you've finish with that you can then sort out the mess that is the vlv variants. And now skl continues in the cut'n'paste'n'paste vein. -Chris -- Chris Wilson, Intel Open Source Technology Centre