From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Helin" Subject: Re: [PATCH v2 1/6] ixgbe: Code cleanup Date: Wed, 24 Dec 2014 03:41:04 +0000 Message-ID: References: <1418612225-6095-1-git-send-email-changchun.ouyang@intel.com> <1419389808-9559-1-git-send-email-changchun.ouyang@intel.com> <1419389808-9559-2-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Ouyang, Changchun" Return-path: In-Reply-To: Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Changchun > -----Original Message----- > From: Ouyang, Changchun > Sent: Wednesday, December 24, 2014 11:22 AM > To: Zhang, Helin; dev-VfR2kkLFssw@public.gmane.org > Cc: Ouyang, Changchun > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup >=20 > Hi Helin, >=20 > > -----Original Message----- > > From: Zhang, Helin > > Sent: Wednesday, December 24, 2014 11:08 AM > > To: Ouyang, Changchun; dev-VfR2kkLFssw@public.gmane.org > > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup > > > > Is header split really supported in ixgbe? I guess not. If not, this > > code changes are not needed at all. > > >=20 > I don't try to modify any logic here, as you know vf rss don't have nothi= ng to do > with header split. But you modified code for header split. Have you validated it? > You mean " guess not ", can you 'make sure of it' rather than 'guess' if = you want > to remove those codes? I did not see anywhere can enable ixgbe header split. It is your turn to ma= ke sure if your code changes are needed and correct. I don't want to remove any code, just = want to know if your code have been validated for header split. >=20 > Thanks > Changchun