From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Helin" Subject: Re: [PATCH v2 0/7] unified flow types and RSS offload types Date: Tue, 24 Feb 2015 13:45:24 +0000 Message-ID: References: <1421650577-25969-1-git-send-email-helin.zhang@intel.com> <1423034193-26966-1-git-send-email-helin.zhang@intel.com> <9BB6961774997848B5B42BEC655768F8BA84DF@SHSMSX104.ccr.corp.intel.com> <3376568.d6DK7S5IQ4@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: <3376568.d6DK7S5IQ4@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > Sent: Monday, February 23, 2015 6:59 AM > To: Zhang, Helin > Cc: dev-VfR2kkLFssw@public.gmane.org; Wu, Jingjing; Chen, Jing D > Subject: Re: [dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload= types >=20 > > > It unifies the flow types and RSS offload types for all PMDs. > > > Previously flow types are defined specifically for i40e, and there > > > has different RSS offloads tyeps for 1/10G and 40G seperately. This > > > is not so convenient for application development, and not good for ad= ding > new PMDs. > > > In addition, it enables new RSS offloads of 'tcp' and 'all' in testpm= d. > > > > > > v2 changes: > > > * Integrated with configuring hash functions. > > > * Corrected the wrong help string of flow director parameters. > > > * Renamed the flow types from ETH_FLOW_TYPE_ to RTE_ETH_FLOW_. > > > * Removed useless annotations for flow type elements in rte_eth_ctrl.= h. > > > > > > Helin Zhang (7): > > > app/test-pmd: code style fix > > > ethdev: code style fix > > > i40e: code style fix > > > ethdev: fix of calculating the size of flow type mask array > > > ethdev: unification of flow types > > > ethdev: unification of RSS offload types > > > app/testpmd: support new rss offloads > > > > Acked-by: Jingjing Wu >=20 > Applied, thanks > There were some difficult merges with new flow director API and fm10K. > Please check everything is OK. Thank you very much! We expected that merges would be difficult, and Jingji= ng planned to work out a new version. But, you had done that for us! Thanks for your great helps to get it being = merged! We will check the master branch as a double check! Regards, Helin