From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Helin" Subject: Re: [PATCH 03/18] i40e: adjustment of register definitions and relevant Date: Tue, 28 Apr 2015 02:29:16 +0000 Message-ID: References: <1429518150-28098-1-git-send-email-helin.zhang@intel.com> <1429518150-28098-4-git-send-email-helin.zhang@intel.com> <1998049.eU2MTJspAg@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" , "Murray, Steven J" , "Shih, Chiu-Pi" , "Kenguva, Monica" To: Thomas Monjalon Return-path: In-Reply-To: <1998049.eU2MTJspAg@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Thomas New version is needed, as previous version has some code piece which should= n't be present there. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > Sent: Tuesday, April 28, 2015 1:17 AM > To: Zhang, Helin > Cc: dev-VfR2kkLFssw@public.gmane.org; Kenguva, Monica; Murray, Steven J; Shih, Chiu-Pi > Subject: Re: [dpdk-dev] [PATCH 03/18] i40e: adjustment of register defini= tions > and relevant >=20 > 2015-04-20 16:22, Helin Zhang: > > More register definitions and their relevant masks are added > > publically. Also few useless macros are deleted. > > > > Signed-off-by: Helin Zhang > > --- > > lib/librte_pmd_i40e/i40e/i40e_register.h | 1981 > > +++++++++++++++++++++++++++++- >=20 > All these values are not used in the driver, right? Driver read/write some of registers defined in this header file. All regist= ers and their relevant can be used by drivers, as these registers are treated as public r= egisters. Of cause there are registers which is for internal use only. >=20 > > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > > @@ -1269,9 +1269,6 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, > struct rte_eth_stats *stats) > > I40E_GLPRT_BPTCL(hw->port), > > pf->offset_loaded, &os->eth.tx_broadcast, > > &ns->eth.tx_broadcast); > > - i40e_stat_update_32(hw, I40E_GLPRT_TDPC(hw->port), > > - pf->offset_loaded, &os->eth.tx_discards, > > - &ns->eth.tx_discards); >=20 > The relation between this deletion and the rest of the patch is weird. All the registers defined in i40e_registers.h are public, though may not al= ready been used in driver. It is not so weird that one of the deleted registers was be= ing used in driver. Regards, Helin