From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Helin" Subject: Re: [PATCH] ixgbe: fix TSO in IPv6 Date: Tue, 16 Jun 2015 01:27:41 +0000 Message-ID: References: <1433160677-20847-1-git-send-email-david.marchand@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: David Marchand , "dev@dpdk.org" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E14735A5E for ; Tue, 16 Jun 2015 03:29:51 +0200 (CEST) In-Reply-To: <1433160677-20847-1-git-send-email-david.marchand@6wind.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand > Sent: Monday, June 1, 2015 8:11 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] ixgbe: fix TSO in IPv6 >=20 > From: Didier Pallard >=20 > When TSO is used with IPv6, generated frames are incorrect. > L4 frame is OK, but length field of IPv6 header was not populated correct= ly. >=20 > Signed-off-by: Didier Pallard > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxt= x.c > index 4f9ab22..d123612 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -375,10 +375,15 @@ ixgbe_set_xmit_ctx(struct ixgbe_tx_queue *txq, >=20 > /* check if TCP segmentation required for this packet */ > if (ol_flags & PKT_TX_TCP_SEG) { > - /* implies IP cksum and TCP cksum */ > - type_tucmd_mlhl =3D IXGBE_ADVTXD_TUCMD_IPV4 | > - IXGBE_ADVTXD_TUCMD_L4T_TCP | > - IXGBE_ADVTXD_DTYP_CTXT | IXGBE_ADVTXD_DCMD_DEXT; > + /* implies IP cksum in IPv4 */ > + if (ol_flags & PKT_TX_IP_CKSUM) > + type_tucmd_mlhl =3D IXGBE_ADVTXD_TUCMD_IPV4 | > + IXGBE_ADVTXD_TUCMD_L4T_TCP | > + IXGBE_ADVTXD_DTYP_CTXT | IXGBE_ADVTXD_DCMD_DEXT; > + else > + type_tucmd_mlhl =3D I'd prefer to put 'IXGBE_ADVTXD_TUCMD_IPV6' here to indicate it has set for= IPV6 specifically, though they are the same. It is clearer for future readers. - Helin > + IXGBE_ADVTXD_TUCMD_L4T_TCP | > + IXGBE_ADVTXD_DTYP_CTXT | IXGBE_ADVTXD_DCMD_DEXT; >=20 > tx_offload_mask.l2_len |=3D ~0; > tx_offload_mask.l3_len |=3D ~0; > -- > 1.7.10.4