From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Helin" Subject: Re: [PATCH v10 19/19] mbuf: remove old packet type bit masks Date: Mon, 13 Jul 2015 17:58:02 +0000 Message-ID: References: <1435912347-19499-1-git-send-email-helin.zhang@intel.com> <1436459501-14173-1-git-send-email-helin.zhang@intel.com> <1436459501-14173-20-git-send-email-helin.zhang@intel.com> <2161590.Y1eMLetJSj@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DF6C55683 for ; Mon, 13 Jul 2015 20:00:05 +0200 (CEST) In-Reply-To: <2161590.Y1eMLetJSj@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, July 13, 2015 9:13 AM > To: Zhang, Helin > Cc: dev@dpdk.org; Adrien Mazarguil > Subject: Re: [dpdk-dev] [PATCH v10 19/19] mbuf: remove old packet type bi= t > masks >=20 > 2015-07-10 00:31, Helin Zhang: > > As unified packet types are used instead, those old bit masks and the > > relevant macros for packet type indication need to be removed. >=20 > It breaks mlx4 and cxgbe drivers. >=20 > The mlx4 driver didn't have the chance to be updated in this series. > Adrien, please, could you help Helin to convert ol_flags to packet type? >=20 > The cxgbe changes need to be updated after > 78fc1a716ae8 ("cxgbe: improve Rx performance") I suggest this update: >=20 > --- a/drivers/net/cxgbe/sge.c > +++ b/drivers/net/cxgbe/sge.c > @@ -1419,7 +1419,11 @@ static int process_responses(struct sge_rspq *q, i= nt > budget, > unmap_rx_buf(&rxq->fl); >=20 > if (cpl->l2info & htonl(F_RXF_IP)) { > +#ifdef RTE_NEXT_ABI > + mbuf->packet_type =3D RTE_PTYPE_L3_IPV4; > +#else > pkt->ol_flags |=3D PKT_RX_IPV4_HDR; > +#endif > if (unlikely(!csum_ok)) > pkt->ol_flags |=3D > PKT_RX_IP_CKSUM_BAD; >=20 > @@ -1427,7 +1431,11 @@ static int process_responses(struct sge_rspq *q, i= nt > budget, > htonl(F_RXF_UDP | F_RXF_TCP)) > && !csum_ok) > pkt->ol_flags |=3D > PKT_RX_L4_CKSUM_BAD; > } else if (cpl->l2info & htonl(F_RXF_IP6)) { > +#ifdef RTE_NEXT_ABI > + mbuf->packet_type =3D RTE_PTYPE_L3_IPV6; > +#else > pkt->ol_flags |=3D PKT_RX_IPV6_HDR; > +#endif > } Acked-by: Helin Zhang