From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Helin" Subject: Re: [PATCH v2] ixgbe: Fix disable interrupt twice Date: Tue, 23 Feb 2016 02:10:57 +0000 Message-ID: References: <1454046700-20843-1-git-send-email-michael.qiu@intel.com> <1454047090-21274-1-git-send-email-michael.qiu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Qiu, Michael" , "dev@dpdk.org" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F0A752BFF for ; Tue, 23 Feb 2016 03:11:04 +0100 (CET) In-Reply-To: <1454047090-21274-1-git-send-email-michael.qiu@intel.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu > Sent: Friday, January 29, 2016 1:58 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice >=20 > Currently, ixgbe vf and pf will disable interrupt twice in stop stage and= uninit > stage. It will cause an error: >=20 > testpmd> quit >=20 > Shutting down port 0... > Stopping ports... > Done > Closing ports... > EAL: Error disabling MSI-X interrupts for fd 26 > Done >=20 > Becasue the interrupt already been disabled in stop stage. > Since it is enabled in init stage, better remove from stop stage. >=20 > Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF") >=20 > Signed-off-by: Michael Qiu Acked-by: Helin Zhang > --- > v2 --> v1: > fix error in commit log word "interrupte" >=20 > drivers/net/ixgbe/ixgbe_ethdev.c | 6 ------ > 1 file changed, 6 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 4c4c6df..a561f8d 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2192,9 +2192,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev) > /* disable interrupts */ > ixgbe_disable_intr(hw); >=20 > - /* disable intr eventfd mapping */ > - rte_intr_disable(intr_handle); > - > /* reset the NIC */ > ixgbe_pf_reset_hw(hw); > hw->adapter_stopped =3D 0; > @@ -3898,9 +3895,6 @@ ixgbevf_dev_stop(struct rte_eth_dev *dev) >=20 > ixgbe_dev_clear_queues(dev); >=20 > - /* disable intr eventfd mapping */ > - rte_intr_disable(intr_handle); > - > /* Clean datapath event and queue/vec mapping */ > rte_intr_efd_disable(intr_handle); > if (intr_handle->intr_vec !=3D NULL) { > -- > 1.9.3