From: "Zhang, Helin" <helin.zhang@intel.com>
To: henry <caihe@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"zhoujingbin@huawei.com" <zhoujingbin@huawei.com>
Subject: Re: [PATCH v3] net/i40e: fix return value check issue
Date: Wed, 5 Apr 2017 15:34:07 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71AA513D3@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1491398393-14200-1-git-send-email-caihe@huawei.com>
> -----Original Message-----
> From: henry [mailto:caihe@huawei.com]
> Sent: Wednesday, April 5, 2017 9:20 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Wu, Jingjing; zhoujingbin@huawei.com; henry cai
> Subject: [PATCH v3] net/i40e: fix return value check issue
>
> From: henry cai <caihe@huawei.com>
>
> function i40evf_add_del_all_mac_addr without check return value of
> rte_zmalloc
>
> Fixes: 97ac72aa71a9 ("i40e: support setting VF MAC address ")
>
> Signed-off-by: henry cai <caihe@huawei.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index d3659c9..3e0e2e1 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2016,6 +2016,10 @@ static int i40evf_dev_xstats_get(struct rte_eth_dev
> *dev,
> }
>
> list = rte_zmalloc("i40evf_del_mac_buffer", len, 0);
> + if (!list) {
> + PMD_DRV_LOG(ERR, "fail to allocate memory");
> + return;
> + }
>
> for (i = begin; i < next_begin; i++) {
> addr = &dev->data->mac_addrs[i];
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2017-04-05 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 13:19 [PATCH v3] net/i40e: fix return value check issue henry
2017-04-05 15:34 ` Zhang, Helin [this message]
2017-04-06 1:06 ` 答复: " caihe
2017-04-06 6:35 ` Zhang, Helin
2017-04-06 7:26 ` 答复: " caihe
2017-04-06 8:27 ` Zhang, Helin
2017-04-06 9:02 ` Ferruh Yigit
2017-04-07 10:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71AA513D3@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=caihe@huawei.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=zhoujingbin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.