From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Helin" Subject: Re: [PATCH] net/i40e: disable init and driver logs by default Date: Thu, 6 Apr 2017 14:31:23 +0000 Message-ID: References: <20170406141655.15097-1-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Wu, Jingjing" , "Richardson, Bruce" , "Yigit, Ferruh" To: Olivier Matz , "dev@dpdk.org" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 759A82C5 for ; Thu, 6 Apr 2017 16:31:28 +0200 (CEST) In-Reply-To: <20170406141655.15097-1-olivier.matz@6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- From: Olivier Matz [mailto:olivier.matz@6wind.com]=20 Sent: Thursday, April 6, 2017 10:17 PM To: dev@dpdk.org Cc: Zhang, Helin ; Wu, Jingjing ; Richardson, Bruce ; Yigit, Ferruh Subject: [PATCH] net/i40e: disable init and driver logs by default Since "net/i40e: use dynamic log type for control logs", the i40e driver is= more verbose by default, which could result in testpmd being flooded by lo= g messages in some conditions: Checking link statuses... i40e_dev_handle_aq_msg(): Request 2561 is not supported yet i40e_dev_handle_aq_msg(): Request 2561 is not supported yet i40e_dev_handle_aq_msg(): Request 2561 is not supported yet i40e_dev_handle_aq_msg(): Request 2561 is not supported yet Port 0 Link Up - speed 40000 Mbps - full-duplex Port 1 Link Up - speed 40000 Mbps - full-duplex Done testpmd> i40e_dev_handle_aq_msg(): Request 4097 is not supported yet i40e_dev_handle_aq_msg(): Request 4097 is not supported yet i40e_dev_handle_aq_msg(): Request 4097 is not supported yet Fix this by disabling the dynamic logs by default. It is still possible to = enable them at runtime. Fixes: c143e5a3d9e1 ("net/i40e: use dynamic log type for control logs") Signed-off-by: Olivier Matz Acked-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.= c index cb8bf2b49..86f5669f0 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -12456,8 +12456,8 @@ i40e_init_log(void) { i40e_logtype_init =3D rte_log_register("pmd.i40e.init"); if (i40e_logtype_init >=3D 0) - rte_log_set_level(i40e_logtype_init, RTE_LOG_NOTICE); + rte_log_set_level(i40e_logtype_init, RTE_LOG_EMERG); i40e_logtype_driver =3D rte_log_register("pmd.i40e.driver"); if (i40e_logtype_driver >=3D 0) - rte_log_set_level(i40e_logtype_driver, RTE_LOG_NOTICE); + rte_log_set_level(i40e_logtype_driver, RTE_LOG_EMERG); } -- 2.11.0