From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Helin" Subject: Re: [PATCH v2] librte_mbuf: modify port initialization value Date: Tue, 5 Sep 2017 05:20:35 +0000 Message-ID: References: <20170904065532.13055-1-zhiyong.yang@intel.com> <20170905051319.11223-1-zhiyong.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Yang, Zhiyong" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BDE472C2F for ; Tue, 5 Sep 2017 07:20:38 +0200 (CEST) In-Reply-To: <20170905051319.11223-1-zhiyong.yang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Tuesday, September 5, 2017 1:13 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Yigit, Ferruh; stephen@networkplumber.org; Yang, > Zhiyong > Subject: [dpdk-dev] [PATCH v2] librte_mbuf: modify port initialization va= lue >=20 > In order to support more than 256 virtual ports, the field "port" > in rte_mbuf has been increased to 16 bits. The initialization/reset value= of the > field "port" should be changed from 0xff to 0xffff accordingly. >=20 > Signed-off-by: Zhiyong Yang > --- >=20 > Changes in V2: > Introduce MBUF_INVALID_PORT as a constant. >=20 > lib/librte_mbuf/rte_mbuf.c | 2 +- > lib/librte_mbuf/rte_mbuf.h | 4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c inde= x > 26a62b8e1..bcf4e2fcf 100644 > --- a/lib/librte_mbuf/rte_mbuf.c > +++ b/lib/librte_mbuf/rte_mbuf.c > @@ -144,7 +144,7 @@ rte_pktmbuf_init(struct rte_mempool *mp, > /* init some constant fields */ > m->pool =3D mp; > m->nb_segs =3D 1; > - m->port =3D 0xff; > + m->port =3D MBUF_INVALID_PORT; > rte_mbuf_refcnt_set(m, 1); > m->next =3D NULL; > } > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h inde= x > eaed7eee0..e32038a73 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -1087,6 +1087,8 @@ static inline void > rte_pktmbuf_reset_headroom(struct rte_mbuf *m) > * @param m > * The packet mbuf to be resetted. > */ > +#define MBUF_INVALID_PORT 0xffff Replaced with below, or use UINT16_MAX directly? #define MBUF_INVALID_PORT UINT16_MAX > + > static inline void rte_pktmbuf_reset(struct rte_mbuf *m) { > m->next =3D NULL; > @@ -1095,7 +1097,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbu= f > *m) > m->vlan_tci =3D 0; > m->vlan_tci_outer =3D 0; > m->nb_segs =3D 1; > - m->port =3D 0xff; > + m->port =3D MBUF_INVALID_PORT; >=20 > m->ol_flags =3D 0; > m->packet_type =3D 0; > -- > 2.13.3