From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhang, Helin" <helin.zhang@intel.com>
Subject: Re: [PATCH v5] net/i40e: fix disabling promiscuous mode
Date: Tue, 8 May 2018 01:47:38 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71AEA80C7@SHSMSX103.ccr.corp.intel.com>
References: <1521090873-50595-1-git-send-email-rosen.xu@intel.com>
 <1524915533-96768-1-git-send-email-rosen.xu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>
To: "Xu, Rosen" <rosen.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 1FA872C6A
 for <dev@dpdk.org>; Tue,  8 May 2018 03:47:41 +0200 (CEST)
In-Reply-To: <1524915533-96768-1-git-send-email-rosen.xu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Xu, Rosen
> Sent: Saturday, April 28, 2018 7:39 PM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Zhang, Qi Z; Wu, Jingjing; stable@dpdk.org
> Subject: [PATCH v5] net/i40e: fix disabling promiscuous mode
>=20
> v5 updates:
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>  - Modificate some comments for this patch
>=20
> v4 updates:
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>  - Add some comments for this patch
>=20
> v3 updates:
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>  - Move modification from device close to device disable
>  - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous=
,
>    so unicast/multicast promiscuous disable should set before reset.
>=20
> v2 updates:
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>  - Add more comments
>=20
> In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit does=
n't
> disable promiscuous mode, this will cause vlan filter set by Kernel Drive=
r will
> not take effect.
>=20
> This patch will fix it, add promiscuous disable at device disable.
>=20
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!

Helin