From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbdCCSXt convert rfc822-to-8bit (ORCPT ); Fri, 3 Mar 2017 13:23:49 -0500 Received: from terminus.zytor.com ([65.50.211.136]:40726 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbdCCSXq (ORCPT ); Fri, 3 Mar 2017 13:23:46 -0500 Date: Fri, 03 Mar 2017 10:20:11 -0800 User-Agent: K-9 Mail for Android In-Reply-To: <20170301102754.GA13374@gmail.com> References: <20170217104757.28588-1-jslaby@suse.cz> <20170301093855.GA27152@gmail.com> <20170301102754.GA13374@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data To: Ingo Molnar , Thomas Gleixner CC: Jiri Slaby , mingo@redhat.com, x86@kernel.org, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, Boris Ostrovsky , Juergen Gross , xen-devel@lists.xenproject.org, "Rafael J. Wysocki" , Len Brown , Pavel Machek , linux-pm@vger.kernel.org, Linus Torvalds , Andrew Morton , Peter Zijlstra From: hpa@zytor.com Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On March 1, 2017 2:27:54 AM PST, Ingo Molnar wrote: > >* Thomas Gleixner wrote: > >> On Wed, 1 Mar 2017, Ingo Molnar wrote: >> > >> > * Jiri Slaby wrote: >> > >> > > This is a start of series to unify use of ENTRY, ENDPROC, GLOBAL, >END, >> > > and other macros across x86. When we have all this sorted out, >this will >> > > help to inject DWARF unwinding info by objtool later. >> > > >> > > So, let us use the macros this way: >> > > * ENTRY -- start of a global function >> > > * ENDPROC -- end of a local/global function >> > > * GLOBAL -- start of a globally visible data symbol >> > > * END -- end of local/global data symbol >> > >> > So how about using macro names that actually show the purpose, >instead of >> > importing all the crappy, historic, essentially randomly chosen >debug symbol macro >> > names from the binutils and older kernels? >> > >> > Something sane, like: >> > >> > SYM__FUNCTION_START >> >> Sane would be: >> >> SYM_FUNCTION_START >> >> The double underscore is just not giving any value. > >So the double underscore (at least in my view) has two advantages: > >1) it helps separate the prefix from the postfix. > >I.e. it's a 'symbols' namespace, and a 'function start', not the >'start' of a >'symbol function'. > >2) It also helps easy greppability. > >Try this in latest -tip: > > git grep e820__ > >To see all the E820 API calls - with no false positives! > >'git grep e820_' on the other hand is a lot less reliable... > >But no strong feelings either way, I just try to sneak in these small >namespace >structure tricks when nobody's looking! ;-) > >Thanks, > > Ingo This seems needlessly verbose to me and clutters the code. How about: PROC..ENDPROC, LOCALPROC..ENDPROC and DATA..ENDDATA. Clear, unambiguous and balanced. -- Sent from my Android device with K-9 Mail. Please excuse my brevity. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hpa@zytor.com Subject: Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data Date: Fri, 03 Mar 2017 10:20:11 -0800 Message-ID: References: <20170217104757.28588-1-jslaby@suse.cz> <20170301093855.GA27152@gmail.com> <20170301102754.GA13374@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170301102754.GA13374@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ingo Molnar , Thomas Gleixner Cc: Juergen Gross , Len Brown , Peter Zijlstra , linux-pm@vger.kernel.org, Linus Torvalds , x86@kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, mingo@redhat.com, Pavel Machek , jpoimboe@redhat.com, xen-devel@lists.xenproject.org, Boris Ostrovsky , Jiri Slaby , Andrew Morton List-Id: linux-pm@vger.kernel.org T24gTWFyY2ggMSwgMjAxNyAyOjI3OjU0IEFNIFBTVCwgSW5nbyBNb2xuYXIgPG1pbmdvQGtlcm5l bC5vcmc+IHdyb3RlOgo+Cj4qIFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPiB3 cm90ZToKPgo+PiBPbiBXZWQsIDEgTWFyIDIwMTcsIEluZ28gTW9sbmFyIHdyb3RlOgo+PiA+IAo+ PiA+ICogSmlyaSBTbGFieSA8anNsYWJ5QHN1c2UuY3o+IHdyb3RlOgo+PiA+IAo+PiA+ID4gVGhp cyBpcyBhIHN0YXJ0IG9mIHNlcmllcyB0byB1bmlmeSB1c2Ugb2YgRU5UUlksIEVORFBST0MsIEdM T0JBTCwKPkVORCwKPj4gPiA+IGFuZCBvdGhlciBtYWNyb3MgYWNyb3NzIHg4Ni4gV2hlbiB3ZSBo YXZlIGFsbCB0aGlzIHNvcnRlZCBvdXQsCj50aGlzIHdpbGwKPj4gPiA+IGhlbHAgdG8gaW5qZWN0 IERXQVJGIHVud2luZGluZyBpbmZvIGJ5IG9ianRvb2wgbGF0ZXIuCj4+ID4gPiAKPj4gPiA+IFNv LCBsZXQgdXMgdXNlIHRoZSBtYWNyb3MgdGhpcyB3YXk6Cj4+ID4gPiAqIEVOVFJZIC0tIHN0YXJ0 IG9mIGEgZ2xvYmFsIGZ1bmN0aW9uCj4+ID4gPiAqIEVORFBST0MgLS0gZW5kIG9mIGEgbG9jYWwv Z2xvYmFsIGZ1bmN0aW9uCj4+ID4gPiAqIEdMT0JBTCAtLSBzdGFydCBvZiBhIGdsb2JhbGx5IHZp c2libGUgZGF0YSBzeW1ib2wKPj4gPiA+ICogRU5EIC0tIGVuZCBvZiBsb2NhbC9nbG9iYWwgZGF0 YSBzeW1ib2wKPj4gPiAKPj4gPiBTbyBob3cgYWJvdXQgdXNpbmcgbWFjcm8gbmFtZXMgdGhhdCBh Y3R1YWxseSBzaG93IHRoZSBwdXJwb3NlLAo+aW5zdGVhZCBvZiAKPj4gPiBpbXBvcnRpbmcgYWxs IHRoZSBjcmFwcHksIGhpc3RvcmljLCBlc3NlbnRpYWxseSByYW5kb21seSBjaG9zZW4KPmRlYnVn IHN5bWJvbCBtYWNybyAKPj4gPiBuYW1lcyBmcm9tIHRoZSBiaW51dGlscyBhbmQgb2xkZXIga2Vy bmVscz8KPj4gPiAKPj4gPiBTb21ldGhpbmcgc2FuZSwgbGlrZToKPj4gPiAKPj4gPiAJU1lNX19G VU5DVElPTl9TVEFSVAo+PiAKPj4gU2FuZSB3b3VsZCBiZToKPj4gCj4+ICAgICAgCVNZTV9GVU5D VElPTl9TVEFSVAo+PiAKPj4gVGhlIGRvdWJsZSB1bmRlcnNjb3JlIGlzIGp1c3Qgbm90IGdpdmlu ZyBhbnkgdmFsdWUuCj4KPlNvIHRoZSBkb3VibGUgdW5kZXJzY29yZSAoYXQgbGVhc3QgaW4gbXkg dmlldykgaGFzIHR3byBhZHZhbnRhZ2VzOgo+Cj4xKSBpdCBoZWxwcyBzZXBhcmF0ZSB0aGUgcHJl Zml4IGZyb20gdGhlIHBvc3RmaXguCj4KPkkuZS4gaXQncyBhICdzeW1ib2xzJyBuYW1lc3BhY2Us IGFuZCBhICdmdW5jdGlvbiBzdGFydCcsIG5vdCB0aGUKPidzdGFydCcgb2YgYSAKPidzeW1ib2wg ZnVuY3Rpb24nLgo+Cj4yKSBJdCBhbHNvIGhlbHBzIGVhc3kgZ3JlcHBhYmlsaXR5Lgo+Cj5Ucnkg dGhpcyBpbiBsYXRlc3QgLXRpcDoKPgo+ICBnaXQgZ3JlcCBlODIwX18KPgo+VG8gc2VlIGFsbCB0 aGUgRTgyMCBBUEkgY2FsbHMgLSB3aXRoIG5vIGZhbHNlIHBvc2l0aXZlcyEKPgo+J2dpdCBncmVw IGU4MjBfJyBvbiB0aGUgb3RoZXIgaGFuZCBpcyBhIGxvdCBsZXNzIHJlbGlhYmxlLi4uCj4KPkJ1 dCBubyBzdHJvbmcgZmVlbGluZ3MgZWl0aGVyIHdheSwgSSBqdXN0IHRyeSB0byBzbmVhayBpbiB0 aGVzZSBzbWFsbAo+bmFtZXNwYWNlIAo+c3RydWN0dXJlIHRyaWNrcyB3aGVuIG5vYm9keSdzIGxv b2tpbmchIDstKQo+Cj5UaGFua3MsCj4KPglJbmdvCgpUaGlzIHNlZW1zIG5lZWRsZXNzbHkgdmVy Ym9zZSB0byBtZSBhbmQgY2x1dHRlcnMgdGhlIGNvZGUuCgpIb3cgYWJvdXQ6CgpQUk9DLi5FTkRQ Uk9DLCBMT0NBTFBST0MuLkVORFBST0MgYW5kIERBVEEuLkVORERBVEEuICBDbGVhciwgdW5hbWJp Z3VvdXMgYW5kIGJhbGFuY2VkLgoKCi0tIApTZW50IGZyb20gbXkgQW5kcm9pZCBkZXZpY2Ugd2l0 aCBLLTkgTWFpbC4gUGxlYXNlIGV4Y3VzZSBteSBicmV2aXR5LgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4t ZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==