From: Peter Lieven <pl@kamp.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 10/17] block: define get_block_status return value
Date: Thu, 4 Jul 2013 23:10:56 +0200 [thread overview]
Message-ID: <F3DBD7B6-530F-423C-B41D-BAB28D2D537C@kamp.de> (raw)
In-Reply-To: <51D52EB3.2000508@redhat.com>
Am 04.07.2013 um 10:13 schrieb Paolo Bonzini <pbonzini@redhat.com>:
> Il 03/07/2013 23:04, Peter Lieven ha scritto:
>>>> Define the return value of get_block_status. Bits 0, 1, 2 and 8-62
>>>> are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-7
>>>> are left for future extensions.
>> Is Bit 8 not also reserved for future use? BDRV_SECTOR_BITS is 9.
>
> Right.
>
>> Can you explain which information is exactly returned in Bits 9-62?
>
> Bits 9-62 are the offset at which the data is stored in bs->file, they
> are valid if bit 2 (BDRV_BLOCK_OFFSET_VALID) is 1.
Ok, so this is if bs->file is not linear?
If we return the offset into bs->file this would only make sense if the data
at that position is raw and not encoded otherwise and if *pnum is limited
to the size of the extend at that position, right?
I currently do not understand for what operation this info is needed.
Maybe you could add some info to the commit or the function including
your comment from above.
Thanks,
Peter
next prev parent reply other threads:[~2013-07-04 21:11 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 14:34 [Qemu-devel] [PATCH 00/17] Add qemu-img subcommand to dump file metadata Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 01/17] cow: make reads go at a decent speed Paolo Bonzini
2013-07-04 2:20 ` Fam Zheng
2013-07-04 8:08 ` Paolo Bonzini
2013-07-05 9:09 ` Stefan Hajnoczi
2013-07-03 14:34 ` [Qemu-devel] [PATCH 02/17] cow: make writes go at a less indecent speed Paolo Bonzini
2013-07-04 2:40 ` Fam Zheng
2013-07-04 8:11 ` Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 03/17] cow: do not call bdrv_co_is_allocated Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 04/17] block: make bdrv_co_is_allocated static Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 05/17] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 06/17] block: expect errors from bdrv_co_is_allocated Paolo Bonzini
2013-07-05 9:19 ` Stefan Hajnoczi
2013-07-05 10:28 ` Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 07/17] qemu-img: always probe the input image for allocated sectors Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 08/17] block: make bdrv_has_zero_init return false for copy-on-write-images Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 09/17] block: introduce bdrv_get_block_status API Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 10/17] block: define get_block_status return value Paolo Bonzini
2013-07-03 21:04 ` Peter Lieven
2013-07-04 8:13 ` Paolo Bonzini
2013-07-04 21:10 ` Peter Lieven [this message]
2013-07-05 0:49 ` Fam Zheng
2013-07-03 14:34 ` [Qemu-devel] [PATCH 11/17] block: return get_block_status data and flags for formats Paolo Bonzini
2013-07-04 3:22 ` Fam Zheng
2013-07-04 8:14 ` Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand Paolo Bonzini
2013-07-04 5:34 ` Fam Zheng
2013-07-04 8:16 ` Paolo Bonzini
2013-07-04 8:36 ` Fam Zheng
2013-07-16 3:31 ` Stefan Hajnoczi
2013-07-16 6:26 ` Paolo Bonzini
2013-07-18 20:04 ` Eric Blake
2013-07-19 4:48 ` Stefan Hajnoczi
2013-07-19 5:54 ` Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 13/17] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 14/17] raw-posix: return get_block_status data and flags Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 15/17] raw-posix: detect XFS unwritten extents Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 16/17] block: add default get_block_status implementation for protocols Paolo Bonzini
2013-07-16 6:47 ` Peter Lieven
2013-07-16 7:19 ` Paolo Bonzini
2013-07-16 7:54 ` Peter Lieven
2013-07-16 9:37 ` Paolo Bonzini
2013-07-17 10:26 ` Peter Lieven
2013-07-17 10:33 ` Paolo Bonzini
2013-07-03 14:34 ` [Qemu-devel] [PATCH 17/17] block: look for zero blocks in bs->file Paolo Bonzini
2013-07-16 3:41 ` [Qemu-devel] [PATCH 00/17] Add qemu-img subcommand to dump file metadata Stefan Hajnoczi
2013-07-16 6:49 ` Peter Lieven
2013-07-18 3:54 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F3DBD7B6-530F-423C-B41D-BAB28D2D537C@kamp.de \
--to=pl@kamp.de \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.